@@ -739,8 +739,11 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
return -ENOMEM;
ep->outbound_addr = addr;
- if (pci->link_gen < 1)
+ if (pci->link_gen < 1) {
pci->link_gen = of_pci_get_max_link_speed(np);
+ if (pci->link_gen < 0)
+ dev_warn(dev, "Invalid to get max-link-speed from DT\n");
+ }
epc = devm_pci_epc_create(dev, &epc_ops);
if (IS_ERR(epc)) {
@@ -429,8 +429,11 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)
pp->io_base = pci_pio_to_address(win->res->start);
}
- if (pci->link_gen < 1)
+ if (pci->link_gen < 1) {
pci->link_gen = of_pci_get_max_link_speed(np);
+ if (pci->link_gen < 0)
+ dev_warn(dev, "Invalid to get max-link-speed from DT\n");
+ }
/* Set default bus ops */
bridge->ops = &dw_pcie_ops;
of_pci_get_max_link_speed() may return a negative value, causing the controller to not set the speed correctly. Add a warning in case the driver engineer misses it. Signed-off-by: Harry Song <jundongsong1@gmail.com> --- V2: Change the description of the subject line; Remove unnecessary "unlikely"; Thanks for your comment, V1 is this one: https://lore.kernel.org/lkml/20221110213239.GA672651@bhelgaas/ drivers/pci/controller/dwc/pcie-designware-ep.c | 5 ++++- drivers/pci/controller/dwc/pcie-designware-host.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)