[07/39] genirq/msi: Make __msi_domain_alloc_irqs() static

Message ID	20221111122014.004725919@linutronix.de
State	New
Headers	show Return-Path: <linux-pci-owner@vger.kernel.org> Message-ID: <20221111122014.004725919@linutronix.de> From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> Cc: x86@kernel.org, Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Marc Zyngier <maz@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jason Gunthorpe <jgg@mellanox.com>, Dave Jiang <dave.jiang@intel.com>, Alex Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Dan Williams <dan.j.williams@intel.com>, Logan Gunthorpe <logang@deltatee.com>, Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>, Allen Hubbe <allenbh@gmail.com>, Michael Ellerman <mpe@ellerman.id.au>, Christophe Leroy <christophe.leroy@csgroup.eu>, linuxppc-dev@lists.ozlabs.org, "Ahmed S. Darwish" <darwi@linutronix.de>, Reinette Chatre <reinette.chatre@intel.com> Subject: [patch 07/39] genirq/msi: Make __msi_domain_alloc_irqs() static References: <20221111120501.026511281@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Fri, 11 Nov 2022 14:54:25 +0100 (CET) Precedence: bulk
Series	genirq, PCI/MSI: Support for per device MSI and PCI/IMS - Part 1 cleanups \| expand [00/39] genirq, PCI/MSI: Support for per device MSI and PCI/IMS - Part 1 cleanups [01/39] PCI/MSI: Check for MSI enabled in __pci_msix_enable() [02/39] iommu/vt-d: Remove bogus check for multi MSI-X [03/39] iommu/amd: Remove bogus check for multi MSI-X [04/39] genirq/msi: Use MSI_DESC_ALL in msi_add_simple_msi_descs() [05/39] genirq/msi: Remove filter from msi_free_descs_free_range() [06/39] genirq/msi: Add missing kernel doc to msi_next_desc() [07/39] genirq/msi: Make __msi_domain_alloc_irqs() static [08/39] genirq/msi: Provide msi_domain_ops::post_free() [09/39] powerpc/pseries/msi: Use msi_domain_ops::msi_post_free() [10/39] genirq/msi: Make __msi_domain_free_irqs() static [11/39] genirq/irqdomain: Move bus token enum into a seperate header [12/39] genirq/msi: Add bus token to struct msi_domain_info [13/39] PCI/MSI: Use msi_domain_info::bus_token [14/39] PCI/MSI: Let the MSI core free descriptors [15/39] PCI/MSI: Get rid of PCI_MSI_IRQ_DOMAIN [16/39] genirq: Get rid of GENERIC_MSI_IRQ_DOMAIN [17/39] PCI/MSI: Get rid of externs in msi.h [18/39] PCI/MSI: Move mask and unmask helpers to msi.h [19/39] PCI/MSI: Move pci_disable_msi() to api.c [20/39] PCI/MSI: Move pci_enable_msi() API to api.c [21/39] PCI/MSI: Move pci_enable_msix_range() to api.c [22/39] PCI/MSI: Move pci_alloc_irq_vectors() to api.c [23/39] PCI/MSI: Move pci_alloc_irq_vectors_affinity() to api.c [24/39] PCI/MSI: Move pci_irq_vector() to api.c [25/39] PCI/MSI: Move pci_free_irq_vectors() to api.c [26/39] PCI/MSI: Move pci_msix_vec_count() to api.c [27/39] PCI/MSI: Move pci_disable_msix() to api.c [28/39] PCI/MSI: Move pci_irq_get_affinity() to api.c [29/39] PCI/MSI: Move pci_msi_enabled() to api.c [30/39] PCI/MSI: Move pci_msi_restore_state() to api.c [31/39] Documentation: PCI: Add reference to PCI/MSI device driver APIs [32/39] PCI/MSI: Reorder functions in msi.c [33/39] PCI/MSI: Sanitize MSI-X checks [34/39] PCI/MSI: Reject multi-MSI early [35/39] PCI/MSI: Reject MSI-X early [36/39] PCI/MSI: Validate MSIX contiguous restriction early [37/39] PCI/MSI: Remove redundant msi_check() callback [38/39] genirq/msi: Remove msi_domain_ops::msi_check() [39/39] x86/apic: Remove X86_IRQ_ALLOC_CONTIGUOUS_VECTORS

Message ID

20221111122014.004725919@linutronix.de

State

New

Headers

Message-ID: <20221111122014.004725919@linutronix.de>
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>, linux-pci@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>
Subject: [patch 07/39] genirq/msi: Make __msi_domain_alloc_irqs() static
References: <20221111120501.026511281@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 11 Nov 2022 14:54:25 +0100 (CET)
Precedence: bulk

Series

genirq, PCI/MSI: Support for per device MSI and PCI/IMS - Part 1 cleanups | expand

Nothing outside of the core code requires this. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- include/linux/msi.h | 7 ++----- kernel/irq/msi.c | 6 ++++-- 2 files changed, 6 insertions(+), 7 deletions(-)

Comments

Jason Gunthorpe Nov. 16, 2022, 5:44 p.m. UTC | #1

On Fri, Nov 11, 2022 at 02:54:25PM +0100, Thomas Gleixner wrote:
> Nothing outside of the core code requires this.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  include/linux/msi.h |    7 ++-----
>  kernel/irq/msi.c    |    6 ++++--
>  2 files changed, 6 insertions(+), 7 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -334,9 +334,8 @@  struct msi_domain_info;
  * MSI_FLAG_USE_DEF_DOM_OPS is not set to avoid breaking existing users and
  * because these callbacks are obviously mandatory.
  *
- * This is NOT meant to be abused, but it can be useful to build wrappers
- * for specialized MSI irq domains which need extra work before and after
- * calling __msi_domain_alloc_irqs()/__msi_domain_free_irqs().
+ * __msi_domain_free_irqs() is exposed for PPC pseries to handle extra
+ * work after all interrupts and descriptors have been freed.
  */
 struct msi_domain_ops {
 	irq_hw_number_t	(*get_hwirq)(struct msi_domain_info *info,
@@ -425,8 +424,6 @@  int msi_domain_set_affinity(struct irq_d
 struct irq_domain *msi_create_irq_domain(struct fwnode_handle *fwnode,
 					 struct msi_domain_info *info,
 					 struct irq_domain *parent);
-int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
-			    int nvec);
 int msi_domain_alloc_irqs_descs_locked(struct irq_domain *domain, struct device *dev,
 				       int nvec);
 int msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -462,6 +462,8 @@  static inline void msi_sysfs_remove_desc
 #endif /* !CONFIG_SYSFS */
 
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+static int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev, int nvec);
+
 static inline void irq_chip_write_msi_msg(struct irq_data *data,
 					  struct msi_msg *msg)
 {
@@ -852,8 +854,8 @@  static int msi_init_virq(struct irq_doma
 	return 0;
 }
 
-int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
-			    int nvec)
+static int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
+				   int nvec)
 {
 	struct msi_domain_info *info = domain->host_data;
 	struct msi_domain_ops *ops = info->ops;

[07/39] genirq/msi: Make __msi_domain_alloc_irqs() static

Commit Message

Comments

Patch