diff mbox series

[RFC,v2,16/39] leds: add HAS_IOPORT dependencies

Message ID 20220429135108.2781579-29-schnelle@linux.ibm.com
State New
Headers show
Series Kconfig: Introduce HAS_IOPORT config option | expand

Commit Message

Niklas Schnelle April 29, 2022, 1:50 p.m. UTC
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
not being declared. We thus need to add HAS_IOPORT as dependency for
those drivers using them.

Co-developed-by: Arnd Bergmann <arnd@kernel.org>
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
---
 drivers/leds/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pavel Machek April 29, 2022, 6:54 p.m. UTC | #1
Hi!

> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them.
> 
> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>

I don't see a problem there.

Acked-by: Pavel Machek <pavel@ucw.cz>

(Its marked RFC so I'm not taking the patch.. right?)

Best regards,
								Pavel
Niklas Schnelle May 2, 2022, 8:31 a.m. UTC | #2
On Fri, 2022-04-29 at 20:54 +0200, Pavel Machek wrote:
> Hi!
> 
> > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> > not being declared. We thus need to add HAS_IOPORT as dependency for
> > those drivers using them.
> > 
> > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> 
> I don't see a problem there.
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>
> 
> (Its marked RFC so I'm not taking the patch.. right?)
> 
> Best regards,
> 								Pavel

Right and thank you.
diff mbox series

Patch

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 6090e647daee..d05b7b035b13 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -681,7 +681,7 @@  config LEDS_LM355x
 
 config LEDS_OT200
 	tristate "LED support for the Bachmann OT200"
-	depends on LEDS_CLASS && HAS_IOMEM && (X86_32 || COMPILE_TEST)
+	depends on LEDS_CLASS && HAS_IOPORT && (X86_32 || COMPILE_TEST)
 	help
 	  This option enables support for the LEDs on the Bachmann OT200.
 	  Say Y to enable LEDs on the Bachmann OT200.