| Message ID | 20220422120850.769480-8-herve.codina@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | RZN1 USB Host support | expand |
Hello! On 4/22/22 3:08 PM, Herve Codina wrote: > Define the r9a06g032 generic part of the USB PHY device node. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > --- > arch/arm/boot/dts/r9a06g032.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi > index 33581f0c55c4..58af07eb75c9 100644 > --- a/arch/arm/boot/dts/r9a06g032.dtsi > +++ b/arch/arm/boot/dts/r9a06g032.dtsi > @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk { > clock-frequency = <0>; > }; > > + usbphy: usbphy { I think the node name should be "usb-phy"... [...] MBR, Sergey
On 4/23/22 12:09 PM, Sergey Shtylyov wrote: [...] >> Define the r9a06g032 generic part of the USB PHY device node. >> >> Signed-off-by: Herve Codina <herve.codina@bootlin.com> >> --- >> arch/arm/boot/dts/r9a06g032.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi >> index 33581f0c55c4..58af07eb75c9 100644 >> --- a/arch/arm/boot/dts/r9a06g032.dtsi >> +++ b/arch/arm/boot/dts/r9a06g032.dtsi >> @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk { >> clock-frequency = <0>; >> }; >> >> + usbphy: usbphy { > > I think the node name should be "usb-phy"... It's not my thinking alone, the DT spec documents "usb-phy" in section 2.2.2. :-) > [...] MBR, Sergey
Hi Sergey, On Sat, 23 Apr 2022 19:41:09 +0300 Sergey Shtylyov <s.shtylyov@omp.ru> wrote: > On 4/23/22 12:09 PM, Sergey Shtylyov wrote: > > [...] > >> Define the r9a06g032 generic part of the USB PHY device node. > >> > >> Signed-off-by: Herve Codina <herve.codina@bootlin.com> > >> --- > >> arch/arm/boot/dts/r9a06g032.dtsi | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi > >> index 33581f0c55c4..58af07eb75c9 100644 > >> --- a/arch/arm/boot/dts/r9a06g032.dtsi > >> +++ b/arch/arm/boot/dts/r9a06g032.dtsi > >> @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk { > >> clock-frequency = <0>; > >> }; > >> > >> + usbphy: usbphy { > > > > I think the node name should be "usb-phy"... > > It's not my thinking alone, the DT spec documents "usb-phy" in section 2.2.2. :-) Will be changed in v4. Thanks for pointing this. Regards, Hervé
Hi Hervé, On Fri, Apr 22, 2022 at 2:09 PM Herve Codina <herve.codina@bootlin.com> wrote: > Define the r9a06g032 generic part of the USB PHY device node. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> Thanks for your patch! > --- a/arch/arm/boot/dts/r9a06g032.dtsi > +++ b/arch/arm/boot/dts/r9a06g032.dtsi > @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk { > clock-frequency = <0>; > }; > > + usbphy: usbphy { Please preserve sort order (by node name). > + #phy-cells = <0>; > + compatible = "usb-nop-xceiv"; > + status = "disabled"; > + }; > + > soc { > compatible = "simple-bus"; > #address-cells = <1>; The rest LGTM, so with the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On Thu, 28 Apr 2022 11:51:44 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Hervé, > > On Fri, Apr 22, 2022 at 2:09 PM Herve Codina <herve.codina@bootlin.com> wrote: > > Define the r9a06g032 generic part of the USB PHY device node. > > > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > > Thanks for your patch! > > > --- a/arch/arm/boot/dts/r9a06g032.dtsi > > +++ b/arch/arm/boot/dts/r9a06g032.dtsi > > @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk { > > clock-frequency = <0>; > > }; > > > > + usbphy: usbphy { > > Please preserve sort order (by node name). Ok, will be done. > > > + #phy-cells = <0>; > > + compatible = "usb-nop-xceiv"; > > + status = "disabled"; > > + }; > > + > > soc { > > compatible = "simple-bus"; > > #address-cells = <1>; > > The rest LGTM, so with the above fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Regards, Hervé
diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi index 33581f0c55c4..58af07eb75c9 100644 --- a/arch/arm/boot/dts/r9a06g032.dtsi +++ b/arch/arm/boot/dts/r9a06g032.dtsi @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk { clock-frequency = <0>; }; + usbphy: usbphy { + #phy-cells = <0>; + compatible = "usb-nop-xceiv"; + status = "disabled"; + }; + soc { compatible = "simple-bus"; #address-cells = <1>;
Define the r9a06g032 generic part of the USB PHY device node. Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- arch/arm/boot/dts/r9a06g032.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)