diff mbox series

irqdomain: Export __irq_domain_alloc_irqs() to modules

Message ID 20211004150552.3844830-1-maz@kernel.org
State New
Headers show
Series irqdomain: Export __irq_domain_alloc_irqs() to modules | expand

Commit Message

Marc Zyngier Oct. 4, 2021, 3:05 p.m. UTC
The Apple PCIe controller driver allocates interrupts generated
by the PCIe ports, and uses irq_domain_alloc_irqs() for that.
THis is an inline function that uses __irq_domain_alloc_irqs()
as a backend.

Since the driver can be built as a module, __irq_domain_alloc_irqs()
must be exported.

Fixes: 201adeaa9d82 ("PCI: apple: Add INTx and per-port interrupt support")
Signed-off-by: Marc Zyngier <maz@kernel.org>
---

Notes:
    Since the offending code is only in the PCI tree so far,
    it would make sense if Lorenzo could take this patch directly.

 kernel/irq/irqdomain.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Lorenzo Pieralisi Oct. 4, 2021, 3:59 p.m. UTC | #1
On Mon, Oct 04, 2021 at 04:05:52PM +0100, Marc Zyngier wrote:
> The Apple PCIe controller driver allocates interrupts generated
> by the PCIe ports, and uses irq_domain_alloc_irqs() for that.
> THis is an inline function that uses __irq_domain_alloc_irqs()
> as a backend.
> 
> Since the driver can be built as a module, __irq_domain_alloc_irqs()
> must be exported.
> 
> Fixes: 201adeaa9d82 ("PCI: apple: Add INTx and per-port interrupt support")

I have squashed this patch into the commit it is fixing and pushed
pci/apple out.

I could have merged it as a standalone patch before the commit it is
fixing but it would not make sense on its own I believe, happy to
rectify the branch in case that's preferred.

Lorenzo

> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> 
> Notes:
>     Since the offending code is only in the PCI tree so far,
>     it would make sense if Lorenzo could take this patch directly.
> 
>  kernel/irq/irqdomain.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 5a698c1f6cc6..40e85a46f913 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -1502,6 +1502,7 @@ int __irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base,
>  	irq_free_descs(virq, nr_irqs);
>  	return ret;
>  }
> +EXPORT_SYMBOL_GPL(__irq_domain_alloc_irqs);
>  
>  /* The irq_data was moved, fix the revmap to refer to the new location */
>  static void irq_domain_fix_revmap(struct irq_data *d)
> -- 
> 2.30.2
>
Marc Zyngier Oct. 4, 2021, 4:07 p.m. UTC | #2
On Mon, 04 Oct 2021 16:59:15 +0100,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote:
> 
> On Mon, Oct 04, 2021 at 04:05:52PM +0100, Marc Zyngier wrote:
> > The Apple PCIe controller driver allocates interrupts generated
> > by the PCIe ports, and uses irq_domain_alloc_irqs() for that.
> > THis is an inline function that uses __irq_domain_alloc_irqs()
> > as a backend.
> > 
> > Since the driver can be built as a module, __irq_domain_alloc_irqs()
> > must be exported.
> > 
> > Fixes: 201adeaa9d82 ("PCI: apple: Add INTx and per-port interrupt support")
> 
> I have squashed this patch into the commit it is fixing and pushed
> pci/apple out.
> 
> I could have merged it as a standalone patch before the commit it is
> fixing but it would not make sense on its own I believe, happy to
> rectify the branch in case that's preferred.

The final patch has links to both patches on the list, so that's
absolutely fine by me.

Thanks,

	M.
diff mbox series

Patch

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 5a698c1f6cc6..40e85a46f913 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -1502,6 +1502,7 @@  int __irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base,
 	irq_free_descs(virq, nr_irqs);
 	return ret;
 }
+EXPORT_SYMBOL_GPL(__irq_domain_alloc_irqs);
 
 /* The irq_data was moved, fix the revmap to refer to the new location */
 static void irq_domain_fix_revmap(struct irq_data *d)