@@ -291,6 +291,7 @@ struct pci_bus *pci_bus_get(struct pci_bus *bus);
void pci_bus_put(struct pci_bus *bus);
bool pci_dev_bar_movable(struct pci_dev *dev, struct resource *res);
+void pci_bus_update_realloc_range(struct pci_bus *bus);
/* PCIe link information */
#define PCIE_SPEED2STR(speed) \
@@ -1837,6 +1837,91 @@ static enum enable_type pci_realloc_detect(struct pci_bus *bus,
}
#endif
+/*
+ * Calculate the address margins where the bridge windows may be allocated to fit all
+ * the fixed and immovable BARs beneath.
+ */
+void pci_bus_update_realloc_range(struct pci_bus *bus)
+{
+ struct pci_dev *dev;
+ struct pci_bus *parent = bus->parent;
+ int idx;
+
+ list_for_each_entry(dev, &bus->devices, bus_list)
+ if (dev->subordinate)
+ pci_bus_update_realloc_range(dev->subordinate);
+
+ if (!parent || !bus->self)
+ return;
+
+ for (idx = 0; idx < PCI_BRIDGE_RESOURCE_NUM; ++idx) {
+ struct resource *immovable_range = &bus->immovable_range[idx];
+ resource_size_t window_size = resource_size(bus->resource[idx]);
+ resource_size_t realloc_start, realloc_end;
+
+ bus->realloc_range[idx].start = 0;
+ bus->realloc_range[idx].end = 0;
+
+ /* Check if there any immovable BARs under the bridge */
+ if (immovable_range->start >= immovable_range->end)
+ continue;
+
+ /* The lowest possible address where the bridge window can start */
+ realloc_start = immovable_range->end - window_size + 1;
+ /* The highest possible address where the bridge window can end */
+ realloc_end = immovable_range->start + window_size - 1;
+
+ if (realloc_start > immovable_range->start)
+ realloc_start = immovable_range->start;
+
+ if (realloc_end < immovable_range->end)
+ realloc_end = immovable_range->end;
+
+ /*
+ * Check that realloc range doesn't intersect with hard fixed ranges
+ * of neighboring bridges
+ */
+ list_for_each_entry(dev, &parent->devices, bus_list) {
+ struct pci_bus *neighbor = dev->subordinate;
+ struct resource *n_imm_range;
+
+ if (!neighbor) {
+ int i;
+
+ for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; ++i) {
+ struct resource *nr = &dev->resource[i];
+
+ if (!nr->flags ||
+ !nr->start ||
+ pci_dev_bar_movable(dev, nr))
+ continue;
+
+ if (nr->end < immovable_range->start &&
+ nr->end > realloc_start)
+ realloc_start = nr->end;
+ }
+
+ continue;
+ }
+
+ if (neighbor == bus)
+ continue;
+
+ n_imm_range = &neighbor->immovable_range[idx];
+
+ if (n_imm_range->start >= n_imm_range->end)
+ continue;
+
+ if (n_imm_range->end < immovable_range->start &&
+ n_imm_range->end > realloc_start)
+ realloc_start = n_imm_range->end;
+ }
+
+ bus->realloc_range[idx].start = realloc_start;
+ bus->realloc_range[idx].end = realloc_end;
+ }
+}
+
/*
* First try will not touch PCI bridge res.
* Second and later try will clear small leaf bridge res.
@@ -1856,6 +1941,7 @@ void pci_assign_unassigned_root_bus_resources(struct pci_bus *bus)
if (pci_can_move_bars) {
__pci_bus_size_bridges(bus, NULL);
+ pci_bus_update_realloc_range(bus);
__pci_bus_assign_resources(bus, NULL, NULL);
goto dump;
@@ -588,6 +588,12 @@ struct pci_bus {
*/
struct resource immovable_range[PCI_BRIDGE_RESOURCE_NUM];
+ /*
+ * Acceptable address range, where the bridge window may reside, considering its
+ * size, so it will cover all the fixed and immovable BARs below.
+ */
+ struct resource realloc_range[PCI_BRIDGE_RESOURCE_NUM];
+
struct pci_ops *ops; /* Configuration access functions */
struct msi_controller *msi; /* MSI controller */
void *sysdata; /* Hook for sys-specific extension */
With enabled movable BARs, bridge windows are recalculated during each PCI rescan. Some of the BARs below a bridge may be immovable: these areas are represented by the .immovable_range field in struct pci_bus. If a bridge window size is equal to its immovable range, it can only be assigned to the start of this range. But if a bridge window size is larger, and this difference in size is denoted as "delta", the window can start from (immovable_range.start - delta) to (immovable_range.start), and it can end from (immovable_range.end) to (immovable_range.end + delta). This range (the new .realloc_range field in struct pci_bus) must then be compared with immovable ranges of neighbouring bridges to guarantee absence of intersections. This patch only calculates valid ranges for reallocated bridges during pci rescan, and the next one will make use of these values during allocation. Signed-off-by: Sergei Miroshnichenko <s.miroshnichenko@yadro.com> --- drivers/pci/pci.h | 1 + drivers/pci/setup-bus.c | 86 +++++++++++++++++++++++++++++++++++++++++ include/linux/pci.h | 6 +++ 3 files changed, 93 insertions(+)