| Message ID | 1527654876-26716-1-git-send-email-okaya@codeaurora.org |
|---|---|
| State | Superseded |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI: move early dump functionality from x86 arch into the common code | expand |
On 5/29/2018 9:34 PM, Sinan Kaya wrote: > -int early_pci_allowed(void) > -{ > - return (pci_probe & (PCI_PROBE_CONF1|PCI_PROBE_NOEARLY)) == > - PCI_PROBE_CONF1; > -} I should have kept this. I'll wait for more feedback before posting the next rev.
On 5/30/2018 12:34 AM, Sinan Kaya wrote: > Move early dump functionality into common code so that it is available for > all archtiectures. No need to carry arch specific reads around as the read > hooks are already initialized by the time pci_setup_device() is getting > called during scan. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > --- > Documentation/admin-guide/kernel-parameters.txt | 2 +- > arch/x86/include/asm/pci-direct.h | 5 --- > arch/x86/kernel/setup.c | 5 --- > arch/x86/pci/common.c | 4 -- > arch/x86/pci/early.c | 50 ------------------------- > drivers/pci/pci.c | 4 ++ > drivers/pci/pci.h | 2 +- > drivers/pci/probe.c | 19 ++++++++++ > 8 files changed, 25 insertions(+), 66 deletions(-) Any feedback on the direction?
On Wed, May 30, 2018 at 7:34 AM, Sinan Kaya <okaya@codeaurora.org> wrote: > Move early dump functionality into common code so that it is available for > all archtiectures. No need to carry arch specific reads around as the read > hooks are already initialized by the time pci_setup_device() is getting > called during scan. > /* If set, the PCIe ATS capability will not be used. */ > static bool pcie_ats_disabled; > > +bool pci_early_dump; > + I didn't check above these, but maybe a good idea to add one line comment what is this about? > extern const unsigned char pcie_link_speed[]; > - > +extern bool pci_early_dump; > bool pcie_cap_has_lnkctl(const struct pci_dev *dev); > Hmm... I would rather not attach this line to some function declarations. > +static void early_dump_pci_device(struct pci_dev *pdev) > +{ > + u32 value[256 / 4]; > + int i; > + > + dev_info(&pdev->dev, "pci 0000:%02x:%02x.%d config space:\n", > + pdev->bus->number, PCI_SLOT(pdev->devfn), > + PCI_FUNC(pdev->devfn)); Shouldn't be this changed to pci_info() ? > + > + for (i = 0; i < 256; i += 4) > + pci_read_config_dword(pdev, i, &value[i / 4]); > + > + print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET, 16, 1, value, > + 256, false); > +}
On 6/1/2018 11:02 AM, Andy Shevchenko wrote: > On Wed, May 30, 2018 at 7:34 AM, Sinan Kaya <okaya@codeaurora.org> wrote: >> Move early dump functionality into common code so that it is available for >> all archtiectures. No need to carry arch specific reads around as the read >> hooks are already initialized by the time pci_setup_device() is getting >> called during scan. > >> /* If set, the PCIe ATS capability will not be used. */ >> static bool pcie_ats_disabled; >> >> +bool pci_early_dump; >> + > > I didn't check above these, but maybe a good idea to add one line > comment what is this about? This was discussed here: https://www.spinics.net/lists/linux-pci/msg72859.html > > >> extern const unsigned char pcie_link_speed[]; >> - >> +extern bool pci_early_dump; >> bool pcie_cap_has_lnkctl(const struct pci_dev *dev); >> > > Hmm... I would rather not attach this line to some function declarations. Sure > >> +static void early_dump_pci_device(struct pci_dev *pdev) >> +{ >> + u32 value[256 / 4]; >> + int i; >> + >> + dev_info(&pdev->dev, "pci 0000:%02x:%02x.%d config space:\n", >> + pdev->bus->number, PCI_SLOT(pdev->devfn), >> + PCI_FUNC(pdev->devfn)); > > Shouldn't be this changed to pci_info() ? Yeah, I need to get used to pci_info(). > >> + >> + for (i = 0; i < 256; i += 4) >> + pci_read_config_dword(pdev, i, &value[i / 4]); >> + >> + print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET, 16, 1, value, >> + 256, false); >> +} >
On Fri, Jun 1, 2018 at 6:06 PM, Sinan Kaya <okaya@codeaurora.org> wrote: > On 6/1/2018 11:02 AM, Andy Shevchenko wrote: >> On Wed, May 30, 2018 at 7:34 AM, Sinan Kaya <okaya@codeaurora.org> wrote: >>> Move early dump functionality into common code so that it is available for >>> all archtiectures. No need to carry arch specific reads around as the read >>> hooks are already initialized by the time pci_setup_device() is getting >>> called during scan. >> >>> /* If set, the PCIe ATS capability will not be used. */ >>> static bool pcie_ats_disabled; >>> >>> +bool pci_early_dump; >>> + >> >> I didn't check above these, but maybe a good idea to add one line >> comment what is this about? > > This was discussed here: > > https://www.spinics.net/lists/linux-pci/msg72859.html I understand what is it. What I'm pointing is the variable in the source without any comment. In the context you have in diff previous one has a comment.
On 6/1/2018 11:24 AM, Andy Shevchenko wrote: >> This was discussed here: >> >> https://www.spinics.net/lists/linux-pci/msg72859.html > I understand what is it. What I'm pointing is the variable in the > source without any comment. In the context you have in diff previous > one has a comment. oh, ok. I can take care of that too.
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index c247612..4459270 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -2986,7 +2986,7 @@ See also Documentation/blockdev/paride.txt. pci=option[,option...] [PCI] various PCI subsystem options: - earlydump [X86] dump PCI config space before the kernel + earlydump dump PCI config space before the kernel changes anything off [X86] don't probe for the PCI bus bios [X86-32] force use of PCI BIOS, don't access diff --git a/arch/x86/include/asm/pci-direct.h b/arch/x86/include/asm/pci-direct.h index e1084f7..e5e2129 100644 --- a/arch/x86/include/asm/pci-direct.h +++ b/arch/x86/include/asm/pci-direct.h @@ -14,9 +14,4 @@ extern void write_pci_config(u8 bus, u8 slot, u8 func, u8 offset, u32 val); extern void write_pci_config_byte(u8 bus, u8 slot, u8 func, u8 offset, u8 val); extern void write_pci_config_16(u8 bus, u8 slot, u8 func, u8 offset, u16 val); -extern int early_pci_allowed(void); - -extern unsigned int pci_early_dump_regs; -extern void early_dump_pci_device(u8 bus, u8 slot, u8 func); -extern void early_dump_pci_devices(void); #endif /* _ASM_X86_PCI_DIRECT_H */ diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 2f86d88..480f250 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -991,11 +991,6 @@ void __init setup_arch(char **cmdline_p) setup_clear_cpu_cap(X86_FEATURE_APIC); } -#ifdef CONFIG_PCI - if (pci_early_dump_regs) - early_dump_pci_devices(); -#endif - e820__reserve_setup_data(); e820__finish_early_params(); diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 563049c..d4ec117 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86/pci/common.c @@ -22,7 +22,6 @@ unsigned int pci_probe = PCI_PROBE_BIOS | PCI_PROBE_CONF1 | PCI_PROBE_CONF2 | PCI_PROBE_MMCONF; -unsigned int pci_early_dump_regs; static int pci_bf_sort; int pci_routeirq; int noioapicquirk; @@ -599,9 +598,6 @@ char *__init pcibios_setup(char *str) pci_probe |= PCI_BIG_ROOT_WINDOW; return NULL; #endif - } else if (!strcmp(str, "earlydump")) { - pci_early_dump_regs = 1; - return NULL; } else if (!strcmp(str, "routeirq")) { pci_routeirq = 1; return NULL; diff --git a/arch/x86/pci/early.c b/arch/x86/pci/early.c index e5f753c..e20d449 100644 --- a/arch/x86/pci/early.c +++ b/arch/x86/pci/early.c @@ -51,53 +51,3 @@ void write_pci_config_16(u8 bus, u8 slot, u8 func, u8 offset, u16 val) outw(val, 0xcfc + (offset&2)); } -int early_pci_allowed(void) -{ - return (pci_probe & (PCI_PROBE_CONF1|PCI_PROBE_NOEARLY)) == - PCI_PROBE_CONF1; -} - -void early_dump_pci_device(u8 bus, u8 slot, u8 func) -{ - u32 value[256 / 4]; - int i; - - pr_info("pci 0000:%02x:%02x.%d config space:\n", bus, slot, func); - - for (i = 0; i < 256; i += 4) - value[i / 4] = read_pci_config(bus, slot, func, i); - - print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET, 16, 1, value, 256, false); -} - -void early_dump_pci_devices(void) -{ - unsigned bus, slot, func; - - if (!early_pci_allowed()) - return; - - for (bus = 0; bus < 256; bus++) { - for (slot = 0; slot < 32; slot++) { - for (func = 0; func < 8; func++) { - u32 class; - u8 type; - - class = read_pci_config(bus, slot, func, - PCI_CLASS_REVISION); - if (class == 0xffffffff) - continue; - - early_dump_pci_device(bus, slot, func); - - if (func == 0) { - type = read_pci_config_byte(bus, slot, - func, - PCI_HEADER_TYPE); - if (!(type & 0x80)) - break; - } - } - } - } -} diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 7c03701..ae5a2ae 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -115,6 +115,8 @@ static bool pcie_ari_disabled; /* If set, the PCIe ATS capability will not be used. */ static bool pcie_ats_disabled; +bool pci_early_dump; + bool pci_ats_disabled(void) { return pcie_ats_disabled; @@ -5848,6 +5850,8 @@ static int __init pci_setup(char *str) pcie_ats_disabled = true; } else if (!strcmp(str, "noaer")) { pci_no_aer(); + } else if (!strcmp(str, "earlydump")) { + pci_early_dump = true; } else if (!strncmp(str, "realloc=", 8)) { pci_realloc_get_opt(str + 8); } else if (!strncmp(str, "realloc", 7)) { diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index c358e7a0..9c66b7d 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -7,7 +7,7 @@ #define PCI_VSEC_ID_INTEL_TBT 0x1234 /* Thunderbolt */ extern const unsigned char pcie_link_speed[]; - +extern bool pci_early_dump; bool pcie_cap_has_lnkctl(const struct pci_dev *dev); /* Functions internal to the PCI core code */ diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 3840207..b1f068d 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1549,6 +1549,22 @@ static int pci_intx_mask_broken(struct pci_dev *dev) return 0; } +static void early_dump_pci_device(struct pci_dev *pdev) +{ + u32 value[256 / 4]; + int i; + + dev_info(&pdev->dev, "pci 0000:%02x:%02x.%d config space:\n", + pdev->bus->number, PCI_SLOT(pdev->devfn), + PCI_FUNC(pdev->devfn)); + + for (i = 0; i < 256; i += 4) + pci_read_config_dword(pdev, i, &value[i / 4]); + + print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET, 16, 1, value, + 256, false); +} + /** * pci_setup_device - Fill in class and map information of a device * @dev: the device structure to fill @@ -1598,6 +1614,9 @@ int pci_setup_device(struct pci_dev *dev) pci_printk(KERN_DEBUG, dev, "[%04x:%04x] type %02x class %#08x\n", dev->vendor, dev->device, dev->hdr_type, dev->class); + if (pci_early_dump) + early_dump_pci_device(dev); + /* Need to have dev->class ready */ dev->cfg_size = pci_cfg_space_size(dev);
Move early dump functionality into common code so that it is available for all archtiectures. No need to carry arch specific reads around as the read hooks are already initialized by the time pci_setup_device() is getting called during scan. Signed-off-by: Sinan Kaya <okaya@codeaurora.org> --- Documentation/admin-guide/kernel-parameters.txt | 2 +- arch/x86/include/asm/pci-direct.h | 5 --- arch/x86/kernel/setup.c | 5 --- arch/x86/pci/common.c | 4 -- arch/x86/pci/early.c | 50 ------------------------- drivers/pci/pci.c | 4 ++ drivers/pci/pci.h | 2 +- drivers/pci/probe.c | 19 ++++++++++ 8 files changed, 25 insertions(+), 66 deletions(-)