Message ID | 1475861189-10794-1-git-send-email-jonathan.derrick@intel.com |
---|---|
State | Changes Requested |
Headers | show |
On Fri, Oct 07, 2016 at 11:26:28AM -0600, Jon Derrick wrote: > Instead of relying on the domain being >= 0x10000, use the member of the > pci sysdata that identifies a VMD root port bus. 'is_vmd' is only defined for x86. You'll need a '#define is_vmd' to false in some arch generic place. > --- > drivers/pci/quirks.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index edc7f96..713035f 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -4438,8 +4438,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x443, quirk_intel_qat_vf_cap); > */ > static void quirk_no_aersid(struct pci_dev *pdev) > { > - /* VMD Domain */ > - if (pdev->bus->sysdata && pci_domain_nr(pdev->bus) >= 0x10000) > + if (is_vmd(pdev->bus)) > pdev->bus->bus_flags |= PCI_BUS_FLAGS_NO_AERSID; > } > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2030, quirk_no_aersid); -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Oct 07, 2016 at 01:45:49PM -0400, Keith Busch wrote: > On Fri, Oct 07, 2016 at 11:26:28AM -0600, Jon Derrick wrote: > > Instead of relying on the domain being >= 0x10000, use the member of the > > pci sysdata that identifies a VMD root port bus. > > 'is_vmd' is only defined for x86. You'll need a '#define is_vmd' to > false in some arch generic place. Drats. Good catch. That's not as clean as I hoped it would be. > > > > --- > > drivers/pci/quirks.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > > index edc7f96..713035f 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -4438,8 +4438,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x443, quirk_intel_qat_vf_cap); > > */ > > static void quirk_no_aersid(struct pci_dev *pdev) > > { > > - /* VMD Domain */ > > - if (pdev->bus->sysdata && pci_domain_nr(pdev->bus) >= 0x10000) > > + if (is_vmd(pdev->bus)) > > pdev->bus->bus_flags |= PCI_BUS_FLAGS_NO_AERSID; > > } > > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2030, quirk_no_aersid); > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index edc7f96..713035f 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4438,8 +4438,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x443, quirk_intel_qat_vf_cap); */ static void quirk_no_aersid(struct pci_dev *pdev) { - /* VMD Domain */ - if (pdev->bus->sysdata && pci_domain_nr(pdev->bus) >= 0x10000) + if (is_vmd(pdev->bus)) pdev->bus->bus_flags |= PCI_BUS_FLAGS_NO_AERSID; } DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2030, quirk_no_aersid);