| Message ID | 1472455618-17892-1-git-send-email-po.liu@nxp.com |
|---|---|
| State | Accepted |
| Headers | show |
On Monday, August 29, 2016 3:27 AM, Po Liu wrote: > > When echo a number to /sys/bus/pci/devices/xxx/sriov_numvfs to enable the > VF devices. A crash log occurred. This found to be access the IOV devices > config space failure issue. > > The read/write config space from host would judge the pcie device plugin > or not by(Designware platform as example): > > if (bus->primary == pp->root_bus_nr && dev > 0) > return 0; > > Although all PCIe devices for dev(coming from the device and function > number) is zero. But the dev is not zero for VF devices. So remove the > condition. > > These PCI hosts were changed: designware, altera, xilinx. > > Signed-off-by: Po Liu <po.liu@nxp.com> For 'pcie-designware.c', Acked-by: Jingoo Han <jingoohan1@gmail.com> I really don't like to modify host driver stuffs. But, if there is no alternatives, this patch looks good. Best regards, Jingoo Han > --- > changes for v2: > - add pci hosts: altera, xilinx; > > drivers/pci/host/pcie-altera.c | 7 ------- > drivers/pci/host/pcie-designware.c | 7 ------- > drivers/pci/host/pcie-xilinx.c | 7 ------- > 3 files changed, 21 deletions(-) > > diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie- > altera.c index 2b78376..edbe0a7 100644 > --- a/drivers/pci/host/pcie-altera.c > +++ b/drivers/pci/host/pcie-altera.c > @@ -171,13 +171,6 @@ static bool altera_pcie_valid_config(struct > altera_pcie *pcie, > if (bus->number == pcie->root_bus_nr && dev > 0) > return false; > > - /* > - * Do not read more than one device on the bus directly attached > - * to root port, root port can only attach to one downstream port. > - */ > - if (bus->primary == pcie->root_bus_nr && dev > 0) > - return false; > - > return true; > } > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie- > designware.c > index 12afce1..dd20eb2 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -670,13 +670,6 @@ static int dw_pcie_valid_config(struct pcie_port *pp, > if (bus->number == pp->root_bus_nr && dev > 0) > return 0; > > - /* > - * do not read more than one device on the bus directly attached > - * to RC's (Virtual Bridge's) DS side. > - */ > - if (bus->primary == pp->root_bus_nr && dev > 0) > - return 0; > - > return 1; > } > > diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie- > xilinx.c index a30e016..75c89db 100644 > --- a/drivers/pci/host/pcie-xilinx.c > +++ b/drivers/pci/host/pcie-xilinx.c > @@ -168,13 +168,6 @@ static bool xilinx_pcie_valid_device(struct pci_bus > *bus, unsigned int devfn) > if (bus->number == port->root_busno && devfn > 0) > return false; > > - /* > - * Do not read more than one device on the bus directly attached > - * to RC. > - */ > - if (bus->primary == port->root_busno && devfn > 0) > - return false; > - > return true; > } > > -- > 2.1.0.27.g96db324 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/30/2016 10:43 AM, Jingoo Han wrote: > I really don't like to modify host driver stuffs. > But, if there is no alternatives, this patch looks good. I do not see other good place to fix the bug. Roy Zang <roy.zang@nxp.com> Roy -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Acked-by: Roy Zang <roy.zang@nxp.com> Roy On 08/30/2016 10:54 AM, Roy Zang wrote: > On 08/30/2016 10:43 AM, Jingoo Han wrote: >> I really don't like to modify host driver stuffs. >> But, if there is no alternatives, this patch looks good. > I do not see other good place to fix the bug. > > Roy Zang <roy.zang@nxp.com> > > Roy > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, August 30, 2016 11:55 AM, Roy Zang wrote: > > On 08/30/2016 10:43 AM, Jingoo Han wrote: > > I really don't like to modify host driver stuffs. > > But, if there is no alternatives, this patch looks good. > > I do not see other good place to fix the bug. Hi Roy Zang, I didn't find other good place, too. At that time, I did IOV test with the similar patch like this. Best regards, Jingoo Han > > Roy Zang <roy.zang@nxp.com> > > Roy -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/30/2016 01:15 PM, Jingoo Han wrote: > On Tuesday, August 30, 2016 11:55 AM, Roy Zang wrote: >> > >> > On 08/30/2016 10:43 AM, Jingoo Han wrote: >>> > > I really don't like to modify host driver stuffs. >>> > > But, if there is no alternatives, this patch looks good. >> > >> > I do not see other good place to fix the bug. > Hi Roy Zang, > > I didn't find other good place, too. > At that time, I did IOV test with the similar patch like this. > > Best regards, > Jingoo Han > I did the similar with SR-IOV capability card. the patch fix the issue. Thanks for your confirmation and ack. Roy -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 29, 2016 at 3:26 PM, Po Liu <po.liu@nxp.com> wrote: > When echo a number to /sys/bus/pci/devices/xxx/sriov_numvfs to enable the > VF devices. A crash log occurred. This found to be access the IOV devices > config space failure issue. > > The read/write config space from host would judge the pcie device plugin > or not by(Designware platform as example): > > if (bus->primary == pp->root_bus_nr && dev > 0) > return 0; > > Although all PCIe devices for dev(coming from the device and function > number) is zero. But the dev is not zero for VF devices. So remove the > condition. > > These PCI hosts were changed: designware, altera, xilinx. > > Signed-off-by: Po Liu <po.liu@nxp.com> > --- For pcie-altera.c: Acked-by: Ley Foon Tan <lftan@altera.com> Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 29, 2016 at 03:26:58PM +0800, Po Liu wrote: > When echo a number to /sys/bus/pci/devices/xxx/sriov_numvfs to enable the > VF devices. A crash log occurred. This found to be access the IOV devices > config space failure issue. > > The read/write config space from host would judge the pcie device plugin > or not by(Designware platform as example): > > if (bus->primary == pp->root_bus_nr && dev > 0) > return 0; > > Although all PCIe devices for dev(coming from the device and function > number) is zero. But the dev is not zero for VF devices. So remove the > condition. > > These PCI hosts were changed: designware, altera, xilinx. > > Signed-off-by: Po Liu <po.liu@nxp.com> Applied to pci/virtualization for v4.9, thanks! I split it into three patches for backporting and reversion purposes. > --- > changes for v2: > - add pci hosts: altera, xilinx; > > drivers/pci/host/pcie-altera.c | 7 ------- > drivers/pci/host/pcie-designware.c | 7 ------- > drivers/pci/host/pcie-xilinx.c | 7 ------- > 3 files changed, 21 deletions(-) > > diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c > index 2b78376..edbe0a7 100644 > --- a/drivers/pci/host/pcie-altera.c > +++ b/drivers/pci/host/pcie-altera.c > @@ -171,13 +171,6 @@ static bool altera_pcie_valid_config(struct altera_pcie *pcie, > if (bus->number == pcie->root_bus_nr && dev > 0) > return false; > > - /* > - * Do not read more than one device on the bus directly attached > - * to root port, root port can only attach to one downstream port. > - */ > - if (bus->primary == pcie->root_bus_nr && dev > 0) > - return false; > - > return true; > } > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 12afce1..dd20eb2 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -670,13 +670,6 @@ static int dw_pcie_valid_config(struct pcie_port *pp, > if (bus->number == pp->root_bus_nr && dev > 0) > return 0; > > - /* > - * do not read more than one device on the bus directly attached > - * to RC's (Virtual Bridge's) DS side. > - */ > - if (bus->primary == pp->root_bus_nr && dev > 0) > - return 0; > - > return 1; > } > > diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c > index a30e016..75c89db 100644 > --- a/drivers/pci/host/pcie-xilinx.c > +++ b/drivers/pci/host/pcie-xilinx.c > @@ -168,13 +168,6 @@ static bool xilinx_pcie_valid_device(struct pci_bus *bus, unsigned int devfn) > if (bus->number == port->root_busno && devfn > 0) > return false; > > - /* > - * Do not read more than one device on the bus directly attached > - * to RC. > - */ > - if (bus->primary == port->root_busno && devfn > 0) > - return false; > - > return true; > } > > -- > 2.1.0.27.g96db324 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c index 2b78376..edbe0a7 100644 --- a/drivers/pci/host/pcie-altera.c +++ b/drivers/pci/host/pcie-altera.c @@ -171,13 +171,6 @@ static bool altera_pcie_valid_config(struct altera_pcie *pcie, if (bus->number == pcie->root_bus_nr && dev > 0) return false; - /* - * Do not read more than one device on the bus directly attached - * to root port, root port can only attach to one downstream port. - */ - if (bus->primary == pcie->root_bus_nr && dev > 0) - return false; - return true; } diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 12afce1..dd20eb2 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -670,13 +670,6 @@ static int dw_pcie_valid_config(struct pcie_port *pp, if (bus->number == pp->root_bus_nr && dev > 0) return 0; - /* - * do not read more than one device on the bus directly attached - * to RC's (Virtual Bridge's) DS side. - */ - if (bus->primary == pp->root_bus_nr && dev > 0) - return 0; - return 1; } diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c index a30e016..75c89db 100644 --- a/drivers/pci/host/pcie-xilinx.c +++ b/drivers/pci/host/pcie-xilinx.c @@ -168,13 +168,6 @@ static bool xilinx_pcie_valid_device(struct pci_bus *bus, unsigned int devfn) if (bus->number == port->root_busno && devfn > 0) return false; - /* - * Do not read more than one device on the bus directly attached - * to RC. - */ - if (bus->primary == port->root_busno && devfn > 0) - return false; - return true; }
When echo a number to /sys/bus/pci/devices/xxx/sriov_numvfs to enable the VF devices. A crash log occurred. This found to be access the IOV devices config space failure issue. The read/write config space from host would judge the pcie device plugin or not by(Designware platform as example): if (bus->primary == pp->root_bus_nr && dev > 0) return 0; Although all PCIe devices for dev(coming from the device and function number) is zero. But the dev is not zero for VF devices. So remove the condition. These PCI hosts were changed: designware, altera, xilinx. Signed-off-by: Po Liu <po.liu@nxp.com> --- changes for v2: - add pci hosts: altera, xilinx; drivers/pci/host/pcie-altera.c | 7 ------- drivers/pci/host/pcie-designware.c | 7 ------- drivers/pci/host/pcie-xilinx.c | 7 ------- 3 files changed, 21 deletions(-)