From patchwork Thu Jul 28 16:17:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 653814 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s0cSx2Czxz9t0d for ; Fri, 29 Jul 2016 02:17:21 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=uPl8m38c; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759071AbcG1QRU (ORCPT ); Thu, 28 Jul 2016 12:17:20 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33232 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758920AbcG1QRT (ORCPT ); Thu, 28 Jul 2016 12:17:19 -0400 Received: by mail-pf0-f195.google.com with SMTP id i6so3956697pfe.0 for ; Thu, 28 Jul 2016 09:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LHhZ1EKCH6CsckspltcjRN1Qc7rHzHC/ZWzgfZWL1cc=; b=uPl8m38cswhVplZM8/wb9SeWysnj9orM1+9dCvKD+HuDPve/TS9ZIEIHgMsvMJqHa+ PFkUl11S2sdQ2Ysidau5Rx7qtoyMmY25kTAXiv3pUqi6DWimha154izMiXygQ5rsnH37 sPija1Wl4dIemNWzvLRt3FXRT4P2lkY6mfYGHb0P/npjI08m64paIBLtULvRknDl4sG+ xrnXNATQd6kIgTSB4wcfQUh0DOciZnYg60VyCoP/NGK0BQX62Ebh+EdZhLWeamVIKXJb hVwIaNtpHKwYQFydpkiM8kVb2pPPdNAIgRcaooqftuxb7OnI28vOKie8Z8FPeoFAPaKC RcPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LHhZ1EKCH6CsckspltcjRN1Qc7rHzHC/ZWzgfZWL1cc=; b=AICOevEmVSKpp5d4rE84qfWgdiBbkuF1BINqomtWHeyNfF/L8pWwuqXxIrpfLIilMR kbCRI5I3luFojn1mkZA8sye5AG1Bbcha0WvgOvLqDsRNLOMDQLmBk597/gHXXOtAlW+j sfXIjkgMmj1F6d+ET38o6DqiIL7gaK/LXUWu1jfqryAdgm1HJxCDROvx2UiO4aSsnLgt Jw/EbYVHtq4gBZXRFVSziVNUtiVxixqSFMJeJly5YBvxi3dh3iTl3IOW3MlCaNX9zfxJ p9i5e4XbQhB7Kt0Jj0CE046d06Vr7Fpt17VA9UKG5aLagKKUZKsbWD9cOMMFsadYVCAD dztA== X-Gm-Message-State: AEkoouvL9Ptw7TqBLEsIei0u6uWU9HEFZAJm29EdkivF+QFfjzURiQbPVtJHV0/+GjmkMQ== X-Received: by 10.98.91.197 with SMTP id p188mr60709143pfb.101.1469722639282; Thu, 28 Jul 2016 09:17:19 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id v124sm18356333pfb.14.2016.07.28.09.17.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jul 2016 09:17:18 -0700 (PDT) From: Wei Yongjun To: Thomas Petazzoni , Bjorn Helgaas Cc: Wei Yongjun , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH -next] PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe() Date: Thu, 28 Jul 2016 16:17:14 +0000 Message-Id: <1469722634-15049-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Reviewed-by: Thomas Petazzoni --- drivers/pci/host/pci-aardvark.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c index ef9893f..05c33b5 100644 --- a/drivers/pci/host/pci-aardvark.c +++ b/drivers/pci/host/pci-aardvark.c @@ -925,10 +925,8 @@ static int advk_pcie_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); pcie->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(pcie->base)) { - dev_err(&pdev->dev, "Failed to map registers\n"); + if (IS_ERR(pcie->base)) return PTR_ERR(pcie->base); - } irq = platform_get_irq(pdev, 0); ret = devm_request_irq(&pdev->dev, irq, advk_pcie_irq_handler,