| Message ID | 1468875386-31662-1-git-send-email-vincent.stehle@laposte.net |
|---|---|
| State | Not Applicable |
| Headers | show |
Looks fine, but I'm pretty sure irq_reserve_ipi didn't exist by the time we did these changes.. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 19 Jul 2016, Christoph Hellwig wrote: > Looks fine, but I'm pretty sure irq_reserve_ipi didn't exist by the > time we did these changes.. It did, but I simply forgot to fix it up. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/kernel/irq/ipi.c b/kernel/irq/ipi.c index 4fd2351..1a9abc1 100644 --- a/kernel/irq/ipi.c +++ b/kernel/irq/ipi.c @@ -83,7 +83,7 @@ int irq_reserve_ipi(struct irq_domain *domain, } virq = __irq_domain_alloc_irqs(domain, virq, nr_irqs, NUMA_NO_NODE, - (void *) dest, true); + (void *) dest, true, NULL); if (virq <= 0) { pr_warn("Can't reserve IPI, failed to alloc hw irqs\n");
The new affinity hint argument of __irq_domain_alloc_irqs() is missing in irq_reserve_ipi(). Add it. This fixes the following compilation error: kernel/irq/ipi.c: In function ‘irq_reserve_ipi’: kernel/irq/ipi.c:85:9: error: too few arguments to function ‘__irq_domain_alloc_irqs’ virq = __irq_domain_alloc_irqs(domain, virq, nr_irqs, NUMA_NO_NODE, ^ Fixes: 06ee6d571f0e ("genirq: Add affinity hint to irq allocation") Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Christoph Hellwig <hch@lst.de> --- Hi, I saw that in linux next-20160718 with malta_defconfig, ARCH=mips. Best regards, Vincent. kernel/irq/ipi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)