| Message ID | 1468495702-7467-3-git-send-email-amir.jer.levy@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
From: Amir Levy <amir.jer.levy@intel.com> Date: Thu, 14 Jul 2016 14:28:16 +0300 > Adding the new Thunderbolt(TM) device IDs to the list. > > Signed-off-by: Amir Levy <amir.jer.levy@intel.com> Unless these PCI-IDs, all of them, are going to be used in multiple spots in the kernel, it is not appropriate to add them here. They belong as private macros in the drivers themselves, instead. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 15 2016, 09:49 PM, David Miller wrote: > From: Amir Levy <amir.jer.levy@intel.com> > Date: Thu, 14 Jul 2016 14:28:16 +0300 > > > Adding the new Thunderbolt(TM) device IDs to the list. > > > > Signed-off-by: Amir Levy <amir.jer.levy@intel.com> > > Unless these PCI-IDs, all of them, are going to be used in multiple spots in the > kernel, it is not appropriate to add them here. > > They belong as private macros in the drivers themselves, instead. They might be used: http://www.spinics.net/lists/linux-pci/msg51331.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Levy, Amir (Jer)" <amir.jer.levy@intel.com> Date: Fri, 15 Jul 2016 18:56:39 +0000 > On Fri, Jul 15 2016, 09:49 PM, David Miller wrote: >> From: Amir Levy <amir.jer.levy@intel.com> >> Date: Thu, 14 Jul 2016 14:28:16 +0300 >> >> > Adding the new Thunderbolt(TM) device IDs to the list. >> > >> > Signed-off-by: Amir Levy <amir.jer.levy@intel.com> >> >> Unless these PCI-IDs, all of them, are going to be used in multiple spots in the >> kernel, it is not appropriate to add them here. >> >> They belong as private macros in the drivers themselves, instead. > > They might be used: http://www.spinics.net/lists/linux-pci/msg51331.html Then move them to the common location when this "might" thing actually happens. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jul 16 2016, 12:53 AM, David Miller wrote: > From: "Levy, Amir (Jer)" <amir.jer.levy@intel.com> > Date: Fri, 15 Jul 2016 18:56:39 +0000 > > > On Fri, Jul 15 2016, 09:49 PM, David Miller wrote: > >> From: Amir Levy <amir.jer.levy@intel.com> > >> Date: Thu, 14 Jul 2016 14:28:16 +0300 > >> > >> > Adding the new Thunderbolt(TM) device IDs to the list. > >> > > >> > Signed-off-by: Amir Levy <amir.jer.levy@intel.com> > >> > >> Unless these PCI-IDs, all of them, are going to be used in multiple > >> spots in the kernel, it is not appropriate to add them here. > >> > >> They belong as private macros in the drivers themselves, instead. > > > > They might be used: > > http://www.spinics.net/lists/linux-pci/msg51331.html > > Then move them to the common location when this "might" thing actually > happens. There are several contradicting comments about this change (http://www.spinics.net/lists/linux-pci/msg51331.html and http://www.spinics.net/lists/linux-pci/msg51302.html) I've decided for now to make the new device ids private to the driver. This can be changed later when updating quirks for Apple hardware. Regards, Amir -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index c58752f..2d4cc50 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2604,24 +2604,32 @@ #define PCI_DEVICE_ID_INTEL_82441 0x1237 #define PCI_DEVICE_ID_INTEL_82380FB 0x124b #define PCI_DEVICE_ID_INTEL_82439 0x1250 -#define PCI_DEVICE_ID_INTEL_LIGHT_RIDGE 0x1513 /* Tbt 1 Gen 1 */ -#define PCI_DEVICE_ID_INTEL_EAGLE_RIDGE 0x151a -#define PCI_DEVICE_ID_INTEL_LIGHT_PEAK 0x151b -#define PCI_DEVICE_ID_INTEL_CACTUS_RIDGE_4C 0x1547 /* Tbt 1 Gen 2 */ -#define PCI_DEVICE_ID_INTEL_CACTUS_RIDGE_2C 0x1548 -#define PCI_DEVICE_ID_INTEL_PORT_RIDGE 0x1549 -#define PCI_DEVICE_ID_INTEL_REDWOOD_RIDGE_2C_NHI 0x1566 /* Tbt 1 Gen 3 */ -#define PCI_DEVICE_ID_INTEL_REDWOOD_RIDGE_2C_BRIDGE 0x1567 -#define PCI_DEVICE_ID_INTEL_REDWOOD_RIDGE_4C_NHI 0x1568 -#define PCI_DEVICE_ID_INTEL_REDWOOD_RIDGE_4C_BRIDGE 0x1569 -#define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_2C_NHI 0x156a /* Thunderbolt 2 */ -#define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_2C_BRIDGE 0x156b -#define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_4C_NHI 0x156c -#define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_4C_BRIDGE 0x156d -#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_NHI 0x1575 /* Thunderbolt 3 */ -#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_BRIDGE 0x1576 -#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_4C_NHI 0x1577 -#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_4C_BRIDGE 0x1578 +#define PCI_DEVICE_ID_INTEL_LIGHT_RIDGE 0x1513 /* Tbt 1 Gen 1 */ +#define PCI_DEVICE_ID_INTEL_EAGLE_RIDGE 0x151a +#define PCI_DEVICE_ID_INTEL_LIGHT_PEAK 0x151b +#define PCI_DEVICE_ID_INTEL_CACTUS_RIDGE_4C 0x1547 /* Tbt 1 Gen 2 */ +#define PCI_DEVICE_ID_INTEL_CACTUS_RIDGE_2C 0x1548 +#define PCI_DEVICE_ID_INTEL_PORT_RIDGE 0x1549 +#define PCI_DEVICE_ID_INTEL_REDWOOD_RIDGE_2C_NHI 0x1566 /* Tbt 1 Gen 3 */ +#define PCI_DEVICE_ID_INTEL_REDWOOD_RIDGE_2C_BRIDGE 0x1567 +#define PCI_DEVICE_ID_INTEL_REDWOOD_RIDGE_4C_NHI 0x1568 +#define PCI_DEVICE_ID_INTEL_REDWOOD_RIDGE_4C_BRIDGE 0x1569 +#define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_2C_NHI 0x156a /* Thunderbolt 2 */ +#define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_2C_BRIDGE 0x156b +#define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_4C_NHI 0x156c +#define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_4C_BRIDGE 0x156d +#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_NHI 0x1575 /* Thunderbolt 3 */ +#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_BRIDGE 0x1576 +#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_4C_NHI 0x1577 +#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_4C_BRIDGE 0x1578 +#define PCI_DEVICE_ID_INTEL_WIN_RIDGE_2C_NHI 0x157d /* Tbt 2 Low Pwr */ +#define PCI_DEVICE_ID_INTEL_WIN_RIDGE_2C_BRIDGE 0x157e +#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_LP_NHI 0x15bf /* Tbt 3 Low Pwr */ +#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_LP_BRIDGE 0x15c0 +#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_4C_NHI 0x15d2 /* Thunderbolt 3 */ +#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_4C_BRIDGE 0x15d3 +#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_2C_NHI 0x15d9 +#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_2C_BRIDGE 0x15da #define PCI_DEVICE_ID_INTEL_80960_RP 0x1960 #define PCI_DEVICE_ID_INTEL_82840_HB 0x1a21 #define PCI_DEVICE_ID_INTEL_82845_HB 0x1a30
Adding the new Thunderbolt(TM) device IDs to the list. Signed-off-by: Amir Levy <amir.jer.levy@intel.com> --- include/linux/pci_ids.h | 44 ++++++++++++++++++++++++++------------------ 1 file changed, 26 insertions(+), 18 deletions(-)