| Message ID | 1465392461-3469-1-git-send-email-fabio.estevam@nxp.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Jun 8, 2016 at 10:27 AM, Fabio Estevam <fabio.estevam@nxp.com> wrote: > The PCI hardware on imx6 requires the following clocks: > "pcie", "pcie_bus" and "pcie_phy", so add the missing clocks > in the clock-names property. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > --- > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > index 83aeb1f..94ab92c 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > @@ -10,8 +10,8 @@ Required properties: > entry for each entry in the interrupt-names property. > - interrupt-names: Must include the following entries: > - "msi": The interrupt that is asserted when an MSI is received > -- clock-names: Must include the following additional entries: > - - "pcie_phy" > +- clock-names: Must include the following entries: > + - "pcie", "pcie_bus" and "pcie_phy". Ah, just realized that the "pcie" and "pcie_bus" are already listed in designware-pci.txt. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am Mittwoch, den 08.06.2016, 10:27 -0300 schrieb Fabio Estevam: > The PCI hardware on imx6 requires the following clocks: > "pcie", "pcie_bus" and "pcie_phy", so add the missing clocks > in the clock-names property. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > --- > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > index 83aeb1f..94ab92c 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > @@ -10,8 +10,8 @@ Required properties: > entry for each entry in the interrupt-names property. > - interrupt-names: Must include the following entries: > - "msi": The interrupt that is asserted when an MSI is received > -- clock-names: Must include the following additional entries: > - - "pcie_phy" > +- clock-names: Must include the following entries: > + - "pcie", "pcie_bus" and "pcie_phy". NACK. Both "pcie" and "pcie_bus" are inherited from the common designware-pcie.txt binding. That's why it reads "must include the following ADDITIONAL entries". Regards, Lucas -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt index 83aeb1f..94ab92c 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt @@ -10,8 +10,8 @@ Required properties: entry for each entry in the interrupt-names property. - interrupt-names: Must include the following entries: - "msi": The interrupt that is asserted when an MSI is received -- clock-names: Must include the following additional entries: - - "pcie_phy" +- clock-names: Must include the following entries: + - "pcie", "pcie_bus" and "pcie_phy". Optional properties: - fsl,tx-deemph-gen1: Gen1 De-emphasis value. Default: 0
The PCI hardware on imx6 requires the following clocks: "pcie", "pcie_bus" and "pcie_phy", so add the missing clocks in the clock-names property. Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> --- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)