diff mbox

PCI/AER: Make linux/aer.h standalone includable

Message ID 1407240535-19564-1-git-send-email-thierry.reding@gmail.com
State Accepted
Headers show

Commit Message

Thierry Reding Aug. 5, 2014, 12:08 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

The header file references u16, u32 and struct pci_dev types, but they
are not defined in the header nor does the header pull in the necessary
includes for them. This causes build breakage when the file is included
without any of the dependencies being satisfied from somewhere else.

Fix this by including linux/types.h (for u16 and u32) and by adding a
forward-declaration of struct pci_dev.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 include/linux/aer.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Bjorn Helgaas Sept. 4, 2014, 9:58 p.m. UTC | #1
On Tue, Aug 05, 2014 at 02:08:55PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The header file references u16, u32 and struct pci_dev types, but they
> are not defined in the header nor does the header pull in the necessary
> includes for them. This causes build breakage when the file is included
> without any of the dependencies being satisfied from somewhere else.
> 
> Fix this by including linux/types.h (for u16 and u32) and by adding a
> forward-declaration of struct pci_dev.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Applied to pci/misc for v3.18, thanks!  I dropped the struct pci_dev
declaration because it was already added by 5ccb8225abf2 ("x86/ras: Fix
build warnings in <linux/aer.h>")

> ---
>  include/linux/aer.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/aer.h b/include/linux/aer.h
> index 4dbaa7081530..04bcf33a3e3a 100644
> --- a/include/linux/aer.h
> +++ b/include/linux/aer.h
> @@ -7,6 +7,10 @@
>  #ifndef _AER_H_
>  #define _AER_H_
>  
> +#include <linux/types.h>
> +
> +struct pci_dev;
> +
>  #define AER_NONFATAL			0
>  #define AER_FATAL			1
>  #define AER_CORRECTABLE			2
> -- 
> 2.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/aer.h b/include/linux/aer.h
index 4dbaa7081530..04bcf33a3e3a 100644
--- a/include/linux/aer.h
+++ b/include/linux/aer.h
@@ -7,6 +7,10 @@ 
 #ifndef _AER_H_
 #define _AER_H_
 
+#include <linux/types.h>
+
+struct pci_dev;
+
 #define AER_NONFATAL			0
 #define AER_FATAL			1
 #define AER_CORRECTABLE			2