From patchwork Mon Jun 30 08:37:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Edworthy X-Patchwork-Id: 365514 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3DD261400FA for ; Mon, 30 Jun 2014 18:37:11 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229AbaF3IhJ (ORCPT ); Mon, 30 Jun 2014 04:37:09 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:62738 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752209AbaF3IhI (ORCPT ); Mon, 30 Jun 2014 04:37:08 -0400 Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie3.idc.renesas.com with ESMTP; 30 Jun 2014 17:37:06 +0900 Received: from relmlac4.idc.renesas.com (relmlac4.idc.renesas.com [10.200.69.24]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id A48D73F977; Mon, 30 Jun 2014 17:37:06 +0900 (JST) Received: by relmlac4.idc.renesas.com (Postfix, from userid 0) id 93EF0480A7; Mon, 30 Jun 2014 17:37:06 +0900 (JST) Received: from relmlac4.idc.renesas.com (localhost [127.0.0.1]) by relmlac4.idc.renesas.com (Postfix) with ESMTP id 79240480A6; Mon, 30 Jun 2014 17:37:06 +0900 (JST) Received: from relmlii2.idc.renesas.com [10.200.68.66] by relmlac4.idc.renesas.com with ESMTP id TAB19135; Mon, 30 Jun 2014 17:37:06 +0900 X-IronPort-AV: E=Sophos;i="5.01,573,1399993200"; d="scan'208";a="164403857" Received: from unknown (HELO relay41.aps.necel.com) ([10.29.19.9]) by relmlii2.idc.renesas.com with ESMTP; 30 Jun 2014 17:37:06 +0900 Received: from DU0NOTES13.ad.ree.renesas.com ([172.29.24.131]) by relay41.aps.necel.com (8.14.4+Sun/8.14.4) with ESMTP id s5U8b50t007062; Mon, 30 Jun 2014 17:37:05 +0900 (JST) Received: from duacsls.ad.ree.renesas.com ([172.29.43.47]) by DU0NOTES13.ad.ree.renesas.com (Lotus Domino Release 8.5.3 HF466) with ESMTP id 2014063010370402-274534 ; Mon, 30 Jun 2014 10:37:04 +0200 From: Phil Edworthy To: linux-pci@vger.kernel.org Cc: linux-sh@vger.kernel.org, Bjorn Helgaas , Simon Horman , Sergei Shtylyov , Phil Edworthy X-Mailer: git-send-email 2.0.0 In-Reply-To: <1404114864-17330-4-git-send-email-phil.edworthy@renesas.com> References: <1404114864-17330-4-git-send-email-phil.edworthy@renesas.com> X-TNEFEvaluated: 1 Message-ID: <1404117421-17557-1-git-send-email-phil.edworthy@renesas.com> Date: Mon, 30 Jun 2014 09:37:01 +0100 Subject: [PATCH v2 3/3] PCI: host: pcie-rcar: Replace arg passed into a func with local var X-MIMETrack: Itemize by SMTP Server on DU0NOTES13/SERVER/REE(Release 8.5.3 HF466|March 09, 2012) at 30.06.2014 10:37:04, Serialize by Router on DU0NOTES13/SERVER/REE(Release 8.5.3 HF466|March 09, 2012) at 30.06.2014 10:37:05, Serialize complete at 30.06.2014 10:37:05 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Signed-off-by: Phil Edworthy --- With SoB this time... drivers/pci/host/pcie-rcar.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c index 758e2b4..efdea07 100644 --- a/drivers/pci/host/pcie-rcar.c +++ b/drivers/pci/host/pcie-rcar.c @@ -319,9 +319,10 @@ static struct pci_ops rcar_pcie_ops = { .write = rcar_pcie_write_conf, }; -static void rcar_pcie_setup_window(int win, struct resource *res, - struct rcar_pcie *pcie) +static void rcar_pcie_setup_window(int win, struct rcar_pcie *pcie) { + struct resource *res = &pcie->res[win]; + /* Setup PCIe address space mappings for each resource */ resource_size_t size; u32 mask; @@ -362,7 +363,7 @@ static int rcar_pcie_setup(int nr, struct pci_sys_data *sys) if (!res->flags) continue; - rcar_pcie_setup_window(i, res, pcie); + rcar_pcie_setup_window(i, pcie); if (res->flags & IORESOURCE_IO) pci_ioremap_io(nr * SZ_64K, res->start);