From patchwork Sun Jun 3 18:48:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 162594 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 34229B6FA9 for ; Mon, 4 Jun 2012 05:26:56 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754429Ab2FCT0z (ORCPT ); Sun, 3 Jun 2012 15:26:55 -0400 Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:47051 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754360Ab2FCT0z (ORCPT ); Sun, 3 Jun 2012 15:26:55 -0400 Received: from localhost ([127.0.0.1] helo=bazinga.HH.breakpoint.cc ident=410d493183e3c5611c03d88e6b900be8) by Chamillionaire.breakpoint.cc with esmtp (Exim 4.72) (envelope-from ) id 1SbFqs-0002L8-Gy; Sun, 03 Jun 2012 20:48:34 +0200 From: Sebastian Andrzej Siewior To: linux-pci@vger.kernel.org Cc: linux-kbuild@vger.kernel.org, Bjorn Helgaas , Michal Marek , Sebastian Andrzej Siewior , Russell King Subject: [PATCH 5/9] arm: move PCI fixup hooks from __init to __devinit Date: Sun, 3 Jun 2012 20:48:21 +0200 Message-Id: <1338749305-22558-6-git-send-email-sebastian@breakpoint.cc> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1338749305-22558-1-git-send-email-sebastian@breakpoint.cc> References: <1338749305-22558-1-git-send-email-sebastian@breakpoint.cc> X-Breakpoint-Spam-Score: -1.0 X-Breakpoint-Spam-Level: - X-Breakpoint-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The fixups are executed once the pci-device is found which is during boot process so __init seems fine as long as the platform does not support hotplug. However it is possible to remove the PCI bus at run time and have it rediscovered again via "echo 1 > /sys/bus/pci/rescan" and this will call the fixups again. Cc: Russell King Signed-off-by: Sebastian Andrzej Siewior --- arch/arm/kernel/bios32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c index 2555250..1c1a0e2 100644 --- a/arch/arm/kernel/bios32.c +++ b/arch/arm/kernel/bios32.c @@ -253,7 +253,7 @@ static void __devinit pci_fixup_cy82c693(struct pci_dev *dev) } DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CONTAQ, PCI_DEVICE_ID_CONTAQ_82C693, pci_fixup_cy82c693); -static void __init pci_fixup_it8152(struct pci_dev *dev) +static void __devinit pci_fixup_it8152(struct pci_dev *dev) { int i; /* fixup for ITE 8152 devices */