From patchwork Wed Apr 11 00:10:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiang Liu X-Patchwork-Id: 151707 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0766EB7014 for ; Wed, 11 Apr 2012 10:14:23 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759840Ab2DKAOW (ORCPT ); Tue, 10 Apr 2012 20:14:22 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:45686 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759550Ab2DKAOV (ORCPT ); Tue, 10 Apr 2012 20:14:21 -0400 Received: by mail-pb0-f46.google.com with SMTP id un15so552527pbc.19 for ; Tue, 10 Apr 2012 17:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=2h76h0g8rSvNR0V8oNyOooPiNLxM7l7QFj+vPx5CH5k=; b=XrB2kRh5/ZkVN8jPu5zgWP1+o9tbW/fJI2fBQpurfTQEHnfWwEkYGHmf+lLeoMLwWx jnA+2oEQfcUFeY/IGz3dex+QnVpk4nwh9hk6euc2ER2uWMtU857WDPNvUxpWKyRfQe2/ bNm61gj0NOX6588SLbR2J0bQN8GLIi38+ssm7BzDbbycKkqFueXIs8ULFfGBgwn/8ggp al+UMgR0JdV4Ewy58MRKs0TVihemb24ZBbhIYb8rrkXC32LrctQEYFjOitt8MMz49L6D KEUsjD7lDubjn7xhld4Ylf2c9Rp8+jP0CioBOhKmWPl94NHKtYXeygZdz7aHIzJA+ld7 JvxA== Received: by 10.68.234.231 with SMTP id uh7mr5535551pbc.77.1334103261663; Tue, 10 Apr 2012 17:14:21 -0700 (PDT) Received: from localhost.localdomain ([221.221.23.44]) by mx.google.com with ESMTPS id r6sm1220739pbl.24.2012.04.10.17.14.11 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 10 Apr 2012 17:14:20 -0700 (PDT) From: Jiang Liu To: Yinghai Lu , Kenji Kaneshige , Taku Izumi Cc: Jiang Liu , Bjorn Helgaas , Jiang Liu , Keping Chen , linux-pci@vger.kernel.org Subject: [PATCH V4 1/6] PCI, x86: split out pci_mmcfg_check_reserved() for code reuse Date: Wed, 11 Apr 2012 08:10:58 +0800 Message-Id: <1334103063-2283-2-git-send-email-jiang.liu@huawei.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1334103063-2283-1-git-send-email-jiang.liu@huawei.com> References: <1334103063-2283-1-git-send-email-jiang.liu@huawei.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Split out pci_mmcfg_check_reserved() for code reuse, which will be used when supporting PCI host bridge hotplug. Signed-off-by: Jiang Liu --- arch/x86/pci/mmconfig-shared.c | 51 +++++++++++++++++++-------------------- 1 files changed, 25 insertions(+), 26 deletions(-) diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c index 301e325..f799949 100644 --- a/arch/x86/pci/mmconfig-shared.c +++ b/arch/x86/pci/mmconfig-shared.c @@ -474,39 +474,38 @@ static int __init is_mmconf_reserved(check_reserved_t is_reserved, return valid; } +static int __devinit pci_mmcfg_check_reserved(struct pci_mmcfg_region *cfg, + int early) +{ + if (!early && !acpi_disabled) { + if (is_mmconf_reserved(is_acpi_reserved, cfg, 0)) + return 1; + else + printk(KERN_ERR FW_BUG PREFIX + "MMCONFIG at %pR not reserved in " + "ACPI motherboard resources\n", + &cfg->res); + } + + /* Don't try to do this check unless configuration + type 1 is available. how about type 2 ?*/ + if (raw_pci_ops) + return is_mmconf_reserved(e820_all_mapped, cfg, 1); + + return 0; +} + static void __init pci_mmcfg_reject_broken(int early) { struct pci_mmcfg_region *cfg; list_for_each_entry(cfg, &pci_mmcfg_list, list) { - int valid = 0; - - if (!early && !acpi_disabled) { - valid = is_mmconf_reserved(is_acpi_reserved, cfg, 0); - - if (valid) - continue; - else - printk(KERN_ERR FW_BUG PREFIX - "MMCONFIG at %pR not reserved in " - "ACPI motherboard resources\n", - &cfg->res); + if (pci_mmcfg_check_reserved(cfg, early) == 0) { + printk(KERN_INFO PREFIX "not using MMCONFIG\n"); + free_all_mmcfg(); + return; } - - /* Don't try to do this check unless configuration - type 1 is available. how about type 2 ?*/ - if (raw_pci_ops) - valid = is_mmconf_reserved(e820_all_mapped, cfg, 1); - - if (!valid) - goto reject; } - - return; - -reject: - printk(KERN_INFO PREFIX "not using MMCONFIG\n"); - free_all_mmcfg(); } static int __initdata known_bridge;