mbox series

[v2,0/8] Improve Synopsys DesignWare Root Complex driver code

Message ID cover.1548958059.git.gustavo.pimentel@synopsys.com
Headers show
Series Improve Synopsys DesignWare Root Complex driver code | expand

Message

Gustavo Pimentel Jan. 31, 2019, 6:16 p.m. UTC
This patch series aims to improve Synopsys DesignWare Root Complex driver
code by:
 - removing unnecessary header files
 - enforcing variable naming coherency among similar functions
 - simplifing code readability of mask/unmask function operations
 - replacing bit rotation operation (1 << bit) by BIT(bit)

No functional changes are intended.

All patches are independent so they can be easily analyzed and accepted or
discarded.

This patches organization also allows to easily merge (squash) some patches,
if desired.

Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: Jingoo Han <jingoohan1@gmail.com>

Gustavo Pimentel (8):
  PCI: dwc: Remove unnecessary header include (of_gpio.h)
  PCI: dwc: Remove unnecessary header include (signal.h)
  PCI: dwc: Rename variable name from data to d on
    dw_pci_bottom_mask/unmask()
  PCI: dwc: Rename variable name from data to d on
    dw_pci_setup_msi_msg()
  PCI: dwc: Rename variable name from data to d on
    dw_pci_msi_set_affinity()
  PCI: dwc: Rename variable name from data to d on
    dw_pcie_irq_domain_free()
  PCI: dwc: Improve code readability and simplifies mask/unmask
    operations
  PCI: dwc: Replace bit rotation operation (1 << bit) by BIT(bit)

 drivers/pci/controller/dwc/pcie-designware-host.c | 52 +++++++++++------------
 drivers/pci/controller/dwc/pcie-designware-plat.c |  2 -
 drivers/pci/controller/dwc/pcie-designware.h      |  2 +-
 3 files changed, 27 insertions(+), 29 deletions(-)

Comments

Lorenzo Pieralisi Feb. 1, 2019, 12:42 p.m. UTC | #1
On Thu, Jan 31, 2019 at 07:16:59PM +0100, Gustavo Pimentel wrote:
> This patch series aims to improve Synopsys DesignWare Root Complex driver
> code by:
>  - removing unnecessary header files
>  - enforcing variable naming coherency among similar functions
>  - simplifing code readability of mask/unmask function operations
>  - replacing bit rotation operation (1 << bit) by BIT(bit)
> 
> No functional changes are intended.
> 
> All patches are independent so they can be easily analyzed and accepted or
> discarded.
> 
> This patches organization also allows to easily merge (squash) some patches,
> if desired.
> 
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Joao Pinto <jpinto@synopsys.com>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> 
> Gustavo Pimentel (8):
>   PCI: dwc: Remove unnecessary header include (of_gpio.h)
>   PCI: dwc: Remove unnecessary header include (signal.h)
>   PCI: dwc: Rename variable name from data to d on
>     dw_pci_bottom_mask/unmask()
>   PCI: dwc: Rename variable name from data to d on
>     dw_pci_setup_msi_msg()
>   PCI: dwc: Rename variable name from data to d on
>     dw_pci_msi_set_affinity()
>   PCI: dwc: Rename variable name from data to d on
>     dw_pcie_irq_domain_free()
>   PCI: dwc: Improve code readability and simplifies mask/unmask
>     operations
>   PCI: dwc: Replace bit rotation operation (1 << bit) by BIT(bit)
> 
>  drivers/pci/controller/dwc/pcie-designware-host.c | 52 +++++++++++------------
>  drivers/pci/controller/dwc/pcie-designware-plat.c |  2 -
>  drivers/pci/controller/dwc/pcie-designware.h      |  2 +-
>  3 files changed, 27 insertions(+), 29 deletions(-)
> 

Applied to pci/dwc for v5.1, thanks.

Lorenzo