| Message ID | 20261001142815.277550-1-herve.codina@bootlin.com |
|---|---|
| Headers | show |
| Series | lan966x pci device: Add support for SFPs, PCI part | expand |
> The code set directly fwnode->dev field. > > Use the dedicated fw_devlink_set_device() helper to perform this > operation. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> Sashiko has reviewed this patch and found no issues. It looks great!
> During the of_pci_make_host_bridge_node() call, an OF node is created > dynamically and its fwnode device (fwnode->dev) is set to the PCI root > bridge device using the fw_devlink_set_device(&np->fwnode, &bridge->dev) > call. > > On removal, of_pci_remove_host_bridge_node() is called and calls > device_remove_of_node() which in turn set to NULL the related > dev->fwnode. > > Later in the removal sequence, device_del() is called and runs its > cleanup logic: > > if (dev->fwnode && dev->fwnode->dev == dev) > fw_devlink_set_device(dev->fwnode, NULL); > > [ ... ] > error path. > > Fixes: 1f340724419e ("PCI: of: Create device tree PCI host bridge node") > Cc: stable@vger.kernel.org > Signed-off-by: Herve Codina <herve.codina@bootlin.com> Sashiko has reviewed this patch and found no issues. It looks great!
Hi, Previously, I sent a big picture series adding support for SFP ports available on the LAN966x PCI device [0]. In this series patches touch several parts and sub-system in the kernel. Reviews have be done and it makes sense to split the series and send parts separately. This current series is the extraction of patches related to issues in the PCI subsystem. It has to be seen as a continuation of the big picture series but related to this specific core part. Patches 1 to 6 introduce and use fw_devlink_set_device() in already existing code. No functional change but the introduction of the fw_devlink_set_device() wrapper. Patch 7 avoids a dangling pointer. Patches 8 and 9 fix fw_devlink issues specific to PCI and the device-tree nodes created during enumeration. Patch 10 avoids the usage of np->data and adds guards to prevent incorrect nodes removal. [0] https://lore.kernel.org/all/20260325143555.451852-1-herve.codina@bootlin.com/ Best regards, Hervé Changes: v11 -> v12 v11: https://lore.kernel.org/all/20260909080114.591938-1-herve.codina@bootlin.com/ - Patches 1 to 7 Add 'Reviewed-by: Bartosz Golaszewski' - Patches 8 and 9 No changes - Patch 10 Add a NULL check for the retrieved OF node in removal functions to avoid any NULL pointer dereferences. Robustify the guard setting cset to NULL after freeing it. Those issues have been reported by Shashiko: https://lore.kernel.org/all/20260909081755.444E91F00A3A@smtp.kernel.org/ v10 -> v11 v10: https://lore.kernel.org/all/20260717145147.823749-1-herve.codina@bootlin.com/ Rebase on top of v7.3-rc1 - Patches 1 to 5 Add 'Reviewed-by: Richard Cheng' - Patches 6, 7 and 8 Add 'Reviewed-by: Richard Cheng' Add 'Acked-by: Manivannan Sadhasivam' - Patch 9 Add 'Reviewed-by: Richard Cheng' - Patch 10 Rework removing np->data usage in the PCI devicetree node creation and removal. v9 -> v10 v9: https://lore.kernel.org/all/20260708100302.517792-1-herve.codina@bootlin.com/ - Patches 1 to 6 No changes - Patch 7 Clear fwnode->dev also on error path. - Patch 8 Clear fwnode->dev also on error path. - Patch 9 No changes - Patch 10 (New patch in v10) Guard against node removal with incorrect np->data. v8 -> v9 v8: https://lore.kernel.org/all/20260630102804.413563-1-herve.codina@bootlin.com/ - Patch 7 (new patch in v9) Clear fwnode->dev during root bridge node removal (avoid a dangling pointer). - Patch 8 (patch 7 in v8) Clear fwnode->dev during PCI device node removal. v7 -> v8 v7: https://lore.kernel.org/all/20260511155930.34604-1-herve.codina@bootlin.com/ Rebase on top of v7.2-rc1 - patches 4 and 5 Add 'Reviewed-by: Andy Shevchenko' - Other Patches No other changes v6 -> v7 Rebase on top of v7.1-rc1 - Patch 1 Add Cc stable. Needed for patches 11 and 12 - Patches 2 to 5 No changes - Patch 6 Add Cc stable. Needed for patch 13 Add 'Acked-by: Bjorn Helgaas' - Patch 7 Fix a typo in commit log Add Fixes tag + Cc stable Add 'Acked-by: Bjorn Helgaas' - Patch 8 Add Fixes tag + Cc stable Add 'Acked-by: Bjorn Helgaas' Older iterations: Patches 6 to 13 in the big picture series https://lore.kernel.org/all/20260325143555.451852-1-herve.codina@bootlin.com/ Herve Codina (10): driver core: fw_devlink: Introduce fw_devlink_set_device() drivers: core: Use fw_devlink_set_device() pinctrl: cs42l43: Use fw_devlink_set_device() cxl/test: Use device_set_node() cxl/test: Use fw_devlink_set_device() PCI: of: Use fw_devlink_set_device() PCI: of: Clear fwnode->dev during root bridge node removal and error path PCI: of: Set fwnode device of newly created PCI device nodes PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge node PCI: of: Avoid np->data usage for the node changeset drivers/base/core.c | 4 +-- drivers/pci/of.c | 46 +++++++++++++++--------- drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 2 +- include/linux/fwnode.h | 6 ++++ include/linux/pci.h | 11 ++++++ tools/testing/cxl/test/cxl.c | 4 +-- 6 files changed, 52 insertions(+), 21 deletions(-)