mbox series

[v7,0/3] PCI: tegra: Allow building as a module

Message ID 20250731-pci-tegra-module-v7-0-cad4b088b8fb@gmail.com
Headers show
Series PCI: tegra: Allow building as a module | expand

Message

Aaron Kling via B4 Relay July 31, 2025, 9:59 p.m. UTC
Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
Changes in v7:
- Rebased on 6.16
- Updated mailing address list
- Link to v6: https://lore.kernel.org/r/20250507-pci-tegra-module-v6-0-5fe363eaa302@gmail.com

Changes in v6:
- Remove unused debugfs cleanup function, as caught by kernel ci
- Link to v5: https://lore.kernel.org/r/20250505-pci-tegra-module-v5-0-827aaac998ba@gmail.com

Changes in v5:
- Copy commit message exactly word for word on patch 1, as required by reviewer
- Delete remove callback in patch 3, per request
- Don't clean up debugfs, per request, which drops patch 4 entirely
- Link to v4: https://lore.kernel.org/r/20250505-pci-tegra-module-v4-0-088b552c4b1a@gmail.com

Changes in v4:
- Updated commit messages for patches 1 and 2, per review
- Link to v3: https://lore.kernel.org/r/20250502-pci-tegra-module-v3-0-556a49732d70@gmail.com

Changes in v3:
- Add patch to drop remove callback, per request
- Link to v2: https://lore.kernel.org/r/20250428-pci-tegra-module-v2-0-c11a4b912446@gmail.com

Changes in v2:
- Add patch to export tegra_cpuidle_pcie_irqs_in_use as required when
  building pci-tegra as a module for arm
- Drop module exit to prevent module unloading, as requested
- Link to v1: https://lore.kernel.org/r/20250420-pci-tegra-module-v1-0-c0a1f831354a@gmail.com

---
Aaron Kling (3):
      irqdomain: Export irq_domain_free_irqs
      cpuidle: tegra: Export tegra_cpuidle_pcie_irqs_in_use
      PCI: tegra: Allow building as a module

 drivers/cpuidle/cpuidle-tegra.c    |  1 +
 drivers/pci/controller/Kconfig     |  2 +-
 drivers/pci/controller/pci-tegra.c | 35 ++++-------------------------------
 kernel/irq/irqdomain.c             |  1 +
 4 files changed, 7 insertions(+), 32 deletions(-)
---
base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
change-id: 20250313-pci-tegra-module-7cbd1c5e70af

Best regards,

Comments

Aaron Kling July 31, 2025, 10:01 p.m. UTC | #1
On Thu, Jul 31, 2025 at 4:59 PM Aaron Kling via B4 Relay
<devnull+webgeek1234.gmail.com@kernel.org> wrote:
>
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> Changes in v7:
> - Rebased on 6.16
> - Updated mailing address list
> - Link to v6: https://lore.kernel.org/r/20250507-pci-tegra-module-v6-0-5fe363eaa302@gmail.com
>
> Changes in v6:
> - Remove unused debugfs cleanup function, as caught by kernel ci
> - Link to v5: https://lore.kernel.org/r/20250505-pci-tegra-module-v5-0-827aaac998ba@gmail.com
>
> Changes in v5:
> - Copy commit message exactly word for word on patch 1, as required by reviewer
> - Delete remove callback in patch 3, per request
> - Don't clean up debugfs, per request, which drops patch 4 entirely
> - Link to v4: https://lore.kernel.org/r/20250505-pci-tegra-module-v4-0-088b552c4b1a@gmail.com
>
> Changes in v4:
> - Updated commit messages for patches 1 and 2, per review
> - Link to v3: https://lore.kernel.org/r/20250502-pci-tegra-module-v3-0-556a49732d70@gmail.com
>
> Changes in v3:
> - Add patch to drop remove callback, per request
> - Link to v2: https://lore.kernel.org/r/20250428-pci-tegra-module-v2-0-c11a4b912446@gmail.com
>
> Changes in v2:
> - Add patch to export tegra_cpuidle_pcie_irqs_in_use as required when
>   building pci-tegra as a module for arm
> - Drop module exit to prevent module unloading, as requested
> - Link to v1: https://lore.kernel.org/r/20250420-pci-tegra-module-v1-0-c0a1f831354a@gmail.com
>
> ---
> Aaron Kling (3):
>       irqdomain: Export irq_domain_free_irqs
>       cpuidle: tegra: Export tegra_cpuidle_pcie_irqs_in_use
>       PCI: tegra: Allow building as a module
>
>  drivers/cpuidle/cpuidle-tegra.c    |  1 +
>  drivers/pci/controller/Kconfig     |  2 +-
>  drivers/pci/controller/pci-tegra.c | 35 ++++-------------------------------
>  kernel/irq/irqdomain.c             |  1 +
>  4 files changed, 7 insertions(+), 32 deletions(-)
> ---
> base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
> change-id: 20250313-pci-tegra-module-7cbd1c5e70af
>
> Best regards,
> --
> Aaron Kling <webgeek1234@gmail.com>
>
>

Continuing the conversation from the last revision [0]. Is there any
path forward for this series?

Aaron

[0] https://lore.kernel.org/all/CALHNRZ84Xj=_HqrFWnYHdV-A9YM4yu2FhfYgHy4-sR65tsYbUA@mail.gmail.com/
Manivannan Sadhasivam Aug. 1, 2025, 6 a.m. UTC | #2
On Thu, Jul 31, 2025 at 05:01:55PM GMT, Aaron Kling wrote:
> On Thu, Jul 31, 2025 at 4:59 PM Aaron Kling via B4 Relay
> <devnull+webgeek1234.gmail.com@kernel.org> wrote:
> >
> > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > ---
> > Changes in v7:
> > - Rebased on 6.16
> > - Updated mailing address list
> > - Link to v6: https://lore.kernel.org/r/20250507-pci-tegra-module-v6-0-5fe363eaa302@gmail.com
> >
> > Changes in v6:
> > - Remove unused debugfs cleanup function, as caught by kernel ci
> > - Link to v5: https://lore.kernel.org/r/20250505-pci-tegra-module-v5-0-827aaac998ba@gmail.com
> >
> > Changes in v5:
> > - Copy commit message exactly word for word on patch 1, as required by reviewer
> > - Delete remove callback in patch 3, per request
> > - Don't clean up debugfs, per request, which drops patch 4 entirely
> > - Link to v4: https://lore.kernel.org/r/20250505-pci-tegra-module-v4-0-088b552c4b1a@gmail.com
> >
> > Changes in v4:
> > - Updated commit messages for patches 1 and 2, per review
> > - Link to v3: https://lore.kernel.org/r/20250502-pci-tegra-module-v3-0-556a49732d70@gmail.com
> >
> > Changes in v3:
> > - Add patch to drop remove callback, per request
> > - Link to v2: https://lore.kernel.org/r/20250428-pci-tegra-module-v2-0-c11a4b912446@gmail.com
> >
> > Changes in v2:
> > - Add patch to export tegra_cpuidle_pcie_irqs_in_use as required when
> >   building pci-tegra as a module for arm
> > - Drop module exit to prevent module unloading, as requested
> > - Link to v1: https://lore.kernel.org/r/20250420-pci-tegra-module-v1-0-c0a1f831354a@gmail.com
> >
> > ---
> > Aaron Kling (3):
> >       irqdomain: Export irq_domain_free_irqs
> >       cpuidle: tegra: Export tegra_cpuidle_pcie_irqs_in_use
> >       PCI: tegra: Allow building as a module
> >
> >  drivers/cpuidle/cpuidle-tegra.c    |  1 +
> >  drivers/pci/controller/Kconfig     |  2 +-
> >  drivers/pci/controller/pci-tegra.c | 35 ++++-------------------------------
> >  kernel/irq/irqdomain.c             |  1 +
> >  4 files changed, 7 insertions(+), 32 deletions(-)
> > ---
> > base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
> > change-id: 20250313-pci-tegra-module-7cbd1c5e70af
> >
> > Best regards,
> > --
> > Aaron Kling <webgeek1234@gmail.com>
> >
> >
> 
> Continuing the conversation from the last revision [0]. Is there any
> path forward for this series?
> 

Daniel, could you please look into the cpufreq patch?

- Mani
Aaron Kling Aug. 18, 2025, 6:39 p.m. UTC | #3
On Fri, Aug 1, 2025 at 1:01 AM Manivannan Sadhasivam <mani@kernel.org> wrote:
>
> On Thu, Jul 31, 2025 at 05:01:55PM GMT, Aaron Kling wrote:
> > On Thu, Jul 31, 2025 at 4:59 PM Aaron Kling via B4 Relay
> > <devnull+webgeek1234.gmail.com@kernel.org> wrote:
> > >
> > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > > ---
> > > Changes in v7:
> > > - Rebased on 6.16
> > > - Updated mailing address list
> > > - Link to v6: https://lore.kernel.org/r/20250507-pci-tegra-module-v6-0-5fe363eaa302@gmail.com
> > >
> > > Changes in v6:
> > > - Remove unused debugfs cleanup function, as caught by kernel ci
> > > - Link to v5: https://lore.kernel.org/r/20250505-pci-tegra-module-v5-0-827aaac998ba@gmail.com
> > >
> > > Changes in v5:
> > > - Copy commit message exactly word for word on patch 1, as required by reviewer
> > > - Delete remove callback in patch 3, per request
> > > - Don't clean up debugfs, per request, which drops patch 4 entirely
> > > - Link to v4: https://lore.kernel.org/r/20250505-pci-tegra-module-v4-0-088b552c4b1a@gmail.com
> > >
> > > Changes in v4:
> > > - Updated commit messages for patches 1 and 2, per review
> > > - Link to v3: https://lore.kernel.org/r/20250502-pci-tegra-module-v3-0-556a49732d70@gmail.com
> > >
> > > Changes in v3:
> > > - Add patch to drop remove callback, per request
> > > - Link to v2: https://lore.kernel.org/r/20250428-pci-tegra-module-v2-0-c11a4b912446@gmail.com
> > >
> > > Changes in v2:
> > > - Add patch to export tegra_cpuidle_pcie_irqs_in_use as required when
> > >   building pci-tegra as a module for arm
> > > - Drop module exit to prevent module unloading, as requested
> > > - Link to v1: https://lore.kernel.org/r/20250420-pci-tegra-module-v1-0-c0a1f831354a@gmail.com
> > >
> > > ---
> > > Aaron Kling (3):
> > >       irqdomain: Export irq_domain_free_irqs
> > >       cpuidle: tegra: Export tegra_cpuidle_pcie_irqs_in_use
> > >       PCI: tegra: Allow building as a module
> > >
> > >  drivers/cpuidle/cpuidle-tegra.c    |  1 +
> > >  drivers/pci/controller/Kconfig     |  2 +-
> > >  drivers/pci/controller/pci-tegra.c | 35 ++++-------------------------------
> > >  kernel/irq/irqdomain.c             |  1 +
> > >  4 files changed, 7 insertions(+), 32 deletions(-)
> > > ---
> > > base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
> > > change-id: 20250313-pci-tegra-module-7cbd1c5e70af
> > >
> > > Best regards,
> > > --
> > > Aaron Kling <webgeek1234@gmail.com>
> > >
> > >
> >
> > Continuing the conversation from the last revision [0]. Is there any
> > path forward for this series?
> >
>
> Daniel, could you please look into the cpufreq patch?

Another two weeks with no response to a review request. And over two
months total since the cpuidle maintainers were initially asked to
look. Is there a policy for dealing with lack of responses?

Aaron
Aaron Kling Sept. 22, 2025, 4:18 p.m. UTC | #4
On Mon, Aug 18, 2025 at 1:39 PM Aaron Kling <webgeek1234@gmail.com> wrote:
>
> On Fri, Aug 1, 2025 at 1:01 AM Manivannan Sadhasivam <mani@kernel.org> wrote:
> >
> > On Thu, Jul 31, 2025 at 05:01:55PM GMT, Aaron Kling wrote:
> > > On Thu, Jul 31, 2025 at 4:59 PM Aaron Kling via B4 Relay
> > > <devnull+webgeek1234.gmail.com@kernel.org> wrote:
> > > >
> > > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > > > ---
> > > > Changes in v7:
> > > > - Rebased on 6.16
> > > > - Updated mailing address list
> > > > - Link to v6: https://lore.kernel.org/r/20250507-pci-tegra-module-v6-0-5fe363eaa302@gmail.com
> > > >
> > > > Changes in v6:
> > > > - Remove unused debugfs cleanup function, as caught by kernel ci
> > > > - Link to v5: https://lore.kernel.org/r/20250505-pci-tegra-module-v5-0-827aaac998ba@gmail.com
> > > >
> > > > Changes in v5:
> > > > - Copy commit message exactly word for word on patch 1, as required by reviewer
> > > > - Delete remove callback in patch 3, per request
> > > > - Don't clean up debugfs, per request, which drops patch 4 entirely
> > > > - Link to v4: https://lore.kernel.org/r/20250505-pci-tegra-module-v4-0-088b552c4b1a@gmail.com
> > > >
> > > > Changes in v4:
> > > > - Updated commit messages for patches 1 and 2, per review
> > > > - Link to v3: https://lore.kernel.org/r/20250502-pci-tegra-module-v3-0-556a49732d70@gmail.com
> > > >
> > > > Changes in v3:
> > > > - Add patch to drop remove callback, per request
> > > > - Link to v2: https://lore.kernel.org/r/20250428-pci-tegra-module-v2-0-c11a4b912446@gmail.com
> > > >
> > > > Changes in v2:
> > > > - Add patch to export tegra_cpuidle_pcie_irqs_in_use as required when
> > > >   building pci-tegra as a module for arm
> > > > - Drop module exit to prevent module unloading, as requested
> > > > - Link to v1: https://lore.kernel.org/r/20250420-pci-tegra-module-v1-0-c0a1f831354a@gmail.com
> > > >
> > > > ---
> > > > Aaron Kling (3):
> > > >       irqdomain: Export irq_domain_free_irqs
> > > >       cpuidle: tegra: Export tegra_cpuidle_pcie_irqs_in_use
> > > >       PCI: tegra: Allow building as a module
> > > >
> > > >  drivers/cpuidle/cpuidle-tegra.c    |  1 +
> > > >  drivers/pci/controller/Kconfig     |  2 +-
> > > >  drivers/pci/controller/pci-tegra.c | 35 ++++-------------------------------
> > > >  kernel/irq/irqdomain.c             |  1 +
> > > >  4 files changed, 7 insertions(+), 32 deletions(-)
> > > > ---
> > > > base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
> > > > change-id: 20250313-pci-tegra-module-7cbd1c5e70af
> > > >
> > > > Best regards,
> > > > --
> > > > Aaron Kling <webgeek1234@gmail.com>
> > > >
> > > >
> > >
> > > Continuing the conversation from the last revision [0]. Is there any
> > > path forward for this series?
> > >
> >
> > Daniel, could you please look into the cpufreq patch?
>
> Another two weeks with no response to a review request. And over two
> months total since the cpuidle maintainers were initially asked to
> look. Is there a policy for dealing with lack of responses?

Another month with no response. Can something be done with this,
please? If the subsystem maintainers don't respond, can they be
overridden by anyone? Who would the next step up even be? Does it go
directly from subsystem maintainers to Torvalds himself?

Aaron
Bjorn Helgaas Dec. 9, 2025, 6:40 p.m. UTC | #5
On Thu, Jul 31, 2025 at 04:59:23PM -0500, Aaron Kling via B4 Relay wrote:
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> Changes in v7:
> - Rebased on 6.16
> - Updated mailing address list
> - Link to v6: https://lore.kernel.org/r/20250507-pci-tegra-module-v6-0-5fe363eaa302@gmail.com
> 
> Changes in v6:
> - Remove unused debugfs cleanup function, as caught by kernel ci
> - Link to v5: https://lore.kernel.org/r/20250505-pci-tegra-module-v5-0-827aaac998ba@gmail.com
> 
> Changes in v5:
> - Copy commit message exactly word for word on patch 1, as required by reviewer
> - Delete remove callback in patch 3, per request
> - Don't clean up debugfs, per request, which drops patch 4 entirely
> - Link to v4: https://lore.kernel.org/r/20250505-pci-tegra-module-v4-0-088b552c4b1a@gmail.com
> 
> Changes in v4:
> - Updated commit messages for patches 1 and 2, per review
> - Link to v3: https://lore.kernel.org/r/20250502-pci-tegra-module-v3-0-556a49732d70@gmail.com
> 
> Changes in v3:
> - Add patch to drop remove callback, per request
> - Link to v2: https://lore.kernel.org/r/20250428-pci-tegra-module-v2-0-c11a4b912446@gmail.com
> 
> Changes in v2:
> - Add patch to export tegra_cpuidle_pcie_irqs_in_use as required when
>   building pci-tegra as a module for arm
> - Drop module exit to prevent module unloading, as requested
> - Link to v1: https://lore.kernel.org/r/20250420-pci-tegra-module-v1-0-c0a1f831354a@gmail.com
> 
> ---
> Aaron Kling (3):
>       irqdomain: Export irq_domain_free_irqs
>       cpuidle: tegra: Export tegra_cpuidle_pcie_irqs_in_use
>       PCI: tegra: Allow building as a module
> 
>  drivers/cpuidle/cpuidle-tegra.c    |  1 +
>  drivers/pci/controller/Kconfig     |  2 +-
>  drivers/pci/controller/pci-tegra.c | 35 ++++-------------------------------
>  kernel/irq/irqdomain.c             |  1 +
>  4 files changed, 7 insertions(+), 32 deletions(-)

Tidied commit logs per previous reviews and applied to
pci/controller/tegra for v6.20, thanks.

This branch will be rebased after v6.19-rc1.