From patchwork Sat Mar 30 04:19:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 1918027 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=CXjlqujS; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:40f1:3f00::1; helo=sy.mirrors.kernel.org; envelope-from=linux-pci+bounces-5432-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V63vc4Sd4z23sl for ; Sat, 30 Mar 2024 15:19:40 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8ACA4B22290 for ; Sat, 30 Mar 2024 04:19:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 31DF88BFD; Sat, 30 Mar 2024 04:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CXjlqujS" X-Original-To: linux-pci@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 557458827; Sat, 30 Mar 2024 04:19:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711772373; cv=none; b=SYTBTsBk4CEwYulLJ6Q/qdjiSAQS5jWRyq0DxDu+bTUn0I0ejq/kVjQFaU+DMjMFtp8+XkG52RbBGIxhcKcK2QO2/asfCSTUy2bVTYznDDR91R4MQr6qLsaa/WMt0vmJmFA+vr9hih/n67osWkEw8ZxH/9Atf5cxL/qJsv9+AmY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711772373; c=relaxed/simple; bh=yqcpDQ7Oi9nakTIZQuqI0KjlBKYztEHhTCBVRdVKIB8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RcOlXW4Wq0qo+wOc+yn+AjIbmT2sO296/b6/vJrqX+mN2memcPCe/4mKIbRloIDl4h6+iLV23aI2Msf7/RH3/rUCzfv54hCctkOQcabX70R+qjt3nZS7sloKP3xWwkrWdR6NdJ1iWIpWP1qGTKIORYG1KnVVwg1mRLYd38yEQRI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CXjlqujS; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D786C433F1; Sat, 30 Mar 2024 04:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711772372; bh=yqcpDQ7Oi9nakTIZQuqI0KjlBKYztEHhTCBVRdVKIB8=; h=From:To:Cc:Subject:Date:From; b=CXjlqujSZFqUQeRyZD/h2KYRCvGo4Y4mk9Ja5F7MQHQfcTDcqRLu9LmiqyXCVlDsd tG6FLkQol6Q+rrNk4ttvVK+1z9Wum1e5H/GUwVzc9AM9yMwc6OaLs/zoH6UHiXxrll NdGXTsHyHPZbX5KzEZWNxfJ2u9ZWn1bd7rrluVx5W+6BoChSOWtIVD5LsU9Z8vflNM ZhI0C0it2hpPuV40whGQJ6G7m9yXKVgc0bajFrqyWpZkqATMSAzsa/019BZcJUwe3i tON8zV+F8XhCZJzmw2qoV0gqZ5yj3/UCy4gaS7D7haQrvPupBNWZl3GKON20G4sCMi zcdGqBFDUa00g== From: Damien Le Moal To: Manivannan Sadhasivam , Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel Subject: [PATCH v2 00/18] Improve PCI memory mapping API Date: Sat, 30 Mar 2024 13:19:10 +0900 Message-ID: <20240330041928.1555578-1-dlemoal@kernel.org> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This series introduces the new functions pci_epc_map_align(), pci_epc_mem_map() and pci_epc_mem_unmap() to improve handling of the PCI address mapping alignment constraints of endpoint controllers in a controller independent manner. The issue fixed is that the fixed alignment defined by the "align" field of struct pci_epc_features assumes that the alignment of the endpoint memory used to map a RC PCI address range is independent of the PCI address being mapped. But that is not the case for the rk3399 SoC controller: in endpoint mode, this controller uses the lower bits of the local endpoint memory address as the lower bits for the PCI addresses for data transfers. That is, when mapping local memory, one must take into account the number of bits of the RC PCI address that change from the start address of the mapping. To fix this, the new endpoint controller method .map_align is introduced and called from pci_epc_map_align(). This method is optional and for controllers that do not define it, the mapping information returned is based of the fixed alignment constraint as defined by the align feature. The functions pci_epc_mem_map() is a helper function which obtains mapping information, allocates endpoint controller memory according to the mapping size obtained and maps the memory. pci_epc_mem_map() unmaps and frees the endpoint memory. This series is organized as follows: - Patch 1 tidy up the epc core code - Patch 2 and 3 introduce the new map_align endpoint controller method and related epc functions. - Patch 4 to 6 modify the test endpoint driver to use these new functions and improve the code of this driver. - Finally, Patch 7 to 18 fix the rk3399 endpoint driver, defining a .map_align method for it and improving its overall code readability and features. Changes from v1: - Changed pci_epc_check_func() to pci_epc_function_is_valid() in patch 1. - Removed patch "PCI: endpoint: Improve pci_epc_mem_alloc_addr()" (former patch 2 of v1) - Various typos cleanups all over. Also fixed some blank space indentation. - Added review tags Damien Le Moal (17): PCI: endpoint: Introduce pci_epc_function_is_valid() PCI: endpoint: Introduce pci_epc_map_align() PCI: endpoint: Introduce pci_epc_mem_map()/unmap() PCI: endpoint: test: Use pci_epc_mem_map/unmap() PCI: endpoint: test: Synchronously cancel command handler work PCI: endpoint: test: Implement link_down event operation PCI: rockchip-ep: Fix address translation unit programming PCI: rockchip-ep: Use a macro to define EP controller .align feature PCI: rockchip-ep: Improve rockchip_pcie_ep_unmap_addr() PCI: rockchip-ep: Improve rockchip_pcie_ep_map_addr() PCI: rockchip-ep: Implement the map_align endpoint controller operation PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() memory allocations PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() MSI-X hiding PCI: rockchip-ep: Refactor endpoint link training enable PCI: rockship-ep: Introduce rockchip_pcie_ep_stop() PCI: rockchip-ep: Improve link training PCI: rockchip-ep: Handle PERST# signal in endpoint mode Wilfred Mallawa (1): dt-bindings: pci: rockchip,rk3399-pcie-ep: Add ep-gpios property .../bindings/pci/rockchip,rk3399-pcie-ep.yaml | 3 + drivers/pci/controller/pcie-rockchip-ep.c | 393 ++++++++++++++---- drivers/pci/controller/pcie-rockchip.c | 17 +- drivers/pci/controller/pcie-rockchip.h | 22 + drivers/pci/endpoint/functions/pci-epf-test.c | 390 +++++++++-------- drivers/pci/endpoint/pci-epc-core.c | 213 +++++++--- include/linux/pci-epc.h | 39 ++ 7 files changed, 768 insertions(+), 309 deletions(-)