mbox series

[0/3] dt-bindings: PCI: qcom: move to dedicated schema (part two)

Message ID 20240205-dt-bindings-pci-qcom-split-continued-v1-0-c333cab5eeea@linaro.org
Headers show
Series dt-bindings: PCI: qcom: move to dedicated schema (part two) | expand

Message

Krzysztof Kozlowski Feb. 5, 2024, 3:58 p.m. UTC
Hi,

Please take this patchset and its dependency via PCI tree.

Dependency
==========
This depends on:
https://lore.kernel.org/all/20240126-dt-bindings-pci-qcom-split-v3-0-f23cda4d74c0@linaro.org/

DTS fixes for interrupts will be send separately.

Description
===========
The qcom,pcie.yaml containing all devices results in huge allOf: section
with a lot of if:then: clauses making review and changes quite
difficult.

Split individual devices into their own files, so we get rid of
multiple if:then: clauses.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (3):
      dt-bindings: PCI: qcom,pcie-sc8180x: move SC8180X to dedicated schema
      dt-bindings: PCI: qcom,pcie-sc7280: move SC7280 to dedicated schema
      dt-bindings: PCI: qcom,pcie-sa8775p: move SA8775p to dedicated schema

 .../devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 166 ++++++++++++++++++++
 .../devicetree/bindings/pci/qcom,pcie-sc7280.yaml  | 166 ++++++++++++++++++++
 .../devicetree/bindings/pci/qcom,pcie-sc8180x.yaml | 170 +++++++++++++++++++++
 .../devicetree/bindings/pci/qcom,pcie.yaml         | 106 -------------
 4 files changed, 502 insertions(+), 106 deletions(-)
---
base-commit: 664c838cd04e72eed58c3ad260d3aa38bf208af2
change-id: 20240205-dt-bindings-pci-qcom-split-continued-09aa02776b7e

Best regards,

Comments

Rob Herring (Arm) Feb. 13, 2024, 3:01 p.m. UTC | #1
On Mon, Feb 05, 2024 at 04:58:00PM +0100, Krzysztof Kozlowski wrote:
> Hi,
> 
> Please take this patchset and its dependency via PCI tree.
> 
> Dependency
> ==========
> This depends on:
> https://lore.kernel.org/all/20240126-dt-bindings-pci-qcom-split-v3-0-f23cda4d74c0@linaro.org/
> 
> DTS fixes for interrupts will be send separately.
> 
> Description
> ===========
> The qcom,pcie.yaml containing all devices results in huge allOf: section
> with a lot of if:then: clauses making review and changes quite
> difficult.
> 
> Split individual devices into their own files, so we get rid of
> multiple if:then: clauses.

The downside to this is the resource names don't live next to each 
other. Then it is just a free-for-all on making up names with little 
attempt at alignment.

OTOH, I give up and your mess to maintain...

Acked-by: Rob Herring <robh@kernel.org>

Rob
Krzysztof WilczyƄski March 9, 2024, 4:28 p.m. UTC | #2
Hello,

> Please take this patchset and its dependency via PCI tree.
> 
> Dependency
> ==========
> This depends on:
> https://lore.kernel.org/all/20240126-dt-bindings-pci-qcom-split-v3-0-f23cda4d74c0@linaro.org/
> 
> DTS fixes for interrupts will be send separately.
> 
> Description
> ===========
> The qcom,pcie.yaml containing all devices results in huge allOf: section
> with a lot of if:then: clauses making review and changes quite
> difficult.
> 
> Split individual devices into their own files, so we get rid of
> multiple if:then: clauses.

Applied to qcom, thank you!

[01/03] dt-bindings: PCI: qcom,pcie-sc8180x: Move SC8180X to dedicated schema
        https://git.kernel.org/pci/pci/c/d5e74915cb23
[02/03] dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to dedicated schema
        https://git.kernel.org/pci/pci/c/756485bfbb85
[03/03] dt-bindings: PCI: qcom,pcie-sa8775p: Move SA8775p to dedicated schema
        https://git.kernel.org/pci/pci/c/544e8f96efc0

	Krzysztof