| Message ID | 20230703135255.2202721-1-schnelle@linux.ibm.com |
|---|---|
| Headers | show |
| Series | PCI: Handle HAS_IOPORT dependencies | expand |
On Mon, Jul 03, 2023 at 03:52:53PM +0200, Niklas Schnelle wrote: > Hi Bjorn, > > This is a follow up to my ongoing effort of making the inb()/outb() and > similar I/O port accessors compile-time optional. Previously I sent this as > a complete treewide series titled "treewide: Remove I/O port accessors for > HAS_IOPORT=n" with the latest being its 5th version[0]. Now about half of > the per-subsystem patches have been merged so I'm changing over to stand > alone subsystem patches. These series are stand alone and should be merged > via the relevant tree such that with all subsystems complete we can follow > this up with the last patch[1] that will make the I/O port accessors > compile-time optional. Is the merge plan for each subsystem to merge this separately? I acked these so they could be merged along with all the tree-wide changes. > As for compile-time vs runtime see Linus' reply to my first attempt[2]. > > Other than rebasing on current master there are no changes to these > two patches for the PCI subsystem. > > Thanks, > Niklas > > [0] https://lore.kernel.org/all/20230516110038.2413224-1-schnelle@linux.ibm.com/ > [1] https://lore.kernel.org/all/20230516110038.2413224-42-schnelle@linux.ibm.com/ > [2] https://lore.kernel.org/lkml/CAHk-=wg80je=K7madF4e7WrRNp37e3qh6y10Svhdc7O8SZ_-8g@mail.gmail.com/ > > Niklas Schnelle (2): > PCI: Make quirk using inw() depend on HAS_IOPORT > PCI/sysfs: Make I/O resource depend on HAS_IOPORT > > drivers/pci/pci-sysfs.c | 4 ++++ > drivers/pci/quirks.c | 2 ++ > 2 files changed, 6 insertions(+) > > > base-commit: a901a3568fd26ca9c4a82d8bc5ed5b3ed844d451 > -- > 2.39.2 >
On Mon, 2023-07-03 at 12:42 -0500, Bjorn Helgaas wrote: > On Mon, Jul 03, 2023 at 03:52:53PM +0200, Niklas Schnelle wrote: > > Hi Bjorn, > > > > This is a follow up to my ongoing effort of making the inb()/outb() and > > similar I/O port accessors compile-time optional. Previously I sent this as > > a complete treewide series titled "treewide: Remove I/O port accessors for > > HAS_IOPORT=n" with the latest being its 5th version[0]. Now about half of > > the per-subsystem patches have been merged so I'm changing over to stand > > alone subsystem patches. These series are stand alone and should be merged > > via the relevant tree such that with all subsystems complete we can follow > > this up with the last patch[1] that will make the I/O port accessors > > compile-time optional. > > Is the merge plan for each subsystem to merge this separately? I > acked these so they could be merged along with all the tree-wide > changes. Hi Björn, Yeah this went back and forth a little, sorry about that. With the Kconfig introduction of HAS_IOPORT merged about half of the original patches have been merged via subsystem maintainers or are at least sitting in linux-next already. Arnd was anticipating that he'll pick up some left overs but at the moment the simplest is for subsystems to pick the patches up themselves ideally and if small enough for v6.5 still. Thanks, Niklas > > > As for compile-time vs runtime see Linus' reply to my first attempt[2]. > > > > Other than rebasing on current master there are no changes to these > > two patches for the PCI subsystem. > > > > Thanks, > > Niklas > > > > [0] https://lore.kernel.org/all/20230516110038.2413224-1-schnelle@linux.ibm.com/ > > [1] https://lore.kernel.org/all/20230516110038.2413224-42-schnelle@linux.ibm.com/ > > [2] https://lore.kernel.org/lkml/CAHk-=wg80je=K7madF4e7WrRNp37e3qh6y10Svhdc7O8SZ_-8g@mail.gmail.com/ > > > > Niklas Schnelle (2): > > PCI: Make quirk using inw() depend on HAS_IOPORT > > PCI/sysfs: Make I/O resource depend on HAS_IOPORT > > > > drivers/pci/pci-sysfs.c | 4 ++++ > > drivers/pci/quirks.c | 2 ++ > > 2 files changed, 6 insertions(+) > > > > > > base-commit: a901a3568fd26ca9c4a82d8bc5ed5b3ed844d451 > > -- > > 2.39.2 > >
On Mon, Jul 03, 2023 at 08:02:40PM +0200, Niklas Schnelle wrote: > On Mon, 2023-07-03 at 12:42 -0500, Bjorn Helgaas wrote: > > On Mon, Jul 03, 2023 at 03:52:53PM +0200, Niklas Schnelle wrote: > > > Hi Bjorn, > > > > > > This is a follow up to my ongoing effort of making the inb()/outb() and > > > similar I/O port accessors compile-time optional. Previously I sent this as > > > a complete treewide series titled "treewide: Remove I/O port accessors for > > > HAS_IOPORT=n" with the latest being its 5th version[0]. Now about half of > > > the per-subsystem patches have been merged so I'm changing over to stand > > > alone subsystem patches. These series are stand alone and should be merged > > > via the relevant tree such that with all subsystems complete we can follow > > > this up with the last patch[1] that will make the I/O port accessors > > > compile-time optional. > > > > Is the merge plan for each subsystem to merge this separately? I > > acked these so they could be merged along with all the tree-wide > > changes. > > Hi Björn, > > Yeah this went back and forth a little, sorry about that. With the > Kconfig introduction of HAS_IOPORT merged about half of the original > patches have been merged via subsystem maintainers or are at least > sitting in linux-next already. Arnd was anticipating that he'll pick > up some left overs but at the moment the simplest is for subsystems to > pick the patches up themselves ideally and if small enough for v6.5 > still. I didn't merge these in time for the v6.5 merge window. If you want these in v6.5, it's fine with me, and it would probably make more sense for you to bundle them with any other leftovers. Otherwise, let me know and I'm happy to queue them for v6.6. Bjorn
On Tue, Jul 18, 2023 at 04:12:24PM -0500, Bjorn Helgaas wrote: > On Mon, Jul 03, 2023 at 08:02:40PM +0200, Niklas Schnelle wrote: > > On Mon, 2023-07-03 at 12:42 -0500, Bjorn Helgaas wrote: > > > On Mon, Jul 03, 2023 at 03:52:53PM +0200, Niklas Schnelle wrote: > > > > Hi Bjorn, > > > > > > > > This is a follow up to my ongoing effort of making the inb()/outb() and > > > > similar I/O port accessors compile-time optional. Previously I sent this as > > > > a complete treewide series titled "treewide: Remove I/O port accessors for > > > > HAS_IOPORT=n" with the latest being its 5th version[0]. Now about half of > > > > the per-subsystem patches have been merged so I'm changing over to stand > > > > alone subsystem patches. These series are stand alone and should be merged > > > > via the relevant tree such that with all subsystems complete we can follow > > > > this up with the last patch[1] that will make the I/O port accessors > > > > compile-time optional. > > > > > > Is the merge plan for each subsystem to merge this separately? I > > > acked these so they could be merged along with all the tree-wide > > > changes. > > > > Hi Björn, > > > > Yeah this went back and forth a little, sorry about that. With the > > Kconfig introduction of HAS_IOPORT merged about half of the original > > patches have been merged via subsystem maintainers or are at least > > sitting in linux-next already. Arnd was anticipating that he'll pick > > up some left overs but at the moment the simplest is for subsystems to > > pick the patches up themselves ideally and if small enough for v6.5 > > still. > > I didn't merge these in time for the v6.5 merge window. If you want > these in v6.5, it's fine with me, and it would probably make more > sense for you to bundle them with any other leftovers. > > Otherwise, let me know and I'm happy to queue them for v6.6. I provisionally put these on pci/ioport for v6.6. If you pick them up for v6.5, let me know and I'll just drop that branch. Bjorn