mbox series

[0/5] drm: use core pcie functionality for pcie gen/width

Message ID 20180625210606.2736-1-alexander.deucher@amd.com
Headers show
Series drm: use core pcie functionality for pcie gen/width | expand

Message

Alex Deucher June 25, 2018, 9:06 p.m. UTC
This series exports some pcie helper functions for use by drivers and
fixes up the amdgpu and radeon drivers to use this core functionality
rather than the duplicated functionality in the drm.  Finally we remove
the drm helpers since the duplicate the pcie functionality of the core.
This also adds proper pcie gen4 detection for amdgpu.

Alex Deucher (5):
  pci: export pcie_get_speed_cap and pcie_get_width_cap
  drm/amdgpu: update amd_pcie.h to include gen4 speeds
  drm/amdgpu: use pcie functions for link width and speed
  drm/radeon: use pcie functions for link width
  drm: drop drm_pcie_get_speed_cap_mask and drm_pcie_get_max_link_width

 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 83 +++++++++++++++++++++---------
 drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c    |  7 ++-
 drivers/gpu/drm/amd/amdgpu/ci_dpm.c        |  3 +-
 drivers/gpu/drm/amd/amdgpu/si_dpm.c        |  3 +-
 drivers/gpu/drm/amd/include/amd_pcie.h     |  2 +
 drivers/gpu/drm/drm_pci.c                  | 58 ---------------------
 drivers/gpu/drm/radeon/ci_dpm.c            | 20 +++++--
 drivers/gpu/drm/radeon/cik.c               | 22 ++++----
 drivers/gpu/drm/radeon/r600_dpm.c          |  4 +-
 drivers/gpu/drm/radeon/radeon.h            |  4 ++
 drivers/gpu/drm/radeon/si.c                | 22 ++++----
 drivers/gpu/drm/radeon/si_dpm.c            | 20 +++++--
 drivers/pci/pci.c                          |  2 +
 include/drm/drm_pci.h                      |  7 ---
 include/linux/pci.h                        |  3 ++
 15 files changed, 132 insertions(+), 128 deletions(-)

Comments

Alex Deucher June 29, 2018, 2:59 p.m. UTC | #1
Ping on the drm and amdgpu patches.

Alex

On Mon, Jun 25, 2018 at 5:06 PM, Alex Deucher <alexdeucher@gmail.com> wrote:
> This series exports some pcie helper functions for use by drivers and
> fixes up the amdgpu and radeon drivers to use this core functionality
> rather than the duplicated functionality in the drm.  Finally we remove
> the drm helpers since the duplicate the pcie functionality of the core.
> This also adds proper pcie gen4 detection for amdgpu.
>
> Alex Deucher (5):
>   pci: export pcie_get_speed_cap and pcie_get_width_cap
>   drm/amdgpu: update amd_pcie.h to include gen4 speeds
>   drm/amdgpu: use pcie functions for link width and speed
>   drm/radeon: use pcie functions for link width
>   drm: drop drm_pcie_get_speed_cap_mask and drm_pcie_get_max_link_width
>
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 83 +++++++++++++++++++++---------
>  drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c    |  7 ++-
>  drivers/gpu/drm/amd/amdgpu/ci_dpm.c        |  3 +-
>  drivers/gpu/drm/amd/amdgpu/si_dpm.c        |  3 +-
>  drivers/gpu/drm/amd/include/amd_pcie.h     |  2 +
>  drivers/gpu/drm/drm_pci.c                  | 58 ---------------------
>  drivers/gpu/drm/radeon/ci_dpm.c            | 20 +++++--
>  drivers/gpu/drm/radeon/cik.c               | 22 ++++----
>  drivers/gpu/drm/radeon/r600_dpm.c          |  4 +-
>  drivers/gpu/drm/radeon/radeon.h            |  4 ++
>  drivers/gpu/drm/radeon/si.c                | 22 ++++----
>  drivers/gpu/drm/radeon/si_dpm.c            | 20 +++++--
>  drivers/pci/pci.c                          |  2 +
>  include/drm/drm_pci.h                      |  7 ---
>  include/linux/pci.h                        |  3 ++
>  15 files changed, 132 insertions(+), 128 deletions(-)
>
> --
> 2.13.6
>
Christian König July 4, 2018, 8:38 a.m. UTC | #2
Whole series is Acked-by: Christian König <christian.koenig@amd.com>.

BTW: With patch #2 you created quite some noise in the news:

https://www.tomshardware.com/news/amd-vega-20-pcie-4.0,37389.html

Cheers,
Christian.

Am 25.06.2018 um 23:06 schrieb Alex Deucher:
> This series exports some pcie helper functions for use by drivers and
> fixes up the amdgpu and radeon drivers to use this core functionality
> rather than the duplicated functionality in the drm.  Finally we remove
> the drm helpers since the duplicate the pcie functionality of the core.
> This also adds proper pcie gen4 detection for amdgpu.
>
> Alex Deucher (5):
>    pci: export pcie_get_speed_cap and pcie_get_width_cap
>    drm/amdgpu: update amd_pcie.h to include gen4 speeds
>    drm/amdgpu: use pcie functions for link width and speed
>    drm/radeon: use pcie functions for link width
>    drm: drop drm_pcie_get_speed_cap_mask and drm_pcie_get_max_link_width
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 83 +++++++++++++++++++++---------
>   drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c    |  7 ++-
>   drivers/gpu/drm/amd/amdgpu/ci_dpm.c        |  3 +-
>   drivers/gpu/drm/amd/amdgpu/si_dpm.c        |  3 +-
>   drivers/gpu/drm/amd/include/amd_pcie.h     |  2 +
>   drivers/gpu/drm/drm_pci.c                  | 58 ---------------------
>   drivers/gpu/drm/radeon/ci_dpm.c            | 20 +++++--
>   drivers/gpu/drm/radeon/cik.c               | 22 ++++----
>   drivers/gpu/drm/radeon/r600_dpm.c          |  4 +-
>   drivers/gpu/drm/radeon/radeon.h            |  4 ++
>   drivers/gpu/drm/radeon/si.c                | 22 ++++----
>   drivers/gpu/drm/radeon/si_dpm.c            | 20 +++++--
>   drivers/pci/pci.c                          |  2 +
>   include/drm/drm_pci.h                      |  7 ---
>   include/linux/pci.h                        |  3 ++
>   15 files changed, 132 insertions(+), 128 deletions(-)
>