| Message ID | f8a10a00-c3e4-9749-789d-39fba7944646@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | Fixes for Rockchip NAND controller driver | expand |
Hi Johan, jbx6244@gmail.com wrote on Thu, 8 Jun 2023 18:30:40 +0200: > Somehow not all NAND chips give a valid timing setting with the > nand_get_sdr_timings() function. nand_get_sdr_timings() is a core function and is not particularly clever. All chips are supposed to support SDR mode 0 so if you chip does not advertises that the chip is broken, not the controller. This must be fixed in the chip manufacturer driver, not in the controller driver. > Don't consider it as an error, > but fall back to the default value in order to continue to use > the driver. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > drivers/mtd/nand/raw/rockchip-nand-controller.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c > index f56430f6c..e39431cfa 100644 > --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c > +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c > @@ -429,8 +429,10 @@ static int rk_nfc_setup_interface(struct nand_chip *chip, int target, > return 0; > > timings = nand_get_sdr_timings(conf); > - if (IS_ERR(timings)) > - return -EOPNOTSUPP; > + if (IS_ERR(timings)) { > + rknand->timing = 0x1081; This is way to magical anyway :) > + return 0; > + } > > if (IS_ERR(nfc->nfc_clk)) > rate = clk_get_rate(nfc->ahb_clk); > -- > 2.30.2 > Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c index f56430f6c..e39431cfa 100644 --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c @@ -429,8 +429,10 @@ static int rk_nfc_setup_interface(struct nand_chip *chip, int target, return 0; timings = nand_get_sdr_timings(conf); - if (IS_ERR(timings)) - return -EOPNOTSUPP; + if (IS_ERR(timings)) { + rknand->timing = 0x1081; + return 0; + } if (IS_ERR(nfc->nfc_clk)) rate = clk_get_rate(nfc->ahb_clk);
Somehow not all NAND chips give a valid timing setting with the nand_get_sdr_timings() function. Don't consider it as an error, but fall back to the default value in order to continue to use the driver. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- drivers/mtd/nand/raw/rockchip-nand-controller.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.30.2