From patchwork Sat Jan 6 15:09:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 856386 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IFgs1Pvf"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zDQ2F1WtFz9s7G for ; Sun, 7 Jan 2018 02:10:13 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dSqK3g8IV5YzzuDoxGg7l866sVEwo82xHM4diPWX1qo=; b=IFgs1Pvf9vFuTo wLmJgxKvMMXASJYPsjq1oC19iBejTInaONWor0Hs0BPqLMEAuPr77zLoJGcpOlYchkYuZ0XL1vXjQ W5QAs1hb++S+vpsBs+Z7/OD8MmnFlzpM38GIyCZggOYEhpWWbyfR8ws5IiTapTLurpNPyV1NaxIto IO0BvrEuo3ctev4jLZZ2HZSCHlFqNALoPGzD+19C3N8KgQerqBtBHc16GvSXzZQwot2BgDCXK70TO rbyFCsJWMWvM6YrYb/p9o1hCIDNJYl3w7YcW6BGuRkfA+rbdEQdEoSjek91sEqNickcpnkT3F5/GU wHrkeEvIyhlyQNqxH2Mg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eXq6q-0000bG-FB; Sat, 06 Jan 2018 15:10:08 +0000 Received: from mout.web.de ([212.227.15.3]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eXq6m-0008UW-C1 for linux-mtd@lists.infradead.org; Sat, 06 Jan 2018 15:10:06 +0000 Received: from [192.168.1.3] ([85.182.74.56]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MYI9h-1eKpY01HoP-00V88G; Sat, 06 Jan 2018 16:09:45 +0100 Subject: [PATCH 3/5] mtd/rfd_ftl: Improve a size determination in two functions From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger References: Message-ID: Date: Sat, 6 Jan 2018 16:09:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:IFPaM2ed2dhTUg/E18Z9/YC1arrVRLM4gnHftg5WwuRS/oziwfo BPDXNnOabiWIzHO0FFWxLEk1GkQAJ6pjA+qOHdpXWCituwxgIdUhOKF6jCkMeMl7f6W3Y8z 3097kEXAo/cLMAJgjszx3g3syFfvzEpmdLRUL5TNs1bDfTU7M9k8fjCLEMzUvwodYf/cqNI VZOy1dDCcfCy+KesRMPgQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:lNVXpI88+50=:hcmSZa3knntMF+tewTaCbi 4Ps8Nz0R94e8FFpyMDDVPXQpuGFPZOySBsCLVh+02f+5fWxaXan21Qna3cs0Ew730k8jSvi3G G0yDieUkNZ7DHKcf/ssF6HeSMLJwrX0MFPxl8yDpb4+jUl98+5t7NbfgFHxSOewKsY/PoiMS9 docGcaVowXmWcM1GiLu7CtcRpa5O2XxCeht1EC9blHWtDGwfPkoMtHEaBCo1h0AFTNlYobjs4 8WMBpFGtERHmEyxqr7F6m4yTS70gIREo901uJeAUmAd+nrUt5Lf5poJuTUXzKCyO36n5MiGq1 dvFiaCqoaPzI+tFEnwgWvbUQ8tRFJXgIiCrAez0hN21Bf576y9a0QszOcBLGlf5GGqTVQQwps LXmJJ8537/nAboUZbfPdogMlMR0gbXaMyVkxa7GsQf8Z2jXLqS2lmFbho+jimyLFt1s3HO3Hz aDJKDO61ZsqWySxgTvjuN8GVGXcbMwD0kkAaazF0iJlDd39A4rs/IzOFB+084Sl6Xl6lit9/f INDSB7k1WKEMi/wN5OSgBsMpT+za9Y3SCYigyH9CmBwa5XERMl2nMZ/hgwmB3FKfLFMtcYehr Jkh3ipdPt9PIGU6ZRXWW3jGxQUslR8ohgQxu2SYRYZwH3S1ji/v+7z7mkUK6SkZqnmy7HErHQ UpIVBlrJt7q5+I9bUYsKlDgxmOkBnHru93xLOi/T+svhYDCuGAh5s32venP0JVYSRzXOWDMp8 /nvBrOdoJhNazuWZ6Y5lzmL3SWi87WxBRgNhs72JYxb9P7DWCUQJC+AUIya9LU/mf/UWez1U9 UPNrrE9YUSNZePLdnpgb4Zm/q6wqpZHtUPRvlycivMAbGaVjw0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180106_071004_881948_605B4AF3 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.227.15.3 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.3 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Markus Elfring Date: Sat, 6 Jan 2018 15:03:29 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/mtd/rfd_ftl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c index 19e14f909dc6..dcf1b88e1193 100644 --- a/drivers/mtd/rfd_ftl.c +++ b/drivers/mtd/rfd_ftl.c @@ -323,10 +323,9 @@ static void erase_callback(struct erase_info *erase) static int erase_block(struct partition *part, int block) { - struct erase_info *erase; int rc = -ENOMEM; + struct erase_info *erase = kmalloc(sizeof(*erase), GFP_KERNEL); - erase = kmalloc(sizeof(struct erase_info), GFP_KERNEL); if (!erase) goto err; @@ -759,7 +758,7 @@ static void rfd_ftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) if (mtd->type != MTD_NORFLASH || mtd->size > UINT_MAX) return; - part = kzalloc(sizeof(struct partition), GFP_KERNEL); + part = kzalloc(sizeof(*part), GFP_KERNEL); if (!part) return;