| Message ID | YMyir961W28TX5dT@mwanda |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mtd: mchp48l640: silence some uninitialized variable warnings | expand |
Hello Dan, On 18.06.21 15:42, Dan Carpenter wrote: > Smatch complains that zero length read/writes will lead to an > uninitalized return value. I don't know if that's possible, but > it's nicer to return a zero literal anyway so let's do that. > > Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > People, when we add a new driver can we make sure the first commit uses > the new prefered subsystem prefix? For example, > > "mtd: mchp48l640: add support for microchip 48l640 EERAM" > ^^^^^^^^^^ > Otherwise it's not clear to me what I should use as a patch prefix. Ok, sorry... Hmm... Colin already sent a fix for this, see: https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html bye, Heiko
On Sat, Jun 19, 2021 at 3:23 AM Heiko Schocher <hs@denx.de> wrote: > > Hello Dan, > > On 18.06.21 15:42, Dan Carpenter wrote: > > Smatch complains that zero length read/writes will lead to an > > uninitalized return value. I don't know if that's possible, but > > it's nicer to return a zero literal anyway so let's do that. > > > > Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > --- > > People, when we add a new driver can we make sure the first commit uses > > the new prefered subsystem prefix? For example, > > > > "mtd: mchp48l640: add support for microchip 48l640 EERAM" > > ^^^^^^^^^^ > > Otherwise it's not clear to me what I should use as a patch prefix. > > Ok, sorry... > > Hmm... Colin already sent a fix for this, see: > > https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html Yes, both patches work, but I think Dan's solution is a bit clearer, so: Reviewed-by: Fabio Estevam <festevam@gmail.com> Thanks
On 22/06/2021 16:31, Fabio Estevam wrote: > On Sat, Jun 19, 2021 at 3:23 AM Heiko Schocher <hs@denx.de> wrote: >> >> Hello Dan, >> >> On 18.06.21 15:42, Dan Carpenter wrote: >>> Smatch complains that zero length read/writes will lead to an >>> uninitalized return value. I don't know if that's possible, but >>> it's nicer to return a zero literal anyway so let's do that. >>> >>> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM") >>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >>> --- >>> People, when we add a new driver can we make sure the first commit uses >>> the new prefered subsystem prefix? For example, >>> >>> "mtd: mchp48l640: add support for microchip 48l640 EERAM" >>> ^^^^^^^^^^ >>> Otherwise it's not clear to me what I should use as a patch prefix. >> >> Ok, sorry... >> >> Hmm... Colin already sent a fix for this, see: >> >> https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html > > Yes, both patches work, but I think Dan's solution is a bit clearer, so: > > Reviewed-by: Fabio Estevam <festevam@gmail.com> > > Thanks > Yep, I'm good with that.
Hello Colin, Dan, On 22.06.21 17:39, Colin Ian King wrote: > On 22/06/2021 16:31, Fabio Estevam wrote: >> On Sat, Jun 19, 2021 at 3:23 AM Heiko Schocher <hs@denx.de> wrote: >>> >>> Hello Dan, >>> >>> On 18.06.21 15:42, Dan Carpenter wrote: >>>> Smatch complains that zero length read/writes will lead to an >>>> uninitalized return value. I don't know if that's possible, but >>>> it's nicer to return a zero literal anyway so let's do that. >>>> >>>> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM") >>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >>>> --- >>>> People, when we add a new driver can we make sure the first commit uses >>>> the new prefered subsystem prefix? For example, >>>> >>>> "mtd: mchp48l640: add support for microchip 48l640 EERAM" >>>> ^^^^^^^^^^ >>>> Otherwise it's not clear to me what I should use as a patch prefix. >>> >>> Ok, sorry... >>> >>> Hmm... Colin already sent a fix for this, see: >>> >>> https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html >> >> Yes, both patches work, but I think Dan's solution is a bit clearer, so: >> >> Reviewed-by: Fabio Estevam <festevam@gmail.com> >> >> Thanks >> > Yep, I'm good with that. +1 Reviewed-by: Heiko Schocher <hs@denx.de> bye, Heiko
On Fri, 2021-06-18 at 13:42:07 UTC, Dan Carpenter wrote: > Smatch complains that zero length read/writes will lead to an > uninitalized return value. I don't know if that's possible, but > it's nicer to return a zero literal anyway so let's do that. > > Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Reviewed-by: Fabio Estevam <festevam@gmail.com> > Reviewed-by: Heiko Schocher <hs@denx.de> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks. Miquel
diff --git a/drivers/mtd/devices/mchp48l640.c b/drivers/mtd/devices/mchp48l640.c index efc2003bd13a..ad66b5aaf4e9 100644 --- a/drivers/mtd/devices/mchp48l640.c +++ b/drivers/mtd/devices/mchp48l640.c @@ -229,7 +229,7 @@ static int mchp48l640_write(struct mtd_info *mtd, loff_t to, size_t len, woff += ws; } - return ret; + return 0; } static int mchp48l640_read_page(struct mtd_info *mtd, loff_t from, size_t len, @@ -286,7 +286,7 @@ static int mchp48l640_read(struct mtd_info *mtd, loff_t from, size_t len, woff += ws; } - return ret; + return 0; }; static const struct mchp48_caps mchp48l640_caps = {
Smatch complains that zero length read/writes will lead to an uninitalized return value. I don't know if that's possible, but it's nicer to return a zero literal anyway so let's do that. Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- People, when we add a new driver can we make sure the first commit uses the new prefered subsystem prefix? For example, "mtd: mchp48l640: add support for microchip 48l640 EERAM" ^^^^^^^^^^ Otherwise it's not clear to me what I should use as a patch prefix. drivers/mtd/devices/mchp48l640.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)