| Message ID | E1qYlA3-006vGH-1L@formenos.hmeau.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Do not include crypto/algapi.h | expand |
Hello, On 23/08/2023 12:32, Herbert Xu wrote: > The header file crypto/algapi.h is for internal use only. Use the > header file crypto/utils.h instead. Thank you for the patch! It looks good to me: Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net> I understood that other patches will come later to make it clear crypto/algapi.h is for internal use only so that's good! > diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c > index 9ee3b7abbaf6..64bb200099dc 100644 > --- a/net/mptcp/subflow.c > +++ b/net/mptcp/subflow.c > @@ -9,8 +9,8 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/netdevice.h> > -#include <crypto/algapi.h> > #include <crypto/sha2.h> > +#include <crypto/utils.h> It is fine for me if you carry this patch in your tree: this part here has not changed for a while and there is no ongoing work going to modify it. So there should not be any conflicts when merging the different trees later. Cheers, Matt
diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 9ee3b7abbaf6..64bb200099dc 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -9,8 +9,8 @@ #include <linux/kernel.h> #include <linux/module.h> #include <linux/netdevice.h> -#include <crypto/algapi.h> #include <crypto/sha2.h> +#include <crypto/utils.h> #include <net/sock.h> #include <net/inet_common.h> #include <net/inet_hashtables.h>
The header file crypto/algapi.h is for internal use only. Use the header file crypto/utils.h instead. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> --- net/mptcp/subflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)