From patchwork Fri Mar 4 02:21:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Han Xu X-Patchwork-Id: 591726 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A44A6140BA4 for ; Fri, 4 Mar 2016 13:23:16 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=aIH+WmUq; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1abfMy-0000X0-RQ; Fri, 04 Mar 2016 02:21:32 +0000 Received: from mail-ob0-x22e.google.com ([2607:f8b0:4003:c01::22e]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1abfMw-0000Sv-DQ for linux-mtd@lists.infradead.org; Fri, 04 Mar 2016 02:21:30 +0000 Received: by mail-ob0-x22e.google.com with SMTP id ts10so38577179obc.1 for ; Thu, 03 Mar 2016 18:21:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc; bh=RKy5jT2ODRGrykX6bmslk5XK5Nq3chTvLOYefTiYLao=; b=aIH+WmUqzMbp+L7J/7tnYKR1TfLxb6ShKj9XpsGbkxtK45lb9HNRHdEmY1y/hPEIgA Jmb77iKUB+mszAYido7Tqp30jtFTsEMLKB/o3efBZyXd9eJYGykVBzFwikuXuNlL4MBl NcAF50nJCJp+tUB8moPPOdIWSs4wBWVNh/gOVLJyc9+7v0jOXWFhyKISM6kWXGLKE6Th 1xHRAzZXUJAKcrzaT5PJZIHKVWlllSRfWQCGVemt1jla7OpPnUSzAKR9B+7/ZueqH7/m mzriRgUF44e/pK5gQg9hrupqq+KaHd6hrqYKqLMj2eW1bQ3tkETmAKV+SHklNl26Acg9 Gu8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc; bh=RKy5jT2ODRGrykX6bmslk5XK5Nq3chTvLOYefTiYLao=; b=LTRwm+VC5DsYqtGVgpeST2ucdN8zJ9FzbSHv4IHEc+5szbU2x5Q2qwdBHmonQIAiG0 QYKnsi5ytSKmX0vUQ3LKN+o+ausoXe8WITtuWpMQX9Gz8jT4vT2jCm/ciEi+uua2BpQA OeAg2WCcAUZtUfmNuRLOtlFjJQwi4YFrvnuiTCeAtxZn1i7Dmou3ATx6zA4lPrI7RMqj QlOWRO+HWJkk+TwEBfOi2d1637gD76gKzM83X0XoCMwAocFsMiNkbpcdn50FoC8cA+Ow kFOOtwuzaGoHcV18EZoI3/FXNAOiNxOTgQmv+/VYsxa306+x24a22/JjJozaxqOhbzVl gBRQ== X-Gm-Message-State: AD7BkJLcULlnec89srhyppG+Usi63cUz3D3yURcmTXKceqnEidkPd0udLI09hq3OgyVZk/ZYSVoXooHY/ho1qQ== MIME-Version: 1.0 X-Received: by 10.60.35.201 with SMTP id k9mr4521516oej.3.1457058069247; Thu, 03 Mar 2016 18:21:09 -0800 (PST) Received: by 10.60.18.165 with HTTP; Thu, 3 Mar 2016 18:21:09 -0800 (PST) Date: Thu, 3 Mar 2016 20:21:09 -0600 Message-ID: Subject: UBIFS Dump Stack on Android From: Han Xu To: Richard Weinberger X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160303_182130_536452_B83CBE98 X-CRM114-Status: UNSURE ( 6.53 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:4003:c01:0:0:0:22e listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (xhnjupt[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-mtd@lists.infradead.org" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Hi Richard, We found an issue on Kernel 4.1 when running Android on UBIFS. Android required to enable SELINUX and exposed the issue, one ubifs_assert() function failed and caused dump stack. UBIFS: Kill unneeded locking in ubifs_init_security We also noticed Google maintained Kernel 4.1 AOSP didn't cherry-pick the patch either. Could you please help to check this issue, Thanks. --- a/fs/ubifs/xattr.c +++ b/fs/ubifs/xattr.c @@ -309,7 +309,6 @@ static int setxattr(struct inode *host, const char *name, const void *value, union ubifs_key key; int err, type; ubifs_assert(mutex_is_locked(&host->i_mutex)); It may related to your recent code change