From patchwork Thu Nov 25 08:58:01 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ketil Froyn X-Patchwork-Id: 73036 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from canuck.infradead.org (canuck.infradead.org [134.117.69.58]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AED37B7043 for ; Thu, 25 Nov 2010 20:05:16 +1100 (EST) Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PLXeb-0007u3-Ml; Thu, 25 Nov 2010 08:58:09 +0000 Received: from mail-qw0-f49.google.com ([209.85.216.49]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PLXeV-0007tB-C6 for linux-mtd@lists.infradead.org; Thu, 25 Nov 2010 08:58:04 +0000 Received: by qwc9 with SMTP id 9so713149qwc.36 for ; Thu, 25 Nov 2010 00:58:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.221.69 with SMTP id ib5mr502017qcb.10.1290675481399; Thu, 25 Nov 2010 00:58:01 -0800 (PST) Received: by 10.229.237.15 with HTTP; Thu, 25 Nov 2010 00:58:01 -0800 (PST) In-Reply-To: References: <4CD11C03.3090207@parrot.com> <1289646433.2218.22.camel@localhost> <1289649338.2218.42.camel@localhost> <1290607959.2793.11.camel@localhost> Date: Thu, 25 Nov 2010 09:58:01 +0100 Message-ID: Subject: Re: Suggested patch: reset errno after isatty() From: Ketil Froyn To: Mike Frysinger X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20101125_035803_498775_A43AD72F X-CRM114-Status: GOOD ( 13.56 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.216.49 listed in list.dnswl.org] Cc: "linux-mtd@lists.infradead.org" , Matthieu CASTET , dedekind1@gmail.com X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Wed, Nov 24, 2010 at 10:36 PM, Mike Frysinger wrote: > > awesome.  can you post your signed-off-by tag and/or a proper git patch please ? > -mike I'm pretty new to git. Hope this is right. Cheers, Ketil From aea696a42d118598ca582180a89c7e5c0fe13b4e Mon Sep 17 00:00:00 2001 From: Ketil Froyn Date: Thu, 25 Nov 2010 09:52:12 +0100 Subject: [PATCH] mtd-utils: libmtd: legacy code OOB legacy_get_dev_info() forgot to set the OOB size Signed-off-by: Ketil Froyn --- lib/libmtd_legacy.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/libmtd_legacy.c b/lib/libmtd_legacy.c index 7488275..d6c3938 100644 --- a/lib/libmtd_legacy.c +++ b/lib/libmtd_legacy.c @@ -261,6 +261,7 @@ int legacy_get_dev_info(const char *node, struct mtd_dev_info *mtd) mtd->size = ui.size; mtd->eb_size = ui.erasesize; mtd->min_io_size = ui.writesize; + mtd->oob_size = ui.oobsize; if (mtd->min_io_size <= 0) { errmsg("mtd%d (%s) has insane min. I/O unit size %d", -- 1.7.0.4