diff mbox series

mtd: nand: drop kernel-doc notation for a deleted function parameter

Message ID 88c00c96-cfd2-4ff1-e753-8875501895df@infradead.org
State Accepted
Delegated to: Boris Brezillon
Headers show
Series mtd: nand: drop kernel-doc notation for a deleted function parameter | expand

Commit Message

Randy Dunlap Nov. 5, 2018, 2:38 a.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Remove kernel-doc notation for a deleted function parameter to prevent
a kernel-doc warning:

../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'

Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
---

 drivers/mtd/nand/raw/nand_base.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Miquel Raynal Nov. 5, 2018, 8:19 a.m. UTC | #1 
Hi Randy,

Subject prefix should be "mtd: rawnand:".

Randy Dunlap <rdunlap@infradead.org> wrote on Sun, 4 Nov 2018 18:38:35
-0800:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Remove kernel-doc notation for a deleted function parameter to prevent
> a kernel-doc warning:
> 
> ../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'
> 
> Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> ---

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl
Boris Brezillon Nov. 5, 2018, 10:58 p.m. UTC | #2 
On Sun, 4 Nov 2018 18:38:35 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Remove kernel-doc notation for a deleted function parameter to prevent
> a kernel-doc warning:
> 
> ../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'
> 
> Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>

Queued to the fixes branch.

Thanks,

Boris

> ---
> 
>  drivers/mtd/nand/raw/nand_base.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- lnx-420-rc1.orig/drivers/mtd/nand/raw/nand_base.c
> +++ lnx-420-rc1/drivers/mtd/nand/raw/nand_base.c
> @@ -590,7 +590,6 @@ retry:
>  
>  /**
>   * panic_nand_wait - [GENERIC] wait until the command is done
> - * @mtd: MTD device structure
>   * @chip: NAND chip structure
>   * @timeo: timeout
>   *
> 
>
diff mbox series

Patch

--- lnx-420-rc1.orig/drivers/mtd/nand/raw/nand_base.c
+++ lnx-420-rc1/drivers/mtd/nand/raw/nand_base.c
@@ -590,7 +590,6 @@  retry:
 
 /**
  * panic_nand_wait - [GENERIC] wait until the command is done
- * @mtd: MTD device structure
  * @chip: NAND chip structure
  * @timeo: timeout
  *