From patchwork Fri May 29 08:39:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 477640 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A0C15140E56 for ; Fri, 29 May 2015 18:43:19 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YyFq8-0005xM-Hs; Fri, 29 May 2015 08:40:28 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YyFpm-0004dH-PM; Fri, 29 May 2015 08:40:07 +0000 Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue104) with ESMTPSA (Nemesis) id 0M0ACi-1ZExlQ0i0S-00uJU2; Fri, 29 May 2015 10:39:32 +0200 From: Arnd Bergmann To: Brian Norris Subject: [PATCH] mtd: use cfi-util in jedecprobe Date: Fri, 29 May 2015 10:39:28 +0200 Message-ID: <7230287.A5AxNMN3qP@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:k8SIk/dCJ1WO+jqR1go5MxIRCvGargGZb3fIntgIuKq6jO+BMjE gnJIF6KHImwhi2ouHVOM/3Us1fDNStB5oCkMnWA2Vm/37piGCuMmaJtEXgfHBJ3U2oy9SIA 1Nh0zhugh3oFoeatqpjCKGd/CqVK1s+eQgyZYgaw2QV5j60NA4N2lMESICFrXL48zRWvEiq gMasZLCvhN+SJ3kUejW7Q== X-UI-Out-Filterresults: notjunk:1; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150529_014007_191813_AE66A481 X-CRM114-Status: UNSURE ( 8.31 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.1 (-) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-1.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.24 listed in list.dnswl.org] -1.1 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.17.24 listed in wl.mailspike.net] Cc: Denys Vlasenko , David Woodhouse , Artem Bityutskiy , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Dan Carpenter , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org A recent change to move cfi helper functions out of line is causing build errors when cfi-util is a loadable module and jedecprobe is built-in: drivers/built-in.o: In function `jedec_reset': (.text+0x140694): undefined reference to `cfi_send_gen_cmd' drivers/built-in.o: In function `jedec_probe_chip': (.text+0x140794): undefined reference to `cfi_build_cmd_addr' This adds a 'select' for the module containing these functions from the jedecprobe code, to ensure it is always reachable. Signed-off-by: Arnd Bergmann Fixes: 4612c715a6ea6 ("mtd: cfi: deinline large functions") diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig index 6f20977f8cf6..63b6b536b044 100644 --- a/drivers/mtd/chips/Kconfig +++ b/drivers/mtd/chips/Kconfig @@ -16,6 +16,7 @@ config MTD_CFI config MTD_JEDECPROBE tristate "Detect non-CFI AMD/JEDEC-compatible flash chips" select MTD_GEN_PROBE + select MTD_CFI_UTIL help This option enables JEDEC-style probing of flash chips which are not compatible with the Common Flash Interface, but will use the common