| Message ID | 4FAD51B7.6010303@adbglobal.com |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2012-05-11 at 20:51 +0300, Dmitry Maluka wrote: > It seems there is a bug in scan_read_raw_oob() in nand_bbt.c which > should cause wrong functioning of NAND_BBT_SCANALLPAGES option. > > Possible fix (relies on offs passed page-aligned): > > --- a/drivers/mtd/nand/nand_bbt.c > +++ b/drivers/mtd/nand/nand_bbt.c > @@ -324,6 +324,7 @@ static int scan_read_raw_oob(struct mtd_info *mtd, > uint8_t *buf, loff_t offs, > > buf += mtd->oobsize + mtd->writesize; > len -= mtd->writesize; > + offs += mtd->writesize; > } > return 0; > } Looks like a correct fix. Did you encounter a real bug and then spot this issue, or you spot it by reading the code?
On Fri, 2012-05-11 at 20:51 +0300, Dmitry Maluka wrote: > It seems there is a bug in scan_read_raw_oob() in nand_bbt.c which > should cause wrong functioning of NAND_BBT_SCANALLPAGES option. > > Possible fix (relies on offs passed page-aligned): I pushed it to l2-mtd.git, but please, tell how you found this issue. Also you did not provide signed-off-by - can I add this: Signed-off-by: Dmitry Maluka <D.Maluka@adbglobal.com> ? Also note, the patch was line-wrapped and did not apply, so I had to amend it.
On 05/15/2012 10:03 AM, Artem Bityutskiy wrote: > I pushed it to l2-mtd.git, but please, tell how you found this issue. Just by reading the code. I do not use NAND_BBT_SCANALLPAGES so I think I couldn't face this bug. > Also you did not provide signed-off-by - can I add this: > > Signed-off-by: Dmitry Maluka <D.Maluka@adbglobal.com> > > ? > > Also note, the patch was line-wrapped and did not apply, so I had to > amend it. Ok, no problem.
--- a/drivers/mtd/nand/nand_bbt.c +++ b/drivers/mtd/nand/nand_bbt.c @@ -324,6 +324,7 @@ static int scan_read_raw_oob(struct mtd_info *mtd, uint8_t *buf, loff_t offs, buf += mtd->oobsize + mtd->writesize; len -= mtd->writesize; + offs += mtd->writesize; } return 0;