From patchwork Mon Dec 5 07:05:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?ISO-8859-15?Q?Anders=20M=F8rk-Pedersen?= X-Patchwork-Id: 129229 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 66CA21007D4 for ; Mon, 5 Dec 2011 18:08:11 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RXSd5-0001wo-Iy; Mon, 05 Dec 2011 07:06:23 +0000 Received: from mail.frogne.dk ([195.97.164.18]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RXSd2-0001wa-Te for linux-mtd@lists.infradead.org; Mon, 05 Dec 2011 07:06:21 +0000 Received: from ishoej-MTA by mail.frogne.dk with Novell_GroupWise; Mon, 05 Dec 2011 08:06:18 +0100 Message-Id: <4EDC7B590200008E00014334@mail.frogne.dk> X-Mailer: Novell GroupWise Internet Agent 8.0.2 Date: Mon, 05 Dec 2011 08:05:45 +0100 From: "=?ISO-8859-15?Q?Anders=20M=F8rk-Pedersen?=" To: Subject: pxa2xx-flash.c Mime-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -3.1 (---) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-3.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org I have done as you instructed and created a patch for "git am" and attached it to this mail. I've also sent a copy to: Dmitry Eremin-Solenikov Best regards Anders On Fri, 2011-12-02 at 15:40 +0100, Anders Mørk-Pedersen wrote: > Hi, > > I've noticed a problem with a patch for the pxa2xx-flash.c map, which has been committed to the nextline kernel (currently 3.2-rc3) > > The problem is that hardcoded mtd partitions are no longer probed - and that breaks a lot of board support modules. > > The patch is described as > "mtd: pxa2xx-flash.c: use mtd_device_parse_register" > > and can be seen here: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=6fcdc92fce81eadcee262a7a66bf3207314fab87 > > I have created a small patch to address this. Looks OK, but could you please send a patch suitable for 'git am'? So that I save your mail and give it to git-am and end up with a commit which has you as the author, and a nice commit message. Also, please, CC Dmitry Eremin-Solenikov dev.platform_data; struct pxa2xx_flash_info *info; struct resource *res; + struct mtd_part_parser_data ppdata; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) @@ -98,7 +99,10 @@ static int __devinit pxa2xx_flash_probe(struct platform_device *pdev) } info->mtd->owner = THIS_MODULE; - mtd_device_parse_register(info->mtd, probes, 0, NULL, 0); + ppdata.of_node = pdev->dev.of_node; + mtd_device_parse_register(info->mtd, probes, &ppdata, + flash ? flash->parts : NULL, + flash ? flash->nr_parts : 0); platform_set_drvdata(pdev, info); return 0;