From patchwork Mon Nov 24 11:37:05 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Hunter X-Patchwork-Id: 10381 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 52CAADDDEF for ; Mon, 24 Nov 2008 22:29:51 +1100 (EST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1L4ZcM-0006S8-28; Mon, 24 Nov 2008 11:28:38 +0000 Received: from smtp.nokia.com ([192.100.122.233] helo=mgw-mx06.nokia.com) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1L4ZcK-0006Rw-EI; Mon, 24 Nov 2008 11:28:36 +0000 Received: from esebh105.NOE.Nokia.com (esebh105.ntc.nokia.com [172.21.138.211]) by mgw-mx06.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id mAOBSML4027850; Mon, 24 Nov 2008 13:28:24 +0200 Received: from vaebh102.NOE.Nokia.com ([10.160.244.23]) by esebh105.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 24 Nov 2008 13:28:08 +0200 Received: from vaebe112.NOE.Nokia.com ([10.160.244.81]) by vaebh102.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 24 Nov 2008 13:28:08 +0200 Received: from [172.21.40.95] ([172.21.40.95]) by vaebe112.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 24 Nov 2008 13:28:07 +0200 Message-ID: <492A91E1.50305@nokia.com> Date: Mon, 24 Nov 2008 13:37:05 +0200 From: Adrian Hunter User-Agent: Thunderbird 2.0.0.17 (X11/20080925) MIME-Version: 1.0 To: Russell King - ARM Linux Subject: Re: Please fix or remove OMAP2 onenand driver References: <20081123165011.GB17438@flint.arm.linux.org.uk> In-Reply-To: <20081123165011.GB17438@flint.arm.linux.org.uk> X-OriginalArrivalTime: 24 Nov 2008 11:28:07.0489 (UTC) FILETIME=[B9379B10:01C94E27] X-Nokia-AV: Clean X-Spam-Score: -4.0 (----) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (-4.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -4.0 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [192.100.122.233 listed in list.dnswl.org] Cc: dwmw2@infradead.org, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Russell King - ARM Linux wrote: > Clearly this driver has been put into mainline prematurely - it takes > no account of the relocation of headers. > > It's causing a regression - omap_2430sdp_defconfig used to build in > mainline, and it no longer does. > > Please fix, or remove this broken driver from mainline. From: Adrian Hunter Date: Mon, 24 Nov 2008 13:34:53 +0200 Subject: [PATCH] MTD: OMAP: OneNAND: header file relocation Signed-off-by: Adrian Hunter --- drivers/mtd/onenand/omap2.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c index e39b21d..28034ef 100644 --- a/drivers/mtd/onenand/omap2.c +++ b/drivers/mtd/onenand/omap2.c @@ -35,16 +35,16 @@ #include #include -#include -#include -#include -#include +#include +#include +#include +#include #include #include -#include +#include -#include +#include #define DRIVER_NAME "omap2-onenand"