| Message ID | 20260102-nxp-v2-1-05f5dd947459@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema | expand |
On Fri, Jan 02, 2026 at 10:48:50AM +0000, Akhila YS wrote: > Convert Microchip 23K256 SPI SRAM MTD binding to YAML format. You changed silently the binding. Every change - like dropping properties - must be explicitly documented and EXPLAINED WHY in the commit msg. > > Signed-off-by: Akhila YS <akhilayalmati@gmail.com> > --- > Changes in v2: > - Removed "#address-cells" and "#size-cells" from the required, properties > and example. > - Changed description and title for yaml. > - Link to v1: https://lore.kernel.org/r/20251229-nxp-v1-1-a415fe0080a8@gmail.com > --- > .../bindings/mtd/microchip,mchp23k256.txt | 18 -------- > .../bindings/mtd/microchip,mchp23k256.yaml | 49 ++++++++++++++++++++++ > 2 files changed, 49 insertions(+), 18 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt b/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt > deleted file mode 100644 > index 7328eb92a03c..000000000000 > --- a/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt > +++ /dev/null > @@ -1,18 +0,0 @@ > -* MTD SPI driver for Microchip 23K256 (and similar) serial SRAM > - > -Required properties: > -- #address-cells, #size-cells : Must be present if the device has sub-nodes > - representing partitions. > -- compatible : Must be one of "microchip,mchp23k256" or "microchip,mchp23lcv1024" > -- reg : Chip-Select number > -- spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at > - > -Example: > - > - spi-sram@0 { > - #address-cells = <1>; > - #size-cells = <1>; > - compatible = "microchip,mchp23k256"; > - reg = <0>; > - spi-max-frequency = <20000000>; > - }; > diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml b/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml > new file mode 100644 > index 000000000000..e928d375ae81 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/microchip,mchp23k256.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip 23K256 SPI SRAM > + > +maintainers: > + - Richard Weinberger <richard@nod.at> > + > +description: > + The Microchip 23K256 is a 256 Kbit (32 Kbyte) serial SRAM with an > + SPI interface,supporting clock frequencies up to 20 MHz. It features > + a 32-byte page size for writes and supports byte, page, and > + sequential access modes. > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + enum: > + - microchip,mchp23k256 > + - microchip,mchp23lcv1024 > + > + reg: > + maxItems: 1 > + > +required: > + - reg > + - compatible > + - spi-max-frequency > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + sram@0 { > + compatible = "microchip,mchp23k256"; > + reg = <0>; > + spi-max-frequency = <20000000>; > + }; Messed indentation now. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt b/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt deleted file mode 100644 index 7328eb92a03c..000000000000 --- a/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt +++ /dev/null @@ -1,18 +0,0 @@ -* MTD SPI driver for Microchip 23K256 (and similar) serial SRAM - -Required properties: -- #address-cells, #size-cells : Must be present if the device has sub-nodes - representing partitions. -- compatible : Must be one of "microchip,mchp23k256" or "microchip,mchp23lcv1024" -- reg : Chip-Select number -- spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at - -Example: - - spi-sram@0 { - #address-cells = <1>; - #size-cells = <1>; - compatible = "microchip,mchp23k256"; - reg = <0>; - spi-max-frequency = <20000000>; - }; diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml b/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml new file mode 100644 index 000000000000..e928d375ae81 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/microchip,mchp23k256.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mtd/microchip,mchp23k256.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip 23K256 SPI SRAM + +maintainers: + - Richard Weinberger <richard@nod.at> + +description: + The Microchip 23K256 is a 256 Kbit (32 Kbyte) serial SRAM with an + SPI interface,supporting clock frequencies up to 20 MHz. It features + a 32-byte page size for writes and supports byte, page, and + sequential access modes. + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + enum: + - microchip,mchp23k256 + - microchip,mchp23lcv1024 + + reg: + maxItems: 1 + +required: + - reg + - compatible + - spi-max-frequency + +unevaluatedProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + sram@0 { + compatible = "microchip,mchp23k256"; + reg = <0>; + spi-max-frequency = <20000000>; + }; + }; +...
Convert Microchip 23K256 SPI SRAM MTD binding to YAML format. Signed-off-by: Akhila YS <akhilayalmati@gmail.com> --- Changes in v2: - Removed "#address-cells" and "#size-cells" from the required, properties and example. - Changed description and title for yaml. - Link to v1: https://lore.kernel.org/r/20251229-nxp-v1-1-a415fe0080a8@gmail.com --- .../bindings/mtd/microchip,mchp23k256.txt | 18 -------- .../bindings/mtd/microchip,mchp23k256.yaml | 49 ++++++++++++++++++++++ 2 files changed, 49 insertions(+), 18 deletions(-) --- base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8 change-id: 20251229-nxp-526e29da9f29 Best regards,