| Message ID | 20250523155258.546003-1-Frank.Li@nxp.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] dt-bindings: mtd: jedec,spi-nor: Add atmel,at26* compatible string | expand |
On Fri, May 23, 2025 at 11:52:58AM -0400, Frank Li wrote: > Add atmel,at26* compatible string to fix below CHECK_DTB warning: > > arch/arm/boot/dts/nxp/vf/vf610-twr.dtb: /soc/bus@40000000/spi@4002c000/at26df081a@0: > failed to match any schema with compatible: ['atmel,at26df081a'] > > Signed-off-by: Frank Li <Frank.Li@nxp.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Fri, May 23 2025, Frank Li wrote: > Add atmel,at26* compatible string to fix below CHECK_DTB warning: > > arch/arm/boot/dts/nxp/vf/vf610-twr.dtb: /soc/bus@40000000/spi@4002c000/at26df081a@0: > failed to match any schema with compatible: ['atmel,at26df081a'] Is there any problem with setting the compatible to "jedec,spi-nor" in the DTS instead? If not, it would better to do that instead. [...]
On Tue, May 27, 2025 at 06:13:22PM +0200, Pratyush Yadav wrote: > On Fri, May 23 2025, Frank Li wrote: > > > Add atmel,at26* compatible string to fix below CHECK_DTB warning: > > > > arch/arm/boot/dts/nxp/vf/vf610-twr.dtb: /soc/bus@40000000/spi@4002c000/at26df081a@0: > > failed to match any schema with compatible: ['atmel,at26df081a'] > > Is there any problem with setting the compatible to "jedec,spi-nor" in > the DTS instead? If not, it would better to do that instead. I suppose it should work. But it is quite old legancy boards. I have not board to test it. And dt also prefer add chip specific compatible string before common failback compatible string in case need workaround some chip issues. Frank > > [...] > > -- > Regards, > Pratyush Yadav
On Wed, May 28 2025, Frank Li wrote: > On Tue, May 27, 2025 at 06:13:22PM +0200, Pratyush Yadav wrote: >> On Fri, May 23 2025, Frank Li wrote: >> >> > Add atmel,at26* compatible string to fix below CHECK_DTB warning: >> > >> > arch/arm/boot/dts/nxp/vf/vf610-twr.dtb: /soc/bus@40000000/spi@4002c000/at26df081a@0: >> > failed to match any schema with compatible: ['atmel,at26df081a'] >> >> Is there any problem with setting the compatible to "jedec,spi-nor" in >> the DTS instead? If not, it would better to do that instead. > > I suppose it should work. But it is quite old legancy boards. I have not > board to test it. And dt also prefer add chip specific compatible string > before common failback compatible string in case need workaround some chip > issues. Hmm, poking around with old DTs is probably not a good idea. Anyway, the flash is listed in spi_nor_dev_ids just like the others in this yaml, so this patch looks fine. Acked-by: Pratyush Yadav <pratyush@kernel.org>
On Fri, May 23 2025, Frank Li wrote: > Add atmel,at26* compatible string to fix below CHECK_DTB warning: > > arch/arm/boot/dts/nxp/vf/vf610-twr.dtb: /soc/bus@40000000/spi@4002c000/at26df081a@0: > failed to match any schema with compatible: ['atmel,at26df081a'] > > Signed-off-by: Frank Li <Frank.Li@nxp.com> Applied to spi-nor/next. Thanks! [...]
diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml index 335f8204aa1eb..587af4968255e 100644 --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml @@ -20,7 +20,7 @@ properties: - pattern: "^((((micron|spansion|st),)?\ (m25p(40|80|16|32|64|128)|\ n25q(32b|064|128a11|128a13|256a|512a|164k)))|\ - atmel,at25df(321a|641|081a)|\ + atmel,at(25|26)df(321a|641|081a)|\ everspin,mr25h(10|40|128|256)|\ (mxicy|macronix),mx25l(4005a|1606e|6405d|8005|12805d|25635e)|\ (mxicy|macronix),mx25u(4033|4035)|\
Add atmel,at26* compatible string to fix below CHECK_DTB warning: arch/arm/boot/dts/nxp/vf/vf610-twr.dtb: /soc/bus@40000000/spi@4002c000/at26df081a@0: failed to match any schema with compatible: ['atmel,at26df081a'] Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)