| Message ID | 20250428-qpic-snand-readloc2-fix-v1-1-50ce0877ff72@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | spi: spi-qpic-snand: fix NAND_READ_LOCATION_2 register handling | expand |
On 4/28/2025 1:00 PM, Gabor Juhos wrote: > The precomputed value for the NAND_READ_LOCATION_2 register should be > stored in 'snandc->regs->read_location2'. > > Fix the qcom_spi_set_read_loc_first() function accordingly. > > Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface") > Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> > --- > drivers/spi/spi-qpic-snand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c > index ae32c452d0bcf852b69b76e595f3588ea7e1a670..94948c8781e83f30650e5fbac56897daf5eb3c2c 100644 > --- a/drivers/spi/spi-qpic-snand.c > +++ b/drivers/spi/spi-qpic-snand.c > @@ -142,7 +142,7 @@ static void qcom_spi_set_read_loc_first(struct qcom_nand_controller *snandc, > else if (reg == NAND_READ_LOCATION_1) > snandc->regs->read_location1 = locreg_val; > else if (reg == NAND_READ_LOCATION_2) > - snandc->regs->read_location1 = locreg_val; > + snandc->regs->read_location2 = locreg_val; > else if (reg == NAND_READ_LOCATION_3) > snandc->regs->read_location3 = locreg_val; > } > > --- > base-commit: 15cfe55ec58ace931a73e19e5367598734ceb074 > change-id: 20250428-qpic-snand-readloc2-fix-bccd07cf26d3 Reviewed-by: Md Sadre Alam <quic_mdalam@quicinc.com> > > Best regards,
On Mon, 28 Apr 2025 09:30:55 +0200, Gabor Juhos wrote: > The precomputed value for the NAND_READ_LOCATION_2 register should be > stored in 'snandc->regs->read_location2'. > > Fix the qcom_spi_set_read_loc_first() function accordingly. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-qpic-snand: fix NAND_READ_LOCATION_2 register handling commit: 36fd6275818e93d5bc44140d546bf2a45e88feee All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c index ae32c452d0bcf852b69b76e595f3588ea7e1a670..94948c8781e83f30650e5fbac56897daf5eb3c2c 100644 --- a/drivers/spi/spi-qpic-snand.c +++ b/drivers/spi/spi-qpic-snand.c @@ -142,7 +142,7 @@ static void qcom_spi_set_read_loc_first(struct qcom_nand_controller *snandc, else if (reg == NAND_READ_LOCATION_1) snandc->regs->read_location1 = locreg_val; else if (reg == NAND_READ_LOCATION_2) - snandc->regs->read_location1 = locreg_val; + snandc->regs->read_location2 = locreg_val; else if (reg == NAND_READ_LOCATION_3) snandc->regs->read_location3 = locreg_val; }
The precomputed value for the NAND_READ_LOCATION_2 register should be stored in 'snandc->regs->read_location2'. Fix the qcom_spi_set_read_loc_first() function accordingly. Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface") Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> --- drivers/spi/spi-qpic-snand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 15cfe55ec58ace931a73e19e5367598734ceb074 change-id: 20250428-qpic-snand-readloc2-fix-bccd07cf26d3 Best regards,