From patchwork Wed Apr 9 15:43:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 2070661 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=z3RqPjGt; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=G5hLGzrd; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZXnLy3krbz1yJN for ; Thu, 10 Apr 2025 01:44:42 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a19diKBJDCmCNnL/4RidIT5FkjqjdHATGX+Xrfell8w=; b=z3RqPjGtvnE/nv hhxWghgpi1rUEvbtp+/3fW1TlokoLxbfi7YmEBMGdMEL3DDycjuqewLSV6cDs6pWB27Lutopz9tbG cW4eSfxTffsgFdHmBGQeShWn4w2PDZmdPYFTgWAIm8VckrTTu5bdrCIsSjEcdtTyvHNMZ9btcSpxo rmSDLuWkIeOwow/0CpC2yvfbStQa27setBSYROln5e0MdVSTZlO66IAIJAtUdf+bD5PHwsIfYmcoY S0d5kEzLiWx3LF+1Uohu8s9h22ErBOPdX9CkxHearVuocDIiZfSTqYPSsD2qiMLp8VPAhJow/XeAu N772/eXK3+1Tr9rlp1jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2Xbj-00000007kB1-2dRU; Wed, 09 Apr 2025 15:44:55 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2Xbh-00000007k9d-2uif; Wed, 09 Apr 2025 15:44:54 +0000 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-301a4d5156aso6642270a91.1; Wed, 09 Apr 2025 08:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213493; x=1744818293; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v49ZwnZIj2AOJhsRco4puem3oLXi78jqbt8BbW57LpM=; b=G5hLGzrdHyn9erXnrM+ApI3DvriuE/6gxIp0Q2ADkN4bDtF5d9wOYw5/fnG7krJKuU R2s3VarRka4Uta/vXUWRNdOvHOtskCKy5PDMVXBaRQWtPOeh7B20Uawy42kbScSbRpkP M3b5ui2ENdanhxBESyKmOyisXIGFJZb+zBPZbRtwuDIDVER4WVkc7HFAg49LWNHFVG/3 LmDU5nuJZDGKx/36rj6o27IBQOjwrZGNQsTmmBRzAqmH9fc+JHd8jt2fY+D5p6rAkr1l qchDeff3kgtviWuUTHWuyEZtFOfj62ojChADPW+KPlFqPyB+wf09UNzsVTKHoGChngvj pFog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213493; x=1744818293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v49ZwnZIj2AOJhsRco4puem3oLXi78jqbt8BbW57LpM=; b=J4vDWpAxoq+SEbHm5bCelZWTlqUJ3MHwyNzrV2KSUyL39gGM0hfVPeNjNTo5qUlruK YJOOowguIaozgh2jT2sL8f0rzFDQGm/f3ubbWwBIRcXfsWVCv+uAUBSV/8BprW84MPPh cjsmwQ//5qhKZVomrPdWbpO8G2rVwe5mv7vTmz1inJM/yepEnuKoUo1Laqs1lw1EnTfw hYljXGYKf0z/1ETU+UO9PhCjBdVEUgE24mzfShtxheIQi+d7BoVP+k2y3ckOVUpiyazm NT30wpdm6zW+MkPYOvXn10gDnVC28PXtFmSlQtVw/ei1QJQVq9SOQeu5oOdMbyC460I8 byvw== X-Forwarded-Encrypted: i=1; AJvYcCVMg9mzMk6dh7EtWsal08sF+vQdpXtsBVC4LQwIfeY0JI7PWZX22sTqS7gHPFYI48mAubVTGUordU78@lists.infradead.org, AJvYcCWuKc9DFU5sYABSglm2aPQPdEVAHkZyuTiQrW9bA6LE/+llKVOCQnXpL3+oHgo9jWbltJDmR1040k8=@lists.infradead.org X-Gm-Message-State: AOJu0Yz2F+T3FglWwOJKjzXiLk2FeF2u7kR7yeKizU7D7i1oqzI3m2Ya 8IufxqOcBUk2Lqa2e7Vo/2pau2bfUlCSJZ9ebplenZApAkV4kw2a X-Gm-Gg: ASbGncuwa633akc/2Mhs7WggbE/fMCN4cGUm+2D5V3gc95NSB9DYtJbqM5GjY6BMAIL 1lkFd10K/5tOnheuLP3YCSUh+/OcBI9lvS2ChMzcRkJqMtRM6E4OUFZoYKizWhbmknKC6p8omsA BX636+mu2PHmFXUBeGYlJWnvz35bVZI4Wn89xu5oCky0JPP7gtJDcQbZJiXN+DlHyYCoz6EHCPf Ai015jcqpXsaqHuqGguMGFqEnY/xbxxCKIobFPc/J5qNIkUwy8WASNVQNVaUjFvx15XDcs1WcA9 Lig7DjBVoE1UtGaXawASRcTvRcwx8OpLjNcHlW7Cb8AORcwbGc6zWn+q2BNSELNR6Neo9RErIfg wn1nq4A== X-Google-Smtp-Source: AGHT+IHDjC6NZDKGKeJbiK4hibwKJCoZJOXppnGBHSYZ9kKUia5ispG3D8M0PIfVIJ8M4eMwylwt9g== X-Received: by 2002:a17:90b:1f8f:b0:305:2d28:c8fd with SMTP id 98e67ed59e1d1-306dbc2bf43mr5380309a91.24.1744213492550; Wed, 09 Apr 2025 08:44:52 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:44:52 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 02/13] media: media/test_drivers: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:45 +0800 Message-Id: <20250409154356.423512-3-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_084453_731202_696A43D9 X-CRM114-Status: GOOD ( 10.53 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/test-drivers/vivid/vivid-vbi-gen.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletion [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:102e listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [visitorckw(at)gmail.com] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu Reviewed-by: Hans Verkuil --- drivers/media/test-drivers/vivid/vivid-vbi-gen.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/test-drivers/vivid/vivid-vbi-gen.c b/drivers/media/test-drivers/vivid/vivid-vbi-gen.c index 70a4024d461e..5e1b7b1742e4 100644 --- a/drivers/media/test-drivers/vivid/vivid-vbi-gen.c +++ b/drivers/media/test-drivers/vivid/vivid-vbi-gen.c @@ -5,6 +5,7 @@ * Copyright 2014 Cisco Systems, Inc. and/or its affiliates. All rights reserved. */ +#include #include #include #include @@ -165,12 +166,7 @@ static const u8 vivid_cc_sequence2[30] = { static u8 calc_parity(u8 val) { - unsigned i; - unsigned tot = 0; - - for (i = 0; i < 7; i++) - tot += (val & (1 << i)) ? 1 : 0; - return val | ((tot & 1) ? 0 : 0x80); + return val | (parity_odd(val) ? 0 : 0x80); } static void vivid_vbi_gen_set_time_of_day(u8 *packet)