| Message ID | 20250403134731.2054-1-vulab@iscas.ac.cn |
|---|---|
| State | New |
| Headers | show |
| Series | mtd: bcm47xxnflash: Add error handling for bcm47xxnflash_ops_bcm4706_ctl_cmd(). | expand |
… > Add error log to the bcm47xxnflash_ops_bcm4706_ctl_cmd() to prevent > selent failure. silent? You may omit a dot at the end of summary phrases. https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n665 Regards, Markus
diff --git a/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c b/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c index 6487dfc64258..c89129588bb6 100644 --- a/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c +++ b/drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c @@ -182,7 +182,8 @@ static void bcm47xxnflash_ops_bcm4706_cmd_ctrl(struct nand_chip *nand_chip, if (cmd != NAND_CMD_RESET) code |= NCTL_CSA; - bcm47xxnflash_ops_bcm4706_ctl_cmd(b47n->cc, code); + if (bcm47xxnflash_ops_bcm4706_ctl_cmd(b47n->cc, code)) + pr_err("%s ctl_cmd didn't work!\n", __func__); } /* Default nand_select_chip calls cmd_ctrl, which is not used in BCM4706 */
The bcm47xxnflash_ops_bcm4706_cmd_ctrl() calls bcm47xxnflash_ops_bcm4706_ctl_cmd() without printing error message. A proper implementation can be found in bcm47xxnflash_ops_bcm4706_write(). Add error log to the bcm47xxnflash_ops_bcm4706_ctl_cmd() to prevent selent failure. Signed-off-by: Wentao Liang <vulab@iscas.ac.cn> --- drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)