| Message ID | 20240417-mtd-nand-mxc-nand-exec-op-v1-4-d12564fe54e9@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | mtd: nand: mxc_nand: Convert to exec_op | expand |
On Wed, Apr 17, 2024 at 09:13:31AM +0200, Sascha Hauer wrote: > The NAND core enabled subpage reads when a largepage NAND is used with > SOFT_ECC. The i.MX NAND controller doesn't support subpage reads, so > clear the flag again. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > drivers/mtd/nand/raw/mxc_nand.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c > index f44c130dca18d..19b46210bd194 100644 > --- a/drivers/mtd/nand/raw/mxc_nand.c > +++ b/drivers/mtd/nand/raw/mxc_nand.c > @@ -1667,6 +1667,8 @@ static int mxcnd_probe(struct platform_device *pdev) > if (err) > goto escan; > > + this->options &= ~NAND_SUBPAGE_READ; > + Nah, it doesn't work like this. It turns out the BBT is read using subpage reads before we can disable them here. This is the code in nand_scan_tail() we stumble upon: /* Large page NAND with SOFT_ECC should support subpage reads */ switch (ecc->engine_type) { case NAND_ECC_ENGINE_TYPE_SOFT: if (chip->page_shift > 9) chip->options |= NAND_SUBPAGE_READ; break; default: break; } So the code assumes subpage reads are ok when SOFT_ECC is in use, which in my case is not true. I guess some drivers depend on the NAND_SUBPAGE_READ bit magically be set, so simply removing this code is likely not an option. Any ideas what to do? Sascha
Hi Sascha, s.hauer@pengutronix.de wrote on Thu, 18 Apr 2024 08:48:08 +0200: > On Wed, Apr 17, 2024 at 09:13:31AM +0200, Sascha Hauer wrote: > > The NAND core enabled subpage reads when a largepage NAND is used with > > SOFT_ECC. The i.MX NAND controller doesn't support subpage reads, so > > clear the flag again. > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > --- > > drivers/mtd/nand/raw/mxc_nand.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c > > index f44c130dca18d..19b46210bd194 100644 > > --- a/drivers/mtd/nand/raw/mxc_nand.c > > +++ b/drivers/mtd/nand/raw/mxc_nand.c > > @@ -1667,6 +1667,8 @@ static int mxcnd_probe(struct platform_device *pdev) > > if (err) > > goto escan; > > > > + this->options &= ~NAND_SUBPAGE_READ; > > + > > Nah, it doesn't work like this. It turns out the BBT is read using > subpage reads before we can disable them here. > > This is the code in nand_scan_tail() we stumble upon: > > /* Large page NAND with SOFT_ECC should support subpage reads */ > switch (ecc->engine_type) { > case NAND_ECC_ENGINE_TYPE_SOFT: > if (chip->page_shift > 9) > chip->options |= NAND_SUBPAGE_READ; > break; > > default: > break; > } > > So the code assumes subpage reads are ok when SOFT_ECC is in use, which > in my case is not true. I guess some drivers depend on the > NAND_SUBPAGE_READ bit magically be set, so simply removing this code is > likely not an option. Any ideas what to do? Can you elaborate why subpage reads are not an option in your situation? While subpage writes depend on chip capabilities, reads however should always work: it's just the controller selecting the column where to start and then reading less data than it could from the NAND cache. It's a very basic NAND controller feature, and I remember this was working on eg. an i.MX27. Thanks, Miquèl
On Thu, Apr 18, 2024 at 11:32:44AM +0200, Miquel Raynal wrote: > Hi Sascha, > > s.hauer@pengutronix.de wrote on Thu, 18 Apr 2024 08:48:08 +0200: > > > On Wed, Apr 17, 2024 at 09:13:31AM +0200, Sascha Hauer wrote: > > > The NAND core enabled subpage reads when a largepage NAND is used with > > > SOFT_ECC. The i.MX NAND controller doesn't support subpage reads, so > > > clear the flag again. > > > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > --- > > > drivers/mtd/nand/raw/mxc_nand.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c > > > index f44c130dca18d..19b46210bd194 100644 > > > --- a/drivers/mtd/nand/raw/mxc_nand.c > > > +++ b/drivers/mtd/nand/raw/mxc_nand.c > > > @@ -1667,6 +1667,8 @@ static int mxcnd_probe(struct platform_device *pdev) > > > if (err) > > > goto escan; > > > > > > + this->options &= ~NAND_SUBPAGE_READ; > > > + > > > > Nah, it doesn't work like this. It turns out the BBT is read using > > subpage reads before we can disable them here. > > > > This is the code in nand_scan_tail() we stumble upon: > > > > /* Large page NAND with SOFT_ECC should support subpage reads */ > > switch (ecc->engine_type) { > > case NAND_ECC_ENGINE_TYPE_SOFT: > > if (chip->page_shift > 9) > > chip->options |= NAND_SUBPAGE_READ; > > break; > > > > default: > > break; > > } > > > > So the code assumes subpage reads are ok when SOFT_ECC is in use, which > > in my case is not true. I guess some drivers depend on the > > NAND_SUBPAGE_READ bit magically be set, so simply removing this code is > > likely not an option. Any ideas what to do? > > Can you elaborate why subpage reads are not an option in your > situation? While subpage writes depend on chip capabilities, reads > however should always work: it's just the controller selecting the > column where to start and then reading less data than it could from the > NAND cache. It's a very basic NAND controller feature, and I remember > this was working on eg. an i.MX27. On the i.MX27 reading a full 2k page means triggering one read operation per 512 bytes in the NAND controller, so it would be possible to read subpages by triggering only one read operation instead of four in a row. The newer SoCs like i.MX25 always read a full page with a single read operation. We could likely read subpages by temporarily configuring the controller for a 512b page size NAND. I just realized the real problem comes with reading the OOB data. With software BCH the NAND layer hardcodes the read_subpage hook to nand_read_subpage() which uses nand_change_read_column_op() to read the OOB data. This uses NAND_CMD_RNDOUT and I have now idea if/how this can be implemented in the i.MX NAND driver. Right now the controller indeed reads some data and then the SRAM buffer really contains part of the desired OOB data, but also part of the user data. We might overcome these problems, but I am not sure if it's worth it. It's ancient hardware that I don't want to put too much effort into and I doubt that the end result would have a better performance when we need one operation to read the subpage and another one to read OOB as opposed to always read full pages (which is only one operation, say one interrupt latency, for each page read). Sascha
Hi Sascha, s.hauer@pengutronix.de wrote on Thu, 18 Apr 2024 13:43:15 +0200: > On Thu, Apr 18, 2024 at 11:32:44AM +0200, Miquel Raynal wrote: > > Hi Sascha, > > > > s.hauer@pengutronix.de wrote on Thu, 18 Apr 2024 08:48:08 +0200: > > > > > On Wed, Apr 17, 2024 at 09:13:31AM +0200, Sascha Hauer wrote: > > > > The NAND core enabled subpage reads when a largepage NAND is used with > > > > SOFT_ECC. The i.MX NAND controller doesn't support subpage reads, so > > > > clear the flag again. > > > > > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > > --- > > > > drivers/mtd/nand/raw/mxc_nand.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c > > > > index f44c130dca18d..19b46210bd194 100644 > > > > --- a/drivers/mtd/nand/raw/mxc_nand.c > > > > +++ b/drivers/mtd/nand/raw/mxc_nand.c > > > > @@ -1667,6 +1667,8 @@ static int mxcnd_probe(struct platform_device *pdev) > > > > if (err) > > > > goto escan; > > > > > > > > + this->options &= ~NAND_SUBPAGE_READ; > > > > + > > > > > > Nah, it doesn't work like this. It turns out the BBT is read using > > > subpage reads before we can disable them here. > > > > > > This is the code in nand_scan_tail() we stumble upon: > > > > > > /* Large page NAND with SOFT_ECC should support subpage reads */ > > > switch (ecc->engine_type) { > > > case NAND_ECC_ENGINE_TYPE_SOFT: > > > if (chip->page_shift > 9) > > > chip->options |= NAND_SUBPAGE_READ; > > > break; > > > > > > default: > > > break; > > > } > > > > > > So the code assumes subpage reads are ok when SOFT_ECC is in use, which > > > in my case is not true. I guess some drivers depend on the > > > NAND_SUBPAGE_READ bit magically be set, so simply removing this code is > > > likely not an option. Any ideas what to do? > > > > Can you elaborate why subpage reads are not an option in your > > situation? While subpage writes depend on chip capabilities, reads > > however should always work: it's just the controller selecting the > > column where to start and then reading less data than it could from the > > NAND cache. It's a very basic NAND controller feature, and I remember > > this was working on eg. an i.MX27. > > On the i.MX27 reading a full 2k page means triggering one read operation > per 512 bytes in the NAND controller, so it would be possible to read > subpages by triggering only one read operation instead of four in a row. > > The newer SoCs like i.MX25 always read a full page with a single read > operation. We could likely read subpages by temporarily configuring the > controller for a 512b page size NAND. > > I just realized the real problem comes with reading the OOB data. With > software BCH the NAND layer hardcodes the read_subpage hook to > nand_read_subpage() which uses nand_change_read_column_op() to read the > OOB data. This uses NAND_CMD_RNDOUT and I have now idea if/how this can > be implemented in the i.MX NAND driver. Right now the controller indeed > reads some data and then the SRAM buffer really contains part of the > desired OOB data, but also part of the user data. NAND_CMD_RNDOUT is impossible to avoid, the controller surely supports it and the core really need it anyway. Basically reading from a NAND chip is a matter of: - asking the chip to "sample" the NAND array and store a full page (data+OOB) in its internal SRAM - waiting for it to happen - reading from the chip's SRAM, any length, any offset. Of course the offset and length must be aligned with the on-host ECC engine when there is one. Supporting this command must be straightforward with ->exec_op(), here is the pattern: https://elixir.bootlin.com/linux/latest/source/drivers/mtd/nand/raw/nand_base.c#L1454 > We might overcome these problems, but I am not sure if it's worth it. > It's ancient hardware that I don't want to put too much effort into and > I doubt that the end result would have a better performance when we need > one operation to read the subpage and another one to read OOB as opposed > to always read full pages We shall definitely avoid doing several read operations, but as explained above, you can move the internal SRAM pointer at no cost ("read from cache" commands, named "changed_column" in the core), so the performance penalty is negligible. > (which is only one operation, say one > interrupt latency, for each page read). The mxc_nand.c driver was my first ever NAND controller driver re-write but unfortunately the quality was too bad for being submitted at that time. My goal was the same as yours. Quickly after we introduced ->exec_op() and thus my initial re-work was trash. But I think it was close to this: https://github.com/miquelraynal/linux/blob/perso/mtd-next/mxc-nand/drivers/mtd/nand/mxc_nand_v2.c Maybe that can help. Thanks, Miquèl
On Fri, Apr 19, 2024 at 11:46:57AM +0200, Miquel Raynal wrote: > Hi Sascha, > > s.hauer@pengutronix.de wrote on Thu, 18 Apr 2024 13:43:15 +0200: > > > On Thu, Apr 18, 2024 at 11:32:44AM +0200, Miquel Raynal wrote: > > > Hi Sascha, > > > > > > s.hauer@pengutronix.de wrote on Thu, 18 Apr 2024 08:48:08 +0200: > > > > > > > On Wed, Apr 17, 2024 at 09:13:31AM +0200, Sascha Hauer wrote: > > > > > The NAND core enabled subpage reads when a largepage NAND is used with > > > > > SOFT_ECC. The i.MX NAND controller doesn't support subpage reads, so > > > > > clear the flag again. > > > > > > > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > > > > --- > > > > > drivers/mtd/nand/raw/mxc_nand.c | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c > > > > > index f44c130dca18d..19b46210bd194 100644 > > > > > --- a/drivers/mtd/nand/raw/mxc_nand.c > > > > > +++ b/drivers/mtd/nand/raw/mxc_nand.c > > > > > @@ -1667,6 +1667,8 @@ static int mxcnd_probe(struct platform_device *pdev) > > > > > if (err) > > > > > goto escan; > > > > > > > > > > + this->options &= ~NAND_SUBPAGE_READ; > > > > > + > > > > > > > > Nah, it doesn't work like this. It turns out the BBT is read using > > > > subpage reads before we can disable them here. > > > > > > > > This is the code in nand_scan_tail() we stumble upon: > > > > > > > > /* Large page NAND with SOFT_ECC should support subpage reads */ > > > > switch (ecc->engine_type) { > > > > case NAND_ECC_ENGINE_TYPE_SOFT: > > > > if (chip->page_shift > 9) > > > > chip->options |= NAND_SUBPAGE_READ; > > > > break; > > > > > > > > default: > > > > break; > > > > } > > > > > > > > So the code assumes subpage reads are ok when SOFT_ECC is in use, which > > > > in my case is not true. I guess some drivers depend on the > > > > NAND_SUBPAGE_READ bit magically be set, so simply removing this code is > > > > likely not an option. Any ideas what to do? > > > > > > Can you elaborate why subpage reads are not an option in your > > > situation? While subpage writes depend on chip capabilities, reads > > > however should always work: it's just the controller selecting the > > > column where to start and then reading less data than it could from the > > > NAND cache. It's a very basic NAND controller feature, and I remember > > > this was working on eg. an i.MX27. > > > > On the i.MX27 reading a full 2k page means triggering one read operation > > per 512 bytes in the NAND controller, so it would be possible to read > > subpages by triggering only one read operation instead of four in a row. > > > > The newer SoCs like i.MX25 always read a full page with a single read > > operation. We could likely read subpages by temporarily configuring the > > controller for a 512b page size NAND. > > > > I just realized the real problem comes with reading the OOB data. With > > software BCH the NAND layer hardcodes the read_subpage hook to > > nand_read_subpage() which uses nand_change_read_column_op() to read the > > OOB data. This uses NAND_CMD_RNDOUT and I have now idea if/how this can > > be implemented in the i.MX NAND driver. Right now the controller indeed > > reads some data and then the SRAM buffer really contains part of the > > desired OOB data, but also part of the user data. > > NAND_CMD_RNDOUT is impossible to avoid, Apparently it has been possible until now. NAND_CMD_RNDOUT has never been used with this driver and it also doesn't work like expected. One problem is that the read_page_raw() and write_page_raw() are not implemented like supposed by the NAND layer. The i.MX NAND controller uses a syndrome type ECC layout, meaning that the user data and OOB data is interleaved, so the raw r/w functions should normally pass/expect the page data in interleaved format. Unfortunately the raw functions are not implemented like that, instead they detangle the data themselves. This also means that setting the cursor using NAND_CMD_RNDOUT will not put the cursor at a meaningful place, as the raw functions are not really exect/return the raw page data. This could be fixed, but the raw operations are also exposed to userspace, so fixing these would mean that we might break some userspace applications. The other point is that with using software BCH ecc the NAND layer requests me to read 7 bytes at offset 0x824. This can't be really implemented in the i.MX NAND driver. It only allows us to read a full 512 byte subpage, so whenever the NAND layer requests me to read a few bytes the controller will always transfer 512 bytes from which I then ignore most of it (and possibly trigger another 512 bytes transfer when reading the ECC for the next subpage). I think these issues can all be handled somehow, but this comes at a rather high price, both in effort and the risk of breaking userspace. It would be far easier to tell the NAND layer not to do subpage reads. Sascha
diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c index f44c130dca18d..19b46210bd194 100644 --- a/drivers/mtd/nand/raw/mxc_nand.c +++ b/drivers/mtd/nand/raw/mxc_nand.c @@ -1667,6 +1667,8 @@ static int mxcnd_probe(struct platform_device *pdev) if (err) goto escan; + this->options &= ~NAND_SUBPAGE_READ; + /* Register the partitions */ err = mtd_device_parse_register(mtd, part_probes, NULL, NULL, 0); if (err)
The NAND core enabled subpage reads when a largepage NAND is used with SOFT_ECC. The i.MX NAND controller doesn't support subpage reads, so clear the flag again. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- drivers/mtd/nand/raw/mxc_nand.c | 2 ++ 1 file changed, 2 insertions(+)