[mtd-utils,09/11] tests: ubifs_repair: Add bad images repairing test

Message ID	20231228013639.2827205-10-chengzhihao1@huawei.com
State	Rejected
Delegated to:	David Oberhollenzer
Headers	show Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Zhihao Cheng <chengzhihao1@huawei.com> To: <david.oberhollenzer@sigma-star.at>, <richard@nod.at>, <miquel.raynal@bootlin.com>, <s.hauer@pengutronix.de>, <Tudor.Ambarus@linaro.org> CC: <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org> Subject: [PATCH mtd-utils 09/11] tests: ubifs_repair: Add bad images repairing test Date: Thu, 28 Dec 2023 09:36:37 +0800 Message-ID: <20231228013639.2827205-10-chengzhihao1@huawei.com> In-Reply-To: <20231228013639.2827205-1-chengzhihao1@huawei.com> References: <20231228013639.2827205-1-chengzhihao1@huawei.com> MIME-Version: 1.0 preview: For kinds of inconsistent UBIFS images(which can simulate corruptions caused by some potentional UBIFS bug), check repairing result. This testcase mainly checks whether the behavior is in expected aft [...] Content analysis details: (-2.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [45.249.212.191 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5) [45.249.212.191 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Precedence: list Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	tests: Add new testcases for ubifs_repair \| expand [mtd-utils,00/11] tests: Add new testcases for ubifs_repair [mtd-utils,01/11] tests: Add common libs for ubifs_repair test [mtd-utils,02/11] tests: ubifs_repair: Add authentication refusing test [mtd-utils,03/11] tests: ubifs_repair: Add cycle mount+repair test [mtd-utils,04/11] tests: ubifs_repair: Add powercut+repair+mount test [mtd-utils,05/11] tests: ubifs_repair: Add corrupt+repair+fault_inject test [mtd-utils,06/11] tests: ubifs_repair: Add cycle_powercut+repair test [mtd-utils,07/11] tests: ubifs_repair: Add random_corrupt+repair test [mtd-utils,08/11] tests: ubifs_repair: Add corrupted images [mtd-utils,09/11] tests: ubifs_repair: Add bad images repairing test [mtd-utils,10/11] tests: ubifs_repair: Add run_all script [mtd-utils,11/11] tests: ubifs_repair: Add README

diff --git a/.gitignore b/.gitignore index dbe63b7..89bca58 100644 --- a/.gitignore +++ b/.gitignore @@ -119,6 +119,7 @@ tests/ubifs_repair-tests/tests/powercut_repair_mount.sh tests/ubifs_repair-tests/tests/cycle_corrupted_repair_fault_inject.sh tests/ubifs_repair-tests/tests/cycle_powercut_mount_repair.sh tests/ubifs_repair-tests/tests/random_corrupted_repair.sh +tests/ubifs_repair-tests/tests/repair_bad_image.sh # # Files generated by autotools diff --git a/configure.ac b/configure.ac index 11d34bd..1c1c95b 100644 --- a/configure.ac +++ b/configure.ac @@ -361,6 +361,7 @@ AC_CONFIG_FILES([tests/fs-tests/fs_help_all.sh tests/ubifs_repair-tests/tests/powercut_repair_mount.sh tests/ubifs_repair-tests/tests/cycle_corrupted_repair_fault_inject.sh tests/ubifs_repair-tests/tests/cycle_powercut_mount_repair.sh - tests/ubifs_repair-tests/tests/random_corrupted_repair.sh]) + tests/ubifs_repair-tests/tests/random_corrupted_repair.sh + tests/ubifs_repair-tests/tests/repair_bad_image.sh]) AC_OUTPUT([Makefile]) diff --git a/tests/ubifs_repair-tests/Makemodule.am b/tests/ubifs_repair-tests/Makemodule.am index 6070b0c..f728823 100644 --- a/tests/ubifs_repair-tests/Makemodule.am +++ b/tests/ubifs_repair-tests/Makemodule.am @@ -5,7 +5,8 @@ test_SCRIPTS += \ tests/ubifs_repair-tests/tests/powercut_repair_mount.sh \ tests/ubifs_repair-tests/tests/cycle_corrupted_repair_fault_inject.sh \ tests/ubifs_repair-tests/tests/cycle_powercut_mount_repair.sh \ - tests/ubifs_repair-tests/tests/random_corrupted_repair.sh + tests/ubifs_repair-tests/tests/random_corrupted_repair.sh \ + tests/ubifs_repair-tests/tests/repair_bad_image.sh test_DATA += \ tests/ubifs_repair-tests/images/good.gz \ diff --git a/tests/ubifs_repair-tests/tests/repair_bad_image.sh.in b/tests/ubifs_repair-tests/tests/repair_bad_image.sh.in new file mode 100755 index 0000000..ce9cb70 --- /dev/null +++ b/tests/ubifs_repair-tests/tests/repair_bad_image.sh.in @@ -0,0 +1,274 @@ +#!/bin/sh +# Copyright (c), 2023-2024, Huawei Technologies Co, Ltd. +# Author: Zhihao Cheng <chengzhihao1@huawei.com> +# +# Test Description: Tests whether all inconsistent UBIFS images can be fixed +# as expected. +# Origin UBIFS image content: +# / +# ├── corrupt_file (xattr - user.corrupt:123, 2K data) +# ├── dir +# │ ├── block_dev +# │ ├── char_dev +# │ ├── dir +# │ └── file (content: '123') +# ├── hardl_corrupt_file => corrupt_file +# └── softl_corrupt_file -> corrupt_file +# +# Running time: 2min + +TESTBINDIR=@TESTBINDIR@ +source $TESTBINDIR/common.sh + +CORRUPT_FILE=corrupt_file +XATTR_NAME="user.corrupt" +XATTR_VAL=123 +CORRUPT_FILE_MD5=7d2f953e91033c743ab6a801d5ee6e15 +SOFT_LINK_FILE=softl_corrupt_file +HARD_LINK_FILE=hardl_corrupt_file +DIR=dir +BLOCK_DEV=block_dev +CHAR_DEV=char_dev +FILE=file +FILE_MD5=ba1f2511fc30423bdbb183fe33f3dd0f + +function repair_image() +{ + local img_type=$1; + local img=$2; + local repair_failed=$3; + local file_exist=$4; + local file_nochange=$5 + local file_xattr_exist=$6; + local hard_link_exist=$7; + local hard_link_no_change=$8; + local hard_link_xattr_exist=$9; + local soft_link_exist=${10}; + local dir_exist=${11}; + + echo "======================================================================" + echo "repair $img_type, repair_failed:$repair_failed file_exist:$file_exist file_nochange:$file_nochange file_xattr_exist:$file_xattr_exist hard_link_exist:$hard_link_exist hard_link_no_change:$hard_link_no_change:hard_link_xattr_exist $hard_link_xattr_exist:soft_link_exist:$soft_link_exist dir_exist:$dir_exist" + + load_mtdram 1 16 || echo "cannot load mtdram" + mtdnum="$(find_mtd_device "$mtdram_patt")" + + gzip -f -k -d $TESTBINDIR/${img}.gz || fatal "gzip failed" + flash_eraseall /dev/mtd$mtdnum + dd if=$TESTBINDIR/$img of=/dev/mtd$mtdnum bs=1M + rm -f $TESTBINDIR/$img + modprobe ubi mtd="$mtdnum,0" fm_autoconvert || fatal "modprobe ubi fail" + modprobe ubifs || fatal "modprobe ubifs fail" + + echo 'format "UBIFS DBG repair" +pflmt' > /sys/kernel/debug/dynamic_debug/control + echo "$DEV" > /sys/kernel/debug/ubifs/repair_fs + ret=$? + check_memleak + if [[ $ret != 0 ]]; then + if [[ $repair_failed == 0 ]]; then + fatal "repair failed, but expect success" + fi + echo "repair failed is expected, skip" + + modprobe -r ubifs + modprobe -r ubi + modprobe -r mtdram + echo "----------------------------------------------------------------------" + + return; + else + if [[ $repair_failed != 0 ]]; then + fatal "repair success, but expect failure" + fi + fi + + dmesg -c > /dev/null # repairing could reproduce error messages + + enable_chkfs + + mount_ubifs $DEV $MNT + ret=$? + if [[ $ret != 0 ]]; then + fatal "mount failed $ret" + fi + + du -sh $MNT > /dev/null # Make sure all files are accessible + ret=$? + if [[ $ret != 0 ]]; then + fatal "cannot access all files $ret" + fi + + if [[ $file_exist == 1 ]]; then + if ! [ -f $MNT/$CORRUPT_FILE ]; then + fatal "$MNT/$CORRUPT_FILE is lost" + fi + else + if [ -f $MNT/$CORRUPT_FILE ]; then + fatal "$MNT/$CORRUPT_FILE should not exist" + fi + fi + + md5_after=`md5sum $MNT/$CORRUPT_FILE 2>/dev/null | awk '{print $1}'` + if [[ $file_nochange == 1 ]]; then + if [[ $CORRUPT_FILE_MD5 != $md5_after ]]; then + fatal "content changed for $MNT/$CORRUPT_FILE" + fi + else + if [[ $CORRUPT_FILE_MD5 == $md5_after ]]; then + fatal "content not changed for $MNT/$CORRUPT_FILE" + fi + fi + + xattr=`getfattr -n $XATTR_NAME $MNT/$CORRUPT_FILE 2>/dev/null | grep $XATTR_NAME | awk -F '=' '{ print $2 }'` + if [[ $file_xattr_exist == 1 ]]; then + if ! [[ "$xattr" =~ "$XATTR_VAL" ]]; then + fatal "wrong xattr $xattr for $MNT/$CORRUPT_DENT_NAME" + fi + else + if [[ "$xattr" =~ "$XATTR_VAL" ]]; then + fatal "xattr $xattr for $MNT/$CORRUPT_DENT_NAME should not exist" + fi + fi + + if [[ $hard_link_exist == 1 ]]; then + if ! [ -f $MNT/$HARD_LINK_FILE ]; then + fatal "$MNT/$HARD_LINK_FILE should is lost" + fi + else + if [ -f $MNT/$HARD_LINK_FILE ]; then + fatal "$MNT/$HARD_LINK_FILE should not exist" + fi + fi + + md5_after=`md5sum $MNT/$HARD_LINK_FILE 2>/dev/null | awk '{print $1}'` + if [[ $hard_link_no_change == 1 ]]; then + if [[ $CORRUPT_FILE_MD5 != $md5_after ]]; then + fatal "content changed for $MNT/$HARD_LINK_FILE" + fi + else + if [[ $CORRUPT_FILE_MD5 == $md5_after ]]; then + fatal "content not changed for $MNT/$HARD_LINK_FILE" + fi + fi + + xattr=`getfattr -n $XATTR_NAME $MNT/$HARD_LINK_FILE 2>/dev/null | grep $XATTR_NAME | awk -F '=' '{ print $2 }'` + if [[ $hard_link_xattr_exist == 1 ]]; then + if ! [[ "$xattr" =~ "$XATTR_VAL" ]]; then + fatal "wrong xattr $xattr for $MNT/$HARD_LINK_FILE" + fi + else + if [[ "$xattr" =~ "$XATTR_VAL" ]]; then + fatal "xattr $xattr for $MNT/$HARD_LINK_FILE should not exist" + fi + fi + + link=`stat -c %N $MNT/$SOFT_LINK_FILE 2>/dev/null | grep $SOFT_LINK_FILE | grep $CORRUPT_FILE` + if [[ $soft_link_exist == 1 ]]; then + if [[ "$link" == "" ]]; then + fatal "$MNT/$SOFT_LINK_FILE is lost" + fi + else + if [[ "$link" != "" ]]; then + fatal "$MNT/$SOFT_LINK_FILE should not exist" + fi + fi + + if [[ $dir_exist == 1 ]]; then + if ! [ -d $MNT/$DIR ]; then + fatal "$MNT/$DIR is lost" + fi + if ! [ -d $MNT/$DIR/$DIR ]; then + fatal "$MNT/$DIR/$DIR is lost" + fi + if ! [ -f $MNT/$DIR/$FILE ]; then + fatal "$MNT/$DIR/$FILE is lost" + fi + f_md5=`md5sum $MNT/$DIR/$FILE 2>/dev/null | awk '{print $1}'` + if [[ $FILE_MD5 != $f_md5 ]]; then + fatal "content changed for $MNT/$DIR/$FILE" + fi + if ! [ -b $MNT/$DIR/$BLOCK_DEV ]; then + fatal "$MNT/$DIR/$BLOCK_DEV is lost" + fi + major=`stat -c %t $MNT/$DIR/$BLOCK_DEV` + minor=`stat -c %T $MNT/$DIR/$BLOCK_DEV` + if [[ $major != 1 ]] || [[ $minor != 2 ]]; then + echo "major/minor changed for $MNT/$DIR/$BLOCK_DEV" + fi + if ! [ -c $MNT/$DIR/$CHAR_DEV ]; then + fatal "$MNT/$DIR/$CHAR_DEV is lost" + fi + major=`stat -c %t $MNT/$DIR/$CHAR_DEV` + minor=`stat -c %T $MNT/$DIR/$CHAR_DEV` + if [[ $major != 0 ]] || [[ $minor != 1 ]]; then + echo "major/minor changed for $MNT/$DIR/$CHAR_DEV" + fi + else + if [ -d $MNT/$DIR ]; then + fatal "$MNT/$DIR should not exist" + fi + fi + + umount $MNT + res=$? + if [[ $res != 0 ]] + then + fatal "unmount fail $res" + fi + + disable_chkfs + + check_err_msg + + modprobe -r ubifs + modprobe -r ubi + modprobe -r mtdram + + echo "----------------------------------------------------------------------" +} + +start_t=$(date +%s) +echo "Do inconsistent UBIFS images repairing test" +repair_image "good image" good 0 1 1 1 1 1 1 1 1 +repair_image "bad sb fanout image" sb_fanout 1 1 1 1 1 1 1 1 1 +repair_image "bad sb fmt_version image" sb_fmt_version 1 1 1 1 1 1 1 1 1 +repair_image "bad sb leb_size image" sb_leb_size 1 1 1 1 1 1 1 1 1 +repair_image "bad sb log_lebs image" sb_log_lebs 1 1 1 1 1 1 1 1 1 +repair_image "bad sb min_io_size image" sb_min_io_size 1 1 1 1 1 1 1 1 1 +repair_image "bad master highest_inum image" master_highest_inum 0 1 1 1 1 1 1 1 1 +repair_image "bad master lpt image" master_lpt 0 1 1 1 1 1 1 1 1 +repair_image "bad master tnc image" master_tnc 0 1 1 1 1 1 1 1 1 +repair_image "bad master total_dead image" master_total_dead 0 1 1 1 1 1 1 1 1 +repair_image "bad master total_dirty image" master_total_dirty 0 1 1 1 1 1 1 1 1 +repair_image "bad master total_free image" master_total_free 0 1 1 1 1 1 1 1 1 +repair_image "bad log image" log 0 1 1 1 1 1 1 1 1 +repair_image "bad lpt dirty image" lpt_dirty 0 1 1 1 1 1 1 1 1 +repair_image "bad lpt lpt_flags image" lpt_flags 0 1 1 1 1 1 1 1 1 +repair_image "bad lpt free image" lpt_free 0 1 1 1 1 1 1 1 1 +repair_image "bad lpt pos image" lpt_pos 0 1 1 1 1 1 1 1 1 +repair_image "bad tnc lv0 key image" tnc_lv0_key 0 1 1 1 1 1 1 1 1 +repair_image "bad tnc lv0 len image" tnc_lv0_len 0 1 1 1 1 1 1 1 1 +repair_image "bad tnc lv0 pos image" tnc_lv0_pos 0 1 1 1 1 1 1 1 1 +repair_image "bad tnc non-leaf key image" tnc_noleaf_key 0 1 1 1 1 1 1 1 1 +repair_image "bad tnc non-leaf len image" tnc_noleaf_len 0 1 1 1 1 1 1 1 1 +repair_image "bad tnc non-leaf pos image" tnc_noleaf_pos 0 1 1 1 1 1 1 1 1 +repair_image "bad inode data image" inode_data 0 1 0 1 1 0 1 1 1 +repair_image "bad inode mode image" inode_mode 0 1 1 1 1 1 1 0 1 +repair_image "bad inode nlink image" inode_nlink 0 1 1 1 1 1 1 1 1 +repair_image "bad inode size image" inode_size 0 1 1 1 1 1 1 1 1 +repair_image "bad inode xattr_cnt image" inode_xcnt 0 1 1 1 1 1 1 1 1 +repair_image "bad softlink data_len image" soft_link_data_len 0 1 1 1 1 1 1 0 1 +repair_image "bad dentry key image" dentry_key 0 0 0 0 1 1 1 1 1 +repair_image "bad dentry nlen image" dentry_nlen 0 0 0 0 1 1 1 1 1 +repair_image "bad dentry type image" dentry_type 0 0 0 0 1 1 1 1 1 +repair_image "bad xattr inode flags image" xinode_flags 0 1 1 0 1 1 0 1 1 +repair_image "bad xattr inode key image" xinode_key 0 1 1 0 1 1 0 1 1 +repair_image "bad xattr inode mode image" xinode_mode 0 1 1 0 1 1 0 1 1 +repair_image "bad xattr dentry key image" xentry_key 0 1 1 0 1 1 0 1 1 +repair_image "bad xattr dentry nlen image" xentry_nlen 0 1 1 0 1 1 0 1 1 +repair_image "bad xattr dentry type image" xentry_type 0 1 1 0 1 1 0 1 1 +repair_image "bad dir image" dir_lost 0 1 1 1 1 1 1 1 0 +repair_image "bad root dir image" root_dir 0 0 0 0 0 0 0 0 0 +end_t=$(date +%s) +time_cost=$(( end_t - start_t )) +echo "Success, cost $time_cost seconds" +exit 0

[mtd-utils,09/11] tests: ubifs_repair: Add bad images repairing test

Commit Message

Patch