| Message ID | 20230609144324.850617-2-miquel.raynal@bootlin.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | mtd: spi-nor: Support for another sst flash | expand |
On 6/9/23 15:43, Miquel Raynal wrote: > Add compatibles for the sst26vf0{40,80,16,32,64}b flash devices. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > index 7149784a36ac..5a788a429b0d 100644 > --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > @@ -25,7 +25,7 @@ properties: > (mxicy|macronix),mx25l(4005a|1606e|6405d|8005|12805d|25635e)|\ > (mxicy|macronix),mx25u(4033|4035)|\ > (spansion,)?s25fl(128s|256s1|512s|008k|064k|164k)|\ > - (sst|microchip),sst25vf(016b|032b|040b)|\ > + (sst|microchip),sst(25|26)vf(008|016|032|040|064)b|\ We don't add new compatibles to this list, one should instead use the generic jedec,spi-nor compatible. Please drop this patch. > (sst,)?sst26wf016b|\ > (sst,)?sst25wf(040b|080)|\ > winbond,w25x(80|32)|\
Hi Tudor, tudor.ambarus@linaro.org wrote on Mon, 12 Jun 2023 11:00:03 +0100: > On 6/9/23 15:43, Miquel Raynal wrote: > > Add compatibles for the sst26vf0{40,80,16,32,64}b flash devices. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > index 7149784a36ac..5a788a429b0d 100644 > > --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > @@ -25,7 +25,7 @@ properties: > > (mxicy|macronix),mx25l(4005a|1606e|6405d|8005|12805d|25635e)|\ > > (mxicy|macronix),mx25u(4033|4035)|\ > > (spansion,)?s25fl(128s|256s1|512s|008k|064k|164k)|\ > > - (sst|microchip),sst25vf(016b|032b|040b)|\ > > + (sst|microchip),sst(25|26)vf(008|016|032|040|064)b|\ > > We don't add new compatibles to this list, one should instead use the > generic jedec,spi-nor compatible. Please drop this patch. Sure. I'll propose a patch to clarify this point in the bindings to help future-myself. > > > (sst,)?sst26wf016b|\ > > (sst,)?sst25wf(040b|080)|\ > > winbond,w25x(80|32)|\ Thanks, Miquèl
diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml index 7149784a36ac..5a788a429b0d 100644 --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml @@ -25,7 +25,7 @@ properties: (mxicy|macronix),mx25l(4005a|1606e|6405d|8005|12805d|25635e)|\ (mxicy|macronix),mx25u(4033|4035)|\ (spansion,)?s25fl(128s|256s1|512s|008k|064k|164k)|\ - (sst|microchip),sst25vf(016b|032b|040b)|\ + (sst|microchip),sst(25|26)vf(008|016|032|040|064)b|\ (sst,)?sst26wf016b|\ (sst,)?sst25wf(040b|080)|\ winbond,w25x(80|32)|\
Add compatibles for the sst26vf0{40,80,16,32,64}b flash devices. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)