| Message ID | 20230606175246.190465-14-miquel.raynal@bootlin.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | Prevent NAND chip unevaluated properties | expand |
On Tue, 06 Jun 2023 19:52:42 +0200, Miquel Raynal wrote: > List all the possible properties in the NAND chip as per the example and > set unevaluatedProperties to false in the NAND chip section. > > Cc: Heiko Stuebner <heiko@sntech.de> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > .../devicetree/bindings/mtd/rockchip,nand-controller.yaml | 3 +++ > 1 file changed, 3 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dtb: nand-controller@ff4b0000: nand@0: False schema does not allow {'reg': [[0]], 'label': ['rk-nand'], 'nand-bus-width': [[8]], 'nand-ecc-mode': ['hw'], 'nand-ecc-step-size': [[1024]], 'nand-ecc-strength': [[16]], 'nand-is-boot-medium': True, 'rockchip,boot-blks': [[8]], 'rockchip,boot-ecc-strength': [[16]]} From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.example.dtb: nand-controller@ff4b0000: nand@0: Unevaluated properties are not allowed ('label', 'nand-is-boot-medium' were unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230606175246.190465-14-miquel.raynal@bootlin.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml index 566f330851f7..3672632e2ffa 100644 --- a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml +++ b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml @@ -57,6 +57,7 @@ properties: patternProperties: "^nand@[0-7]$": type: object + $ref: raw-nand-chip.yaml properties: reg: minimum: 0 @@ -116,6 +117,8 @@ patternProperties: Only used in combination with 'nand-is-boot-medium'. + unevaluatedProperties: false + required: - compatible - reg
List all the possible properties in the NAND chip as per the example and set unevaluatedProperties to false in the NAND chip section. Cc: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- .../devicetree/bindings/mtd/rockchip,nand-controller.yaml | 3 +++ 1 file changed, 3 insertions(+)