| Message ID | 20230606175246.190465-13-miquel.raynal@bootlin.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | Prevent NAND chip unevaluated properties | expand |
On Tue, 06 Jun 2023 19:52:41 +0200, Miquel Raynal wrote: > nand-ecc-mode is a generic property which may apply to any raw NAND > chip, it does not need to be listed in each controller > description. Instead, let's reference the raw NAND chip description file > which contains the property. The description contained > "additionalProperties: false" which is wrong as other properties such as > partitions might very well be added in the final .dts, and anyway needs > to be converted into "unexpectedProperties: false" to fit the property > change new requirements. > > Cc: Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.example.dtb: nand-controller@e0f00000: nand@0: False schema does not allow {'reg': [[0]], 'nand-ecc-mode': ['hw']} From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.example.dtb: nand-controller@e0f00000: nand@0: Unevaluated properties are not allowed ('nand-ecc-mode' was unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230606175246.190465-13-miquel.raynal@bootlin.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml index 8c62c7d3d0cd..7fa6c659d0d4 100644 --- a/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml @@ -42,17 +42,16 @@ properties: patternProperties: "^nand@[a-f0-9]$": type: object + $ref: raw-nand-chip.yaml properties: reg: minimum: 0 maximum: 1 - nand-ecc-mode: true - nand-ecc-algo: const: hw - additionalProperties: false + unevaluatedProperties: false required: - compatible
nand-ecc-mode is a generic property which may apply to any raw NAND chip, it does not need to be listed in each controller description. Instead, let's reference the raw NAND chip description file which contains the property. The description contained "additionalProperties: false" which is wrong as other properties such as partitions might very well be added in the final .dts, and anyway needs to be converted into "unexpectedProperties: false" to fit the property change new requirements. Cc: Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)