| Message ID | 20230602215629.2568-1-zajec5@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [V2] dt-bindings: mtd: partitions: Include TP-Link SafeLoader in allowed list | expand |
On Fri, Jun 02, 2023 at 11:56:29PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > It's supposed to be there and it's needed for proper validation of DTS > files. > > This fixes following errors for Northstar based TP-Link routers: > bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed: > ['tplink,safeloader-partitions'] is too short > 'fixed-partitions' was expected > 'sercomm,sc-partitions' was expected > 'arm,arm-firmware-suite' was expected > 'brcm,bcm4908-partitions' was expected > 'brcm,bcm947xx-cfe-partitions' was expected > 'linksys,ns-partitions' was expected > 'qcom,smem-part' was expected > 'redboot-fis' was expected Something like this would have been sufficient, dumping the whole error into the commit message bloats it for no real gain, but I was asking for you to say what the issue was, not asking for a resubmission (yet anyway). Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On Fri, 2023-06-02 at 21:56:29 UTC, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > It's supposed to be there and it's needed for proper validation of DTS > files. > > This fixes following errors for Northstar based TP-Link routers: > > arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: 'oneOf' conditional failed, one must be fixed: > 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: 'pinctrl-[0-9]+' > '#address-cells' is a required property > '#size-cells' is a required property > 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition@[0-9a-f]+$', 'pinctrl-[0-9]+' > 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+' > 'fis-index-block' is a required property > arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed: > ['tplink,safeloader-partitions'] is too short > 'fixed-partitions' was expected > 'sercomm,sc-partitions' was expected > 'arm,arm-firmware-suite' was expected > 'brcm,bcm4908-partitions' was expected > 'brcm,bcm947xx-cfe-partitions' was expected > 'linksys,ns-partitions' was expected > 'qcom,smem-part' was expected > 'redboot-fis' was expected > From schema: Documentation/devicetree/bindings/mtd/mtd.yaml > arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: Unevaluated properties are not allowed ('partitions-table-offset' was unexpected) > From schema: Documentation/devicetree/bindings/mtd/mtd.yaml > arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: 'oneOf' conditional failed, one must be fixed: > 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: 'pinctrl-[0-9]+' > '#address-cells' is a required property > '#size-cells' is a required property > 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition@[0-9a-f]+$', 'pinctrl-[0-9]+' > 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+' > 'fis-index-block' is a required property > arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed: > ['tplink,safeloader-partitions'] is too short > 'fixed-partitions' was expected > 'sercomm,sc-partitions' was expected > 'arm,arm-firmware-suite' was expected > 'brcm,bcm4908-partitions' was expected > 'brcm,bcm947xx-cfe-partitions' was expected > 'linksys,ns-partitions' was expected > 'qcom,smem-part' was expected > 'redboot-fis' was expected > From schema: Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: Unevaluated properties are not allowed ('partitions-table-offset' was unexpected) > From schema: Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: Unevaluated properties are not allowed ('partitions' was unexpected) > From schema: Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > Acked-by: Conor Dooley <conor.dooley@microchip.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel
diff --git a/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml index 2edc65e0e361..1dda2c80747b 100644 --- a/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml +++ b/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml @@ -21,6 +21,7 @@ oneOf: - $ref: linksys,ns-partitions.yaml - $ref: qcom,smem-part.yaml - $ref: redboot-fis.yaml + - $ref: tplink,safeloader-partitions.yaml properties: compatible: true