| Message ID | 20230601054549.10843-5-nikita.shubin@maquefel.me |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | None | expand |
Hi Nikita, nikita.shubin@maquefel.me wrote on Thu, 1 Jun 2023 08:45:28 +0300: > Add YAML bindings for ts7250 NAND Controller. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > > Notes: > v0 -> v1: > > make it a nand contoller > > .../bindings/mtd/technologic,nand.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/technologic,nand.yaml > > diff --git a/Documentation/devicetree/bindings/mtd/technologic,nand.yaml b/Documentation/devicetree/bindings/mtd/technologic,nand.yaml > new file mode 100644 > index 000000000000..26d1d9c3331d > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/technologic,nand.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/technologic,nand.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Technologic Systems NAND controller > + > +maintainers: > + - Nikita Shubin <nikita.shubin@maquefel.me> > + > +allOf: > + - $ref: nand-controller.yaml > + > +properties: > + compatible: > + oneOf: > + - const: technologic,ts7200-nand > + - items: > + - enum: > + - technologic,ts7300-nand > + - technologic,ts7260-nand > + - technologic,ts7250-nand > + - const: technologic,ts7200-nand > + > + reg: > + maxItems: 1 > + > + '#address-cells': true > + '#size-cells': true > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: true Should be false I guess. > + > +examples: > + - | > + nand-controller@60000000 { > + compatible = "technologic,ts7200-nand"; > + reg = <0x60000000 0x8000000>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > +... Thanks, Miquèl
On 01/06/2023 07:45, Nikita Shubin wrote: > Add YAML bindings for ts7250 NAND Controller. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > > Notes: > v0 -> v1: > > make it a nand contoller > > .../bindings/mtd/technologic,nand.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/technologic,nand.yaml > > diff --git a/Documentation/devicetree/bindings/mtd/technologic,nand.yaml b/Documentation/devicetree/bindings/mtd/technologic,nand.yaml > new file mode 100644 > index 000000000000..26d1d9c3331d > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/technologic,nand.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/technologic,nand.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Technologic Systems NAND controller > + > +maintainers: > + - Nikita Shubin <nikita.shubin@maquefel.me> > + > +allOf: > + - $ref: nand-controller.yaml > + > +properties: > + compatible: > + oneOf: > + - const: technologic,ts7200-nand > + - items: > + - enum: > + - technologic,ts7300-nand > + - technologic,ts7260-nand > + - technologic,ts7250-nand > + - const: technologic,ts7200-nand > + > + reg: > + maxItems: 1 > + > + '#address-cells': true > + '#size-cells': true Except what Miquel wrote - drop these two. > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: true > + > +examples: > + - | > + nand-controller@60000000 { > + compatible = "technologic,ts7200-nand"; > + reg = <0x60000000 0x8000000>; > + #address-cells = <1>; > + #size-cells = <0>; Incomplete example. address/size cells do not make sense here alone. Finish the example. > + }; > + > +... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mtd/technologic,nand.yaml b/Documentation/devicetree/bindings/mtd/technologic,nand.yaml new file mode 100644 index 000000000000..26d1d9c3331d --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/technologic,nand.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mtd/technologic,nand.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Technologic Systems NAND controller + +maintainers: + - Nikita Shubin <nikita.shubin@maquefel.me> + +allOf: + - $ref: nand-controller.yaml + +properties: + compatible: + oneOf: + - const: technologic,ts7200-nand + - items: + - enum: + - technologic,ts7300-nand + - technologic,ts7260-nand + - technologic,ts7250-nand + - const: technologic,ts7200-nand + + reg: + maxItems: 1 + + '#address-cells': true + '#size-cells': true + +required: + - compatible + - reg + +unevaluatedProperties: true + +examples: + - | + nand-controller@60000000 { + compatible = "technologic,ts7200-nand"; + reg = <0x60000000 0x8000000>; + #address-cells = <1>; + #size-cells = <0>; + }; + +...
Add YAML bindings for ts7250 NAND Controller. Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> --- Notes: v0 -> v1: make it a nand contoller .../bindings/mtd/technologic,nand.yaml | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/technologic,nand.yaml