Message ID | 20230401161938.2503204-49-u.kleine-koenig@pengutronix.de |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=X746vr2U; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=fB2H+t16; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjWy2fWBz1yZB for <incoming@patchwork.ozlabs.org>; Sun, 2 Apr 2023 02:38:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nKWeC3wNwHifLVF/Chf0GLb2K1LhmBuppV6BD6BV0dE=; b=X746vr2UYiDvRI a1VsbVuvDw3ADtWo/BDO+eleHm0/n4G5wt6wxOtl0IxuUxnQPseGoT+acSDPv7eXXMNNuqYoA6Ja3 V9XWBrTxRPW0vhRPCm6T4ghbgL2hQtE5efSsU1O+QgHleEUTC6YYHcokmi2efPEMllbiH2Sy72c4Z J0JGh4LfYDXjxac4o5XhvbsGdZlPcdjnJG6mEseP30dvkO4pWqiLL/JKpO2GFs/ZJajYXXF9ubgUR rV6h28JSEoO9xq7SGDi9lGXQ7aznDZzAKAsi4ujB9YTxxIE/F1PNObANnbIqNNdP3I+D9QClL8tIR 4zxP0WJeNeSSU5WyMxyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieEZ-00AwgM-30; Sat, 01 Apr 2023 16:37:43 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEK-00AwRk-1t for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=6YTKVNhVYU62naPvmcQkueKVrUUgKaFRioux7XyGtTQ=; b=fB2H+t16Fsi5z7arKOuipN4yDp c80PvoTslVnOssAKA7b5kjCZQxU3baj06leEYxnPkD+UI0u800S+6XsUdBrVI+mahZSW3K5b04lo/ 61/YDmHWok0XBhUK64QWEANf3If7SpuFNxLZzM18WAZUDcV8RoVEz6BPq7FBUOZdMt4zVXKMxYtGX GvBQI68mbd+c/WMU6xtgggbFDucCpZM0+lFHu45Rj2Of+k359j5dxYYaAbiBslcIUZ3zhQTwzD64B MQlXkCBsaFFk9jiv782UoPLkNcIo2qjONstRtBmWhTTQa48D3KjmgleFuInwhkcrspkdEr7I1Oykn Pr4URbWw==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYPV-TS for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1pidxP-0000KV-3K; Sat, 01 Apr 2023 18:19:59 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxN-008GTF-5z; Sat, 01 Apr 2023 18:19:57 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxM-009ki9-B8; Sat, 01 Apr 2023 18:19:56 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Stefan Agner <stefan@agner.ch>, Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com> Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 48/49] mtd: rawnand: vf610_nfc: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:37 +0200 Message-Id: <20230401161938.2503204-49-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1725; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=GrOH76yu1PLnzUKUatdG4MKq+Rlpxkq3aALTBWGM8g0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlUJYg3gY/NAkBfrkLhlIZgasPREVAV91JkC IdFJVgdItuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZVAAKCRCPgPtYfRL+ Ts1RB/wN3Lp3pwj/SNhPT4HWNXt1w8rPHZM2lc6ay7a/MDHYe93frEjuBQvMy/HwYGVU5NyIkjY FGgb1UjzTvm7HJ7ypQSrzPW1smfQQC6knc2BbRd2GczYAVHDyTtsfO9axrz1rEs0kPBOU5xnt7Y /6erqh4aT9NmPGzkYT7rCoOEfLL9A1QPT105S6Qvj+gc7dfG7CypS4+mF5xgrxfF/l3u+FVBHrT VCVTY9shVs9JBVelCL4PW/QNC+4cB6FVlpHREhi26z29ETB6HR14DwX5krCAifd/s/9oVgydagC K3Nst8HQGbuzNUyeJL8yrtDCTraawyiKm4pNbj8SXyp831mH X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_993994_7BC6C177 X-CRM114-Status: GOOD ( 12.66 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: nand: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c index b643332ea1ff..86522048e271 100644 --- a/drivers/mtd/nand/raw/vf610_nfc.c +++ b/drivers/mtd/nand/raw/vf610_nfc.c @@ -909,7 +909,7 @@ static int vf610_nfc_probe(struct platform_device *pdev) return err; } -static int vf610_nfc_remove(struct platform_device *pdev) +static void vf610_nfc_remove(struct platform_device *pdev) { struct vf610_nfc *nfc = platform_get_drvdata(pdev); struct nand_chip *chip = &nfc->chip; @@ -919,7 +919,6 @@ static int vf610_nfc_remove(struct platform_device *pdev) WARN_ON(ret); nand_cleanup(chip); clk_disable_unprepare(nfc->clk); - return 0; } #ifdef CONFIG_PM_SLEEP @@ -955,7 +954,7 @@ static struct platform_driver vf610_nfc_driver = { .pm = &vf610_nfc_pm_ops, }, .probe = vf610_nfc_probe, - .remove = vf610_nfc_remove, + .remove_new = vf610_nfc_remove, }; module_platform_driver(vf610_nfc_driver);
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mtd/nand/raw/vf610_nfc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)