Message ID | 20230401161938.2503204-43-u.kleine-koenig@pengutronix.de |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ojDE3j2i; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=QvKpLmtC; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Ppl3T1HTxz1yYP for <incoming@patchwork.ozlabs.org>; Sun, 2 Apr 2023 03:47:17 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l6LWRSq3dP1m0nBDXEqbzTlwZGbe6tzFRKDVqnpy2iQ=; b=ojDE3j2if9otHN sNZP/GAl0UuZSU1zvs64oUl7hir7nMNTar26PbvEFeLCnd9FmJn8Ownke33EhnEUNs61OTrMiIm7C StzqPRFLYSEmR50b12v6anvS974pi4Nxze452V+bPlD+T+OuTJ1LiXWxQiax1AAb9wGKf6ATIMUnu CAj5H8nCU1XWElnkRHfTplHuqz6XJuUpEbsV4TPqExowa4bq578mFVmOf/y5VkRNN5/LCpJAvwNCT QI+olp/sciRL1PuM/uHsnVKKJI2iROZmobi9RppDhmdc3+F0zrBiIrTx6VGLPBXazKchX9oR8b34+ 9CBSKvIUrmMoheWxY6pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pifJG-00B4AH-2x; Sat, 01 Apr 2023 17:46:38 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEK-00AwRk-0m for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=F4wck+ks+4to/R4TiUTZ2YDPxWlJIYAoZYky0TKDG4g=; b=QvKpLmtCNupcAxlk2E7Og8/URw qkCU7I1lwsb6RbW4JD3LekR+U2O5rXD/2pLMtF8peezKMukXYxmWYDpW/tMuiS4w7O1CeoM4j+fo9 wiJ1LCQR9qHzf2gq4SANapm1q3Aarl9+vZY2RVLLGrlS1hMJNy0suLZrFKA6b1IOIhKNqbWlLhQp9 kyK72fuPhIl9rjgR8V9nts9BEf/xsi/LwZwZlerOk4mQDmYOGFbQ5d+DbhhtmsvHnrpdaaYJ2D4Gs U4ap5JBmn+UZ/roGoNAStHCnE0WltWdnkmMrgb2cWXbOGv4o55witxKlfkN7b3LGGk9zjKHtyFl+5 Dg4agLMg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxS-00CYOX-TG for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1pidxO-0000FH-Bd; Sat, 01 Apr 2023 18:19:58 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxM-008GSx-D1; Sat, 01 Apr 2023 18:19:56 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxL-009khm-1h; Sat, 01 Apr 2023 18:19:55 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Miquel Raynal <miquel.raynal@bootlin.com>, Vignesh Raghavendra <vigneshr@ti.com>, Miaoqian Lin <linmq006@gmail.com> Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 42/49] mtd: rawnand: sh_flctl: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:31 +0200 Message-Id: <20230401161938.2503204-43-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1620; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=OxxfogUXdY3Kq+QGkZ0cg1gQEnSA/05REu23SWtVrzU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlND+8tMOdKWG94IDfmEmWxp61KDsqraKv/L 3uihieVIAGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZTQAKCRCPgPtYfRL+ Ti+zB/44Fh984vvSJFO/W8rj4GtOK3p3ViwY3py0aFQ1VcuUVOFZB1lK75XdurX1s3993MfKUZB iXXl9AHV/88uCuK3nm4Co4PS5I7LZCmtthPFBtf/UXlGQYBGD0hbGo932Bcq9PdnVT00QpK8xzU /qvQBn5bo3fQ6QLxB7pVFwYrFv2GK8+4WxVd1+wJYYRGOQt+t/ZY6AcfwjS0Uwem+hDYVg9xNLD NGL2rvnEDMTy1RxqYc521ivoXAiJCRFWQow+ANTqk1J4l3Et8VmhZVCwGK8jYXkQGSvS9J8GOMU 0IX0hMb8I3CQFiZKmKia+cTy7xdBNnMiJXhHBJQvnazMSe87 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172004_010497_60BEE7A7 X-CRM114-Status: GOOD ( 12.56 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: nand: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mtd/nand/raw/sh_flctl.c b/drivers/mtd/nand/raw/sh_flctl.c index a278829469d6..63bf20c41719 100644 --- a/drivers/mtd/nand/raw/sh_flctl.c +++ b/drivers/mtd/nand/raw/sh_flctl.c @@ -1203,7 +1203,7 @@ static int flctl_probe(struct platform_device *pdev) return ret; } -static int flctl_remove(struct platform_device *pdev) +static void flctl_remove(struct platform_device *pdev) { struct sh_flctl *flctl = platform_get_drvdata(pdev); struct nand_chip *chip = &flctl->chip; @@ -1214,12 +1214,10 @@ static int flctl_remove(struct platform_device *pdev) WARN_ON(ret); nand_cleanup(chip); pm_runtime_disable(&pdev->dev); - - return 0; } static struct platform_driver flctl_driver = { - .remove = flctl_remove, + .remove_new = flctl_remove, .driver = { .name = "sh_flctl", .of_match_table = of_flctl_match,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mtd/nand/raw/sh_flctl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)