Message ID | 20230401161938.2503204-37-u.kleine-koenig@pengutronix.de |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=bUGq/qIh; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=BlDrWoaM; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PpjXR1qkCz1yY8 for <incoming@patchwork.ozlabs.org>; Sun, 2 Apr 2023 02:38:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N4UjYDz/+WQ5GUNHw5ahvCxaGiFXLywwBgGGmRvAX4s=; b=bUGq/qIhLsig9x pPlwjm5Ylk28mD0jan7solRZPn5Ray6/wMWBkS1dr3qzkyl0tQFBa9bQuWlwDmBIVqIU6XON6nFfk JGksMgDQ4x4XZxaezS2bzfronO+uGbtkstYCwOkRDZXCl6PeVQ5EQQxLot9JidMA6Qd5nb6PDSHCJ Di/khPHcvk4PttbkhfZUy4bseZVgXqVGZ/jFb4AyhSq6roHyPktkSpp1mM3Xql3vNRNaiJFR3axVy f/iw+1wTASxB3/XCNTaLfTaxviTIg0E03Hv+5RndbKghqTtMz6xm01jh3KOdBtjuSnMN+Ingkik09 e+8lp0UvsmPH4vrcZGpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pieF8-00Ax5A-0s; Sat, 01 Apr 2023 16:38:18 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pieEO-00AwRk-0g for linux-mtd@bombadil.infradead.org; Sat, 01 Apr 2023 16:37:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=TeXN6K3AIPHjYsLgWZHGmyqOlz8GF0S1emngmyYWmu4=; b=BlDrWoaMAn3VFqI62ZCL3zJulG OEgG2/yxn0MGEHvRZZGbXmQ5wyKuVWIKlfB1zQuqNpPlUkJIRNIS+HoLXSQTTXK696eNYW1qnXBJ2 KKbJn4jIGaPTCo/RYgzV2Xifv0VCBL4klBkv/egOxT3iUClUsVKEXWhm85pXMzw010lXPPQlqNRYT KnoHhe4bNmne1PNuUuzwq6ZSGxLszsXaZ181+Rjszkii6ZUV2czXanoRPbGbCOhjO+uJ1a+iSAs9B cq3zMnRFFLO0XJ27nFOwCb++CSdExcXj1ZzmDZOrFfgJ99uQYJicoRk/5P3pdcaL/RMfjqccFxTqM bOJqdtCg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pidxT-00CYOG-AN for linux-mtd@lists.infradead.org; Sat, 01 Apr 2023 16:20:08 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1pidxL-0008RY-9o; Sat, 01 Apr 2023 18:19:55 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxK-008GSG-EW; Sat, 01 Apr 2023 18:19:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1pidxJ-009khM-QI; Sat, 01 Apr 2023 18:19:53 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Miquel Raynal <miquel.raynal@bootlin.com>, Naga Sureshkumar Relli <nagasure@xilinx.com>, Vignesh Raghavendra <vigneshr@ti.com> Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 36/49] mtd: rawnand: pl35x: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:25 +0200 Message-Id: <20230401161938.2503204-37-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1738; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=AxtPLgQzR7Pws7jjdB4styL0Lqk95tDnFAYXhQ+R31g=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlGQpBjusXQRZBv2p3prtnlHRb7v3esbGEmf 1ONCIeg4xqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZRgAKCRCPgPtYfRL+ TslAB/40NjSbGLG+7p+aKQKsumeNDWD7s5i2MGUHDybYdgGbnvNFU00IM6ngRS7NYAJQ2mPgBb3 V+Yme9xEOZXI+MjVYBnzQbKURiGnspzgy9kzm/kSD5TPoDR7hDgoDPLDCZyrXFMEdEvtzHvrf2k LKN/Fa4ievxfrO8wPJoxq+AOXZ3N0ffXuTg/WVIdOEuo8ADqkh9+2hSiV1BS2yftmPTPEeHnDmA S1R2bvRlidMaqY2a9sU3V+0Zx313mNy/2fS6iChIoMEnNOeYndpUzhu+EIlza/DSOz/k7SjwXGF TMVES0N7vGdzh0Ga8Bae8XsaALR8un3speUJxNW+/0KQ1LQY X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_172003_528342_05757122 X-CRM114-Status: GOOD ( 13.04 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.4.6 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: nand: Convert to platform remove callback returning void
|
expand
|
diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nand/raw/pl35x-nand-controller.c index 3c6f6aff649f..28b7bd7e22eb 100644 --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c @@ -1163,13 +1163,11 @@ static int pl35x_nand_probe(struct platform_device *pdev) return 0; } -static int pl35x_nand_remove(struct platform_device *pdev) +static void pl35x_nand_remove(struct platform_device *pdev) { struct pl35x_nandc *nfc = platform_get_drvdata(pdev); pl35x_nand_chips_cleanup(nfc); - - return 0; } static const struct of_device_id pl35x_nand_of_match[] = { @@ -1180,7 +1178,7 @@ MODULE_DEVICE_TABLE(of, pl35x_nand_of_match); static struct platform_driver pl35x_nandc_driver = { .probe = pl35x_nand_probe, - .remove = pl35x_nand_remove, + .remove_new = pl35x_nand_remove, .driver = { .name = PL35X_NANDC_DRIVER_NAME, .of_match_table = pl35x_nand_of_match,
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mtd/nand/raw/pl35x-nand-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)